From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sDXxBR28o2KwEwAAbAwnHQ (envelope-from ) for ; Fri, 10 Jun 2022 23:48:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6CMwBR28o2IOlwAAG6o9tA (envelope-from ) for ; Fri, 10 Jun 2022 23:48:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 98CA6792E for ; Fri, 10 Jun 2022 23:48:12 +0200 (CEST) Received: from localhost ([::1]:49786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzmUF-0002PA-C0 for larch@yhetil.org; Fri, 10 Jun 2022 17:48:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzmU7-0002Oz-14 for guix-patches@gnu.org; Fri, 10 Jun 2022 17:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzmU6-0000Au-Mx for guix-patches@gnu.org; Fri, 10 Jun 2022 17:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzmU6-0003V4-Ev for guix-patches@gnu.org; Fri, 10 Jun 2022 17:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55891] [PATCH] gnu: Add iec16022 Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Jun 2022 21:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55891 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Remco van 't Veer Cc: 55891@debbugs.gnu.org Received: via spool by 55891-submit@debbugs.gnu.org id=B55891.165489764313257 (code B ref 55891); Fri, 10 Jun 2022 21:48:02 +0000 Received: (at 55891) by debbugs.gnu.org; 10 Jun 2022 21:47:23 +0000 Received: from localhost ([127.0.0.1]:51468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzmTT-0003Rl-GY for submit@debbugs.gnu.org; Fri, 10 Jun 2022 17:47:23 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:44794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzmTM-0003RM-1J for 55891@debbugs.gnu.org; Fri, 10 Jun 2022 17:47:21 -0400 Received: from [172.20.10.5] ([213.119.181.187]) by xavier.telenet-ops.be with bizsmtp id hZnC2700H42zmhR01ZnDSu; Fri, 10 Jun 2022 23:47:14 +0200 Message-ID: From: Maxime Devos Date: Fri, 10 Jun 2022 23:47:00 +0200 In-Reply-To: <877d5opgd4.fsf@remworks.net> References: <20220610150448.9513-1-remco@remworks.net> <2dfe4787038a3c9b6fe21982aea621c4447eca75.camel@telenet.be> <877d5opgd4.fsf@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-gCNYuifR44hH29bxcuen" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1654897634; bh=m7S2E1gScDI7Uc7EEHEACYIBylD68kBhtgUMDGhUcCw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=jJ9iS8PdZXAe1ovx397iPpZv0u1xdHUrBO+bLbrMoqr2sJJQfppKgZnWhYDhXf42L blIgoss2ijy9gHrcfqD0gkRppQJPxnwCHG1C1kufPOz6B5ums5TrkbRsG0oY9UAhm1 48zkO65Dbux+hNAd+quGd7eYXB9BXAY4ZrSCx07mhb74AEegJEi9STqX76B58t/g/u ULpezvUbOTAoZvqJ5fVd9yFoAkcFTKuInLD6IvmS6IdxR5buzake1OZqGpZ2feLlwr 9ESdBjxYg3ZWvoS5+rpm8UDi43fC1cZ8URxBvqKgnen4B8+Vam7dBuTprvwIWdKAyC YMZCd6WBHuUCw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654897692; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=m7S2E1gScDI7Uc7EEHEACYIBylD68kBhtgUMDGhUcCw=; b=SIJNVEiLvNHot3T6S+3dyYDtg0Zb+ed3TpVBoMaPv+jMS8DnpTVtphnnN7h3FAhJtDbzMe R4MWtJ+OR76JST7iIf5XLE56JBO7Sqxh69bc9F58MqTxy/0Eq39ZVYNgHhjLO5KirJvKTI YCJa0TggkY+UfEDxDue6jnyXv80m7rVkftFmaL84pbXHZ+5qlpMIp2DvjHgbflLQaGYfMj P1yblY+Ct3IHjLjcYqRND2wPiNtBDavTk6HJY1pefMSmLghk60J7ZwrBauBQLjrzE4lSmo OUrBw37PKprzxaOWzWGOXzfHMx/pBGEzmxGCJSEvALg3mZ7olLdWQbCKdGsqig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654897692; a=rsa-sha256; cv=none; b=ObjpdsBEZOHyvpFLpUjcxFv+TglPpvnJlje2jNAlWUoAAx1HOefAEEYpq6odMMFZXrdu3u sTRlgdDtAsai7viXyf27dvKLrx0pUtVd40hIqFp1Xcu3AA4dyU2DoQN0p+nX7HZsngN4uF JLiskk1r1OU6aX4MzA5IqXr5NcD/ubB10PLI3ZW56lB2J5jzIjYid8jFlXe/qOPu0FK4Rm VJJbxzJR5KEYuSZTRNI9KOouSNg3M8gQTNAt8lsT6vSM5rRRF4G2ZAslGEo7CvbUHKtnt1 cyeb833oyar9LoxJrpociqes9fEZV0B4LNYzGKIJragU850mmi28V8SlkWj2bw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=jJ9iS8Pd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=jJ9iS8Pd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 98CA6792E X-Spam-Score: 2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7bDn03b/Vpuk --=-gCNYuifR44hH29bxcuen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op vr 10-06-2022 om 19:39 [+0200]: > > Contains a bug: on line > >=20 > > https://github.com/rdoeffinger/iec16022/blob/c9a9fd926fd1e6cca9782fe3f8= c2bab66010ca51/image.c#L284 > >=20 > > , it allocates a buffer, which can fail (by returning NULL). > > It then passes the possibly NULL buffer to compress2. > > Also, it writes files without checking for errors > > (e.g. EIO, ENOSPC or EDQUOT). >=20 > Good catch!=C2=A0 I'll need to brush up on my C skills to fix these. > Meanwhile I'd like to ship including bugs, WDYT? I think it's ok, _if_ the bugs are eventually at least reported upstream if we (i.e., you) cannot fix them timely (needs some contrived circumstances to trigger the bug). Greetings, Maxime. --=-gCNYuifR44hH29bxcuen Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqO71BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hhVAP0f1nWtgvlJxqKWhf/0zMFpZvLl kkI55vY7owbCHk4MggD9GzeIQgNr2CXdnKBT6VDj8c1JJmSlhi2aaBnlYgxtVAc= =3HbY -----END PGP SIGNATURE----- --=-gCNYuifR44hH29bxcuen--