From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SA2LOAnnB2CNEwAA0tVLHw (envelope-from ) for ; Wed, 20 Jan 2021 08:17:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4BRtNAnnB2DHXwAA1q6Kng (envelope-from ) for ; Wed, 20 Jan 2021 08:17:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 20AA39403AC for ; Wed, 20 Jan 2021 08:17:13 +0000 (UTC) Received: from localhost ([::1]:37870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l28fv-0006oF-O0 for larch@yhetil.org; Wed, 20 Jan 2021 03:17:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l28fm-0006nT-EZ for bug-guix@gnu.org; Wed, 20 Jan 2021 03:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l28fm-0004lq-6k for bug-guix@gnu.org; Wed, 20 Jan 2021 03:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l28fm-0007CH-2x for bug-guix@gnu.org; Wed, 20 Jan 2021 03:17:02 -0500 Subject: bug#45836: [PATCH] services: Let cups-service-type reuse base lp group. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 20 Jan 2021 08:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45836 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Mail-Followup-To: 45836@debbugs.gnu.org, leo.prikler@student.tugraz.at, leo.prikler@student.tugraz.at Received: via spool by 45836-done@debbugs.gnu.org id=D45836.161113057827607 (code D ref 45836); Wed, 20 Jan 2021 08:17:01 +0000 Received: (at 45836-done) by debbugs.gnu.org; 20 Jan 2021 08:16:18 +0000 Received: from localhost ([127.0.0.1]:52755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l28f4-0007BD-0f for submit@debbugs.gnu.org; Wed, 20 Jan 2021 03:16:18 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:47213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l28f2-0007B4-B4 for 45836-done@debbugs.gnu.org; Wed, 20 Jan 2021 03:16:16 -0500 Received: from nijino.local (217-149-173-242.nat.highway.telekom.at [217.149.173.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DLJJG2P3Dz1LBRv; Wed, 20 Jan 2021 09:16:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DLJJG2P3Dz1LBRv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1611130574; bh=JJs3b3eU/L/yrMfcOqK2jK2u+a/3v9Psi4uEHj2eTts=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MHJj8hMC/bY9UvRXJg0LQweZwHecPPaTjtUxaHSguQVLyxrt3D+HyKUhgD0JqIuuA auxHvzyRsK5CAl6gr3lfvr1FG6aOrr5WzKI7Eg3afWdfDPOvir4N3A9fHqRP2gdhDH h0K6LW/swgjucSIs0ccVq0RJ0DHuUidVMQarAhj8= Message-ID: From: Leo Prikler Date: Wed, 20 Jan 2021 09:16:13 +0100 In-Reply-To: <875z3ul2tj.fsf@gnu.org> References: <20210114130610.31936-1-leo.prikler@student.tugraz.at> <875z3wzq1k.fsf@gnu.org> <5c790abbd52abae17c6b449b4982380f9ae26806.camel@student.tugraz.at> <875z3ul2tj.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45836-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=MHJj8hMC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 20AA39403AC X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: tFgw7CrZZVnq Am Montag, den 18.01.2021, 15:47 +0100 schrieb Ludovic Courtès: > Hi, > > Leo Prikler skribis: > > > > > diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm > > > > index 0538fb1a24..7c57222716 100644 > > > > --- a/gnu/system/shadow.scm > > > > +++ b/gnu/system/shadow.scm > > > > @@ -321,13 +321,13 @@ of user '~a' is undeclared") > > > > objects. Raise an error if a user account refers > > > > to > > > > a undefined > > > > group." > > > > (define accounts > > > > - (filter user-account? accounts+groups)) > > > > + (delete-duplicates (filter user-account? accounts+groups) > > > > eq?)) > > > > > > > > (define user-specs > > > > (map user-account->gexp accounts)) > > > > > > > > (define groups > > > > - (filter user-group? accounts+groups)) > > > > + (delete-duplicates (filter user-group? accounts+groups) > > > > eq?)) > > > > > > Why use ‘eq?’? I’d use ‘equal?’, but note that > > > records > > > cannot necessarily be compared with ‘equal?’ because of the > > > thunked > > > ‘home-directory’ field (‘equal?’ is meaningless for procedures). > > My personal reasoning (and perhaps a rather strong opinion) is, > > that it > > is an error to add duplicate users even if they happen to be > > equal?. > > eq? is only provided as a way out for the specific case of > > services, > > that need to do so for safety reasons – e.g. cups to not allow > > overriding of the lp group if it has been removed from the OS > > groups > > for whichever reason. > > Ah I see, makes sense to me! I've now pushed it with eq?, if there's a (good!) reason to change that to equal?, it can still be done later. Regards, Leo