From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp0.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms13.migadu.com with LMTPS
	id wJd+Glk3PGe0fAEAqHPOHw:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 19 Nov 2024 06:59:37 +0000
Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0.migadu.com with LMTPS
	id wJd+Glk3PGe0fAEAqHPOHw
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 19 Nov 2024 07:59:37 +0100
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TGV7SSUm;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=a6vMB2lH;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1731999577;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=cCAl94rsMNTlvu6NprBvKee9APP2XEpDFhvQ0GdiLAg=;
	b=B63VLY4b0xNocvRM6cSVnoa6J8UtbZ1AfOqMgqFKhfjYtSWTyRXNmsxFtSJNk+EqiPBpa5
	GWk8v2/nUbOdWnjCmQBKbRS8BK9zXvpBr8XU3PEWQ61THAliSYTokfy5MD7zRkuDVkhici
	BPCn+NuodmqnNQzHjtxyuj4LfTaDuG5ZbUDdeRS4aDLqdldF+lqbGlkOeo7uwQGkO/2DGf
	pR/ugHBszroLrc7OFmUBhgik4Ex173egv8CXGC2Js6ogmHPFwczyyPk1WdoOxNbbDRSx8Y
	qPW1RK2OybGLg9G+IZ432HlGMS329ZUVUkFTQzSvx4x2YK8lKfUpW/XAj1NAcQ==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731999577; a=rsa-sha256; cv=none;
	b=T+liZeTjqorOW4VPRefEi1EIiWBKGI3lJDhd7/3/8mH68I1R6FyTQfvawg8zUDCy1yjd3g
	3HDpprnQiwx01haz0SeWKxz75Q5iOIh6zLyUYxE3m2TRijfPOwsQoc9+9jBPsjltx5T9Gv
	Mr80b0P1YWoNw1Eh2jBtGv0dIU68onV2gbIgguw5QJ+x8HZ01RAmF3y+vKcMmX/zEfpH9c
	1y5Yn2pPEu8rvadU1OvqXTKE9wKLby0F1gEqQR9h/Kvh6GSHwNmbiUrlX1cMJWHye7+hCt
	Th3BQXXpqCfiGG/eBPZrWK7SyzNhwY4Ac+QTZEjUG3tilW1sGE1zzWogzsbtxA==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TGV7SSUm;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=a6vMB2lH;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 473B87954C
	for <larch@yhetil.org>; Tue, 19 Nov 2024 07:59:36 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1tDICk-0008Oz-CN; Tue, 19 Nov 2024 01:59:18 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1tDICg-0008N1-Rz
 for guix-patches@gnu.org; Tue, 19 Nov 2024 01:59:14 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1tDICg-0004Jx-JA
 for guix-patches@gnu.org; Tue, 19 Nov 2024 01:59:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=debbugs.gnu.org; s=debbugs-gnu-org; 
 h=MIME-Version:References:In-Reply-To:Date:From:To:Subject;
 bh=cCAl94rsMNTlvu6NprBvKee9APP2XEpDFhvQ0GdiLAg=; 
 b=TGV7SSUm5910Sa/Q2iHulsQwWHLO4ZAVD2qPbcNdmFQwUG3VhuVthQIOjDgfhy0DIFLEwkmXcsFWuFZwrOICnk8C7Zf0+FiMvUq/JpluaF9eusOGuyOQkAB2LEh+uPCh8a1caftM7QIXJLrQ7hWtNWffTaAVBVlWq1Aqut9yityX0BYEdY2L1Qvq/uQhudSJC5lpqGB0BKHSiuGNFp5iHQPkYNlHSSh1aL6P6yg32Zrb25sE54EDWX3RRe39vfe5h15nZBTdtbgUSbIk2ZqPDXaGYOm6D9UCteHBaG7w8WMtFqw+WCBkmgivJ3hep0zZc46PKAp87VuPFssmyeTkJg==;
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tDICg-0005Hc-DW
 for guix-patches@gnu.org; Tue, 19 Nov 2024 01:59:14 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#74290] [PATCH v3 14/51] gnu: git-minimal: Support [cross-]build
 with gcc-14 and the 64bit Hurd.
Resent-From: Janneke Nieuwenhuizen <janneke@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Tue, 19 Nov 2024 06:59:14 +0000
Resent-Message-ID: <handler.74290.B74290.173199950819794@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 74290
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 74290@debbugs.gnu.org
Received: via spool by 74290-submit@debbugs.gnu.org id=B74290.173199950819794
 (code B ref 74290); Tue, 19 Nov 2024 06:59:14 +0000
Received: (at 74290) by debbugs.gnu.org; 19 Nov 2024 06:58:28 +0000
Received: from localhost ([127.0.0.1]:40475 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1tDIBv-000595-GC
 for submit@debbugs.gnu.org; Tue, 19 Nov 2024 01:58:27 -0500
Received: from eggs.gnu.org ([209.51.188.92]:48526)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <janneke@gnu.org>) id 1tDIBn-00056l-D5
 for 74290@debbugs.gnu.org; Tue, 19 Nov 2024 01:58:19 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <janneke@gnu.org>)
 id 1tDI9b-0003yD-Cg; Tue, 19 Nov 2024 01:56:03 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=cCAl94rsMNTlvu6NprBvKee9APP2XEpDFhvQ0GdiLAg=; b=a6vMB2lHOZhfDFUCH9mb
 lOZcC0tatyLkz/nlDVklyOYbaZ/xbyb2JV43lI4e+aUf0B3h4/viRTMDCM0q5B4ghInJdHhAcAgvx
 +ftuG90TbiyUJHgJVt0r2QSFgePorRrAjP9+5Yp3VYxZ4d2exl/O8Q5qBDR90loZKzqNuKCkIP/eJ
 Uty+ybMWRvCq6OCdltxpUGFXqxs4k9uOQrLAJKjEsBdfMclxrpWz4mP51gNJGRL9PlPiNCiRzkiPZ
 iDtmW3eDYZ6sjEaatqvIE89E7Il++X2NT8mCpU6uUGkrZd/vTvWxxK/IMOF69OIPg4HevGQJSVEpL
 wg8lPAmzsQAeuw==;
From: Janneke Nieuwenhuizen <janneke@gnu.org>
Date: Tue, 19 Nov 2024 07:54:44 +0100
Message-ID: <b8449d76042afc541ab5af2c26bb0cd2a96e8a8b.1731999203.git.janneke@gnu.org>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <cover.1731999202.git.janneke@gnu.org>
References: <cover.1731999202.git.janneke@gnu.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Spam-Score: -5.83
X-Spam-Score: -5.83
X-Migadu-Queue-Id: 473B87954C
X-Migadu-Scanner: mx13.migadu.com
X-TUID: g8x6enezXB8U

* gnu/packages/version-control.scm (git-minimal)[arguments]: When building for
the 64bit Hurd, or cross-compiling, use "-Wno-implicit-function-declaration"
in #:make-flags.  Use target-hurd? instead of comparing with "i586-pc-gnu" in
"use-host-uname_S" phase.

Change-Id: Ib9836be8a1e389a82c8a89adf22aaeac0d85bd14
---
 gnu/packages/version-control.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index c892a83a98..ca77b485ad 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -296,7 +296,10 @@ (define-public git-minimal
               ;; By default 'make install' creates hard links for
               ;; things in 'libexec/git-core', which leads to huge
               ;; nars; see <https://bugs.gnu.org/21949>.
-              "NO_INSTALL_HARDLINKS=indeed")
+              "NO_INSTALL_HARDLINKS=indeed"
+              #$@(if (or (target-hurd64?) (%current-target-system))
+                     #~("-Wno-implicit-function-declaration")
+                     #~()))
       #:phases
       #~(modify-phases %standard-phases
           #$@(if (%current-target-system)
@@ -305,7 +308,7 @@ (define-public git-minimal
                       (lambda _
                         (substitute* "config.mak.uname"
                           (("uname_S := .*" all)
-                           (if (equal? #$(%current-target-system) "i586-pc-gnu")
+                           (if #$(target-hurd?)
                                "uname_S := GNU\n"
                                all))))))
                  ;; We do not have a full bash when cross-compiling.
-- 
2.46.0