From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Prikler Subject: Re: Wheel group as polkit admins Date: Tue, 26 Nov 2019 13:35:17 +0100 Message-ID: References: <17ea661e09a034c36151b72ca1ab508a3fc52d1c.camel@student.tugraz.at> <87mucuo3hh.fsf@gnu.org> <329f03fbb1df8c78deaef37c06c5041b3504c15e.camel@student.tugraz.at> <87imna4im0.fsf@gnu.org> <3b18f59a286f79cbf648f35143bdec9ffd8717fe.camel@student.tugraz.at> <87a78j9c26.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-FMpjh1z+Wt/3G8bsjPIz" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:52168) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZa42-0005wI-Su for guix-devel@gnu.org; Tue, 26 Nov 2019 07:35:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZa40-0002Pn-T1 for guix-devel@gnu.org; Tue, 26 Nov 2019 07:35:30 -0500 In-Reply-To: <87a78j9c26.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org --=-FMpjh1z+Wt/3G8bsjPIz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ludo, Am Dienstag, den 26.11.2019, 11:17 +0100 schrieb Ludovic Court=C3=A8s: > Hi Leo, >=20 > Leo Prikler skribis: >=20 > > From 42eedd4d9d64a8432f787e68d64476c59200c1b6 Mon Sep 17 00:00:00 > > 2001 > > From: Leo Prikler > > Date: Sat, 23 Nov 2019 19:51:15 +0100 > > Subject: [PATCH 1/2] services: Add polkit-wheel-service. > >=20 > > * gnu/services/desktop.scm: (polkit-wheel): New variable. > > (polkit-wheel-service): New service. > > --- > > gnu/services/desktop.scm | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > >=20 > > diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm > > index 0152e86e8a..e58a08e068 100644 > > --- a/gnu/services/desktop.scm > > +++ b/gnu/services/desktop.scm > > @@ -135,6 +135,8 @@ > > inputattach-configuration? > > inputattach-service-type > > =20 > > + polkit-wheel-service > > + > > %desktop-services)) > > =20 > > ;;; Commentary: > > @@ -1064,6 +1066,25 @@ as expected."))) > > (description "Return a service that runs inputattach on a > > device and > > dispatches events from it."))) > > =20 > > + > > +;;; > > +;;; polkit-wheel-service > > +;;; > > + > > +(define polkit-wheel > > + (file-union > > + "polkit-wheel" > > + `(("share/polkit-1/rules.d/wheel.rules" > > + ,(plain-file > > + "wheel.rules" > > + "polkit.addAdminRule(function(action, subject) { > > + return [\"unix-group:wheel\"]; > > +}); > > +"))))) > > + > > +(define polkit-wheel-service > > + (simple-service 'polkit-wheel polkit-service-type (list polkit- > > wheel))) >=20 > Could you (1) add a comment saying what this does, like you did in > the > second patch, and (2) document it in guix.texi, presumably right > below > =E2=80=98polkit-service=E2=80=99? (1) I'm not sure whether I should copy/move the comment from the second patch, since that one is in line with the other comments for %desktop- services. I added a small, simplified comment in the "header" instead. (2) Done. > > From 1585513cc6d96e2f32a56850c9c26551a29d9f0f Mon Sep 17 00:00:00 > > 2001 > > From: Leo Prikler > > Date: Sat, 23 Nov 2019 19:58:11 +0100 > > Subject: [PATCH 2/2] services: Add polkit-wheel-service to > > %desktop-services. > >=20 > > * gnu/services/desktop.scm: (%desktop-services): Add polkit-wheel- > > service. >=20 > OK! >=20 > I=E2=80=99ll wait for your updated patch, thank you! >=20 > Ludo=E2=80=99. Patch is updated. Leo. --=-FMpjh1z+Wt/3G8bsjPIz Content-Disposition: attachment; filename="0001-services-Add-polkit-wheel-service.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-services-Add-polkit-wheel-service.patch"; charset="UTF-8" RnJvbSBmYWUxMDAzOWE1Yzg3NWU0OGNhMmFlODA4N2JhYjcwMmI2OWFjMGIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFNhdCwgMjMgTm92IDIwMTkgMTk6NTE6MTUgKzAxMDAKU3ViamVjdDogW1BB VENIIDEvMl0gc2VydmljZXM6IEFkZCBwb2xraXQtd2hlZWwtc2VydmljZS4KCiogZ251L3NlcnZp Y2VzL2Rlc2t0b3Auc2NtOiAocG9sa2l0LXdoZWVsKTogTmV3IHZhcmlhYmxlLgoocG9sa2l0LXdo ZWVsLXNlcnZpY2UpOiBOZXcgc2VydmljZS4KKiBkb2MvZ3VpeC50ZXhpOiBEb2N1bWVudCBwb2xr aXQtd2hlZWwtc2VydmljZS4KLS0tCiBkb2MvZ3VpeC50ZXhpICAgICAgICAgICAgfCAgNyArKysr KysrCiBnbnUvc2VydmljZXMvZGVza3RvcC5zY20gfCAyMSArKysrKysrKysrKysrKysrKysrKysK IDIgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RvYy9ndWl4 LnRleGkgYi9kb2MvZ3VpeC50ZXhpCmluZGV4IGE2NGIwZmI4NGMuLjNiZjVlYjI1ODcgMTAwNjQ0 Ci0tLSBhL2RvYy9ndWl4LnRleGkKKysrIGIvZG9jL2d1aXgudGV4aQpAQCAtMTU1ODUsNiArMTU1 ODUsMTMgQEAgY2FwYWJpbGl0aWVzIHRvIG9yZGluYXJ5IHVzZXJzLiAgRm9yIGV4YW1wbGUsIGFu IG9yZGluYXJ5IHVzZXIgY2FuIGJlIGdyYW50ZWQKIHRoZSBjYXBhYmlsaXR5IHRvIHN1c3BlbmQg dGhlIHN5c3RlbSBpZiB0aGUgdXNlciBpcyBsb2dnZWQgaW4gbG9jYWxseS4KIEBlbmQgZGVmZm4K IAorQGRlZnZyIHtTY2hlbWUgVmFyaWFibGV9IHBvbGtpdC13aGVlbC1zZXJ2aWNlCitTZXJ2aWNl IHRoYXQgYWRkcyB0aGUgQGNvZGV7d2hlZWx9IGdyb3VwIGFzIGFkbWlucyB0byB0aGUgUG9sa2l0 CitzZXJ2aWNlLiAgVGhpcyBtYWtlcyBpdCBzbyB0aGF0IHVzZXJzIGluIHRoZSBAY29kZXt3aGVl bH0gZ3JvdXAgYXJlIHF1ZXJpZWQKK2ZvciB0aGVpciBvd24gcGFzc3dvcmRzIHdoZW4gcGVyZm9y bWluZyBhZG1pbmlzdHJhdGl2ZSBhY3Rpb25zIGluc3RlYWQgb2YKK0Bjb2Rle3Jvb3R9J3MsIHNp bWlsYXIgdG8gdGhlIGJlaGF2aW91ciB1c2VkIGJ5IEBjb2Rle3N1ZG99LgorQGVuZCBkZWZ2cgor CiBAZGVmdnIge1NjaGVtZSBWYXJpYWJsZX0gdXBvd2VyLXNlcnZpY2UtdHlwZQogU2VydmljZSB0 aGF0IHJ1bnMgQHVyZWZ7aHR0cHM6Ly91cG93ZXIuZnJlZWRlc2t0b3Aub3JnLywgQGNvbW1hbmR7 dXBvd2VyZH19LCBhCiBzeXN0ZW0td2lkZSBtb25pdG9yIGZvciBwb3dlciBjb25zdW1wdGlvbiBh bmQgYmF0dGVyeSBsZXZlbHMsIHdpdGggdGhlIGdpdmVuCmRpZmYgLS1naXQgYS9nbnUvc2Vydmlj ZXMvZGVza3RvcC5zY20gYi9nbnUvc2VydmljZXMvZGVza3RvcC5zY20KaW5kZXggMDE1MmU4NmU4 YS4uOWVlZTJmYTQ4NSAxMDA2NDQKLS0tIGEvZ251L3NlcnZpY2VzL2Rlc2t0b3Auc2NtCisrKyBi L2dudS9zZXJ2aWNlcy9kZXNrdG9wLnNjbQpAQCAtMTM1LDYgKzEzNSw4IEBACiAgICAgICAgICAg ICBpbnB1dGF0dGFjaC1jb25maWd1cmF0aW9uPwogICAgICAgICAgICAgaW5wdXRhdHRhY2gtc2Vy dmljZS10eXBlCiAKKyAgICAgICAgICAgIHBvbGtpdC13aGVlbC1zZXJ2aWNlCisKICAgICAgICAg ICAgICVkZXNrdG9wLXNlcnZpY2VzKSkKIAogOzs7IENvbW1lbnRhcnk6CkBAIC0xMDY0LDYgKzEw NjYsMjUgQEAgYXMgZXhwZWN0ZWQuIikpKQogICAgKGRlc2NyaXB0aW9uICJSZXR1cm4gYSBzZXJ2 aWNlIHRoYXQgcnVucyBpbnB1dGF0dGFjaCBvbiBhIGRldmljZSBhbmQKIGRpc3BhdGNoZXMgZXZl bnRzIGZyb20gaXQuIikpKQogCisMCis7OzsKKzs7OyBwb2xraXQtd2hlZWwtc2VydmljZSAtLSBB bGxvdyB3aGVlbCBncm91cCB0byBwZXJmb3JtIGFkbWluIGFjdGlvbnMKKzs7OworCisoZGVmaW5l IHBvbGtpdC13aGVlbAorICAoZmlsZS11bmlvbgorICAgInBvbGtpdC13aGVlbCIKKyAgIGAoKCJz aGFyZS9wb2xraXQtMS9ydWxlcy5kL3doZWVsLnJ1bGVzIgorICAgICAgLChwbGFpbi1maWxlCisg ICAgICAgICJ3aGVlbC5ydWxlcyIKKyAgICAgICAgInBvbGtpdC5hZGRBZG1pblJ1bGUoZnVuY3Rp b24oYWN0aW9uLCBzdWJqZWN0KSB7CisgICAgcmV0dXJuIFtcInVuaXgtZ3JvdXA6d2hlZWxcIl07 Cit9KTsKKyIpKSkpKQorCisoZGVmaW5lIHBvbGtpdC13aGVlbC1zZXJ2aWNlCisgIChzaW1wbGUt c2VydmljZSAncG9sa2l0LXdoZWVsIHBvbGtpdC1zZXJ2aWNlLXR5cGUgKGxpc3QgcG9sa2l0LXdo ZWVsKSkpCisKIAwKIDs7OwogOzs7IFRoZSBkZWZhdWx0IHNldCBvZiBkZXNrdG9wIHNlcnZpY2Vz LgotLSAKMi4yNC4wCgo= --=-FMpjh1z+Wt/3G8bsjPIz Content-Disposition: attachment; filename*0=0002-services-Add-polkit-wheel-service-to-desktop-service.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0002-services-Add-polkit-wheel-service-to-desktop-service.patch"; charset="UTF-8" RnJvbSBkYjE0Nzc1NjdmYTZjOWEyMTdjN2ZhMTJjNmQ5YzQ5ZjBlMGIyODViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFNhdCwgMjMgTm92IDIwMTkgMTk6NTg6MTEgKzAxMDAKU3ViamVjdDogW1BB VENIIDIvMl0gc2VydmljZXM6IEFkZCBwb2xraXQtd2hlZWwtc2VydmljZSB0byAlZGVza3RvcC1z ZXJ2aWNlcy4KCiogZ251L3NlcnZpY2VzL2Rlc2t0b3Auc2NtOiAoJWRlc2t0b3Atc2VydmljZXMp OiBBZGQgcG9sa2l0LXdoZWVsLXNlcnZpY2UuCi0tLQogZ251L3NlcnZpY2VzL2Rlc2t0b3Auc2Nt IHwgMyArKysKIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9n bnUvc2VydmljZXMvZGVza3RvcC5zY20gYi9nbnUvc2VydmljZXMvZGVza3RvcC5zY20KaW5kZXgg OWVlZTJmYTQ4NS4uNGE1ODk4ZmJiOSAxMDA2NDQKLS0tIGEvZ251L3NlcnZpY2VzL2Rlc2t0b3Au c2NtCisrKyBiL2dudS9zZXJ2aWNlcy9kZXNrdG9wLnNjbQpAQCAtMTEwMSw2ICsxMTAxLDkgQEAg ZGlzcGF0Y2hlcyBldmVudHMgZnJvbSBpdC4iKSkpCiAgICAgICAgICA7OyBBZGQgdWRldiBydWxl cyBmb3IgTVRQIGRldmljZXMgc28gdGhhdCBub24tcm9vdCB1c2VycyBjYW4gYWNjZXNzCiAgICAg ICAgICA7OyB0aGVtLgogICAgICAgICAgKHNpbXBsZS1zZXJ2aWNlICdtdHAgdWRldi1zZXJ2aWNl LXR5cGUgKGxpc3QgbGlibXRwKSkKKyAgICAgICAgIDs7IEFkZCBwb2xraXQgcnVsZXMsIHNvIHRo YXQgbm9uLXJvb3QgdXNlcnMgaW4gdGhlIHdoZWVsIGdyb3VwIGNhbgorICAgICAgICAgOzsgcGVy Zm9ybSBhZG1pbmlzdHJhdGl2ZSB0YXNrcyAoc2ltaWxhciB0byAic3VkbyIpLgorICAgICAgICAg cG9sa2l0LXdoZWVsLXNlcnZpY2UKIAogICAgICAgICAgOzsgTmV0d29ya01hbmFnZXIgYW5kIGl0 cyBhcHBsZXQuCiAgICAgICAgICAoc2VydmljZSBuZXR3b3JrLW1hbmFnZXItc2VydmljZS10eXBl KQotLSAKMi4yNC4wCgo= --=-FMpjh1z+Wt/3G8bsjPIz--