From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTozu-0001R1-El for guix-patches@gnu.org; Sat, 08 Jul 2017 08:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTozq-0000RX-DX for guix-patches@gnu.org; Sat, 08 Jul 2017 08:38:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTozq-0000RT-9b for guix-patches@gnu.org; Sat, 08 Jul 2017 08:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dTozq-0003jA-53 for guix-patches@gnu.org; Sat, 08 Jul 2017 08:38:02 -0400 Subject: [bug#27616] [PATCH] gnu: you-get: Update to 0.4.775. Resent-Message-ID: References: <87lgnzdu0p.fsf@163.com> From: Ben Woodcroft Message-ID: Date: Sat, 8 Jul 2017 22:37:13 +1000 MIME-Version: 1.0 In-Reply-To: <87lgnzdu0p.fsf@163.com> Content-Type: multipart/alternative; boundary="------------9FE49DBFBD74DCA6E6EB389B" Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Feng Shu , 27616@debbugs.gnu.org This is a multi-part message in MIME format. --------------9FE49DBFBD74DCA6E6EB389B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Feng, thanks for the patch. On 08/07/17 21:53, Feng Shu wrote: > - (version "0.4.715") > + (version "0.4.775") > (source (origin > (method url-fetch) > (uri (string-append > -"https://github.com/soimort/you-get/releases/download/v" > - version "/you-get-" version ".tar.gz")) > +"https://github.com/soimort/you-get/archive/v" > + version ".tar.gz")) Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't contain "you-get" anymore (we prefer it does so the base directory doesn't fill with opaque names, and this is checked by 'guix lint'). We usually fix this by adding (file-name (string-append name "-" version ".tar.gz")) to the package definition. However, is there some reason why the URL scheme should be changed? Alternatively, we could also source this package from PyPI given that is recommended on the you-get website. WDYT? Thanks, ben. --------------9FE49DBFBD74DCA6E6EB389B Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Feng, thanks for the patch.

On 08/07/17 21:53, Feng Shu wrote:

-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))

Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't contain "you-get" anymore (we prefer it does so the base directory doesn't fill with opaque names, and this is checked by 'guix lint'). We usually fix this by adding

(file-name (string-append name "-" version ".tar.gz"))

to the package definition. However, is there some reason why the URL scheme should be changed? Alternatively, we could also source this package from PyPI given that is recommended on the you-get website. WDYT?

Thanks, ben.
--------------9FE49DBFBD74DCA6E6EB389B--