From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 6/9] gnu: fontforge: Make SVG builds reproducible. Date: Wed, 06 Apr 2016 12:44:31 -0500 Message-ID: References: <1459917181-19626-1-git-send-email-ericbavier@openmailbox.org> <1459917181-19626-6-git-send-email-ericbavier@openmailbox.org> <20160406173638.GB484@jasmine> Reply-To: bavier@member.fsf.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anrVW-0000OY-78 for guix-devel@gnu.org; Wed, 06 Apr 2016 13:44:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anrVS-0001wZ-VM for guix-devel@gnu.org; Wed, 06 Apr 2016 13:44:46 -0400 Received: from smtp1.openmailbox.org ([62.4.1.35]:56013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anrVS-0001wR-PJ for guix-devel@gnu.org; Wed, 06 Apr 2016 13:44:42 -0400 In-Reply-To: <20160406173638.GB484@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org On 2016-04-06 12:36, Leo Famulari wrote: > On Tue, Apr 05, 2016 at 11:32:58PM -0500, ericbavier@openmailbox.org > wrote: >> From: Eric Bavier >> >> * gnu/packages/fontutils.scm (fontforge)[source]: Add snippet to clear >> timestamp in svg.c. >> --- >> gnu/packages/fontutils.scm | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm >> index 75edd55..5ca9835 100644 >> --- a/gnu/packages/fontutils.scm >> +++ b/gnu/packages/fontutils.scm >> @@ -512,7 +512,12 @@ definitions.") >> ;; Make TTF builds bit-reproducible by clearing the >> timestamp >> ;; that goes in TTF files. >> (substitute* "fontforge/tottf.c" >> - (("cvt_unix_to_1904\\(now") >> "cvt_unix_to_1904(0")))))) >> + (("cvt_unix_to_1904\\(now") "cvt_unix_to_1904(0")) >> + >> + ;; Make SVG builds bit-reproducible by clearing the >> timestamp >> + ;; that goes in SVG files. >> + (substitute* "fontforge/svg.c" >> + (("ctime\\(&now\\)") "ctime(0)")))))) > > Could you use the value of the environment variable SOURCE_DATE_EPOCH > instead of 0? Probably. But I'd save that for a later update, since it would be a much bigger change (that we could hopefully move upstream). `~Eric