From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id GCVDDPoAUmb8xQAAe85BDQ:P1 (envelope-from ) for ; Sat, 25 May 2024 17:17:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id GCVDDPoAUmb8xQAAe85BDQ (envelope-from ) for ; Sat, 25 May 2024 17:17:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=LilT5FWx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716650234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=30pDOK4phNI2mdXsNUhzlmxu7c9JyXXYAfWZCLt3y5s=; b=U11HxYFlGUASXLxSKiYOHxXbmDMF0rvZHY3ywQ25aTwd60+QG1unCFWeXul4eIfaY9oLp2 AM5oTuc6X7i9dIVgGlSBmCZOrj3aIJCoyj+nEWcCJn/zdrqJnZ2c8NhX+4iN+OA0lvtY5e cipIKmA3MMMofOEImGOiUWdJDx6AQjCPYK+9rUut/C5zt6BFEIbBymfn7tsjxYrrzYy86J YpFpbgF2+mVgZJ14ZHD+tl9Ixn9t/pLqEkprZKCtdo7aQplLYjjBt+ShJ1UWzQT7iRw3DV SEVCbeAGqyqN4E7FoOV0/q0QJk9DfFf3BdPZLyq4NmTa/ZqOi2Ym2+BqGRWjDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=LilT5FWx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716650234; a=rsa-sha256; cv=none; b=CW/f2dOEsCOw1fD9CVfSGrPjjcCB8zhPzFtSi8P163llkf13/UFvAD5CnCok93zQFggDKy Sbc5Fk/qi+l6j7LtcQvEt86gRYaIHJiZwCQj+cYN4ZJ5eagt0YD4F6mxx3WWa/puFRtQzr vss2vFzFdu/s2UfgEekOhJF04IIcykRPfz9vTO0t7uJVIDhGvhUJXI7mJxndefYXbC3otI EMTQUElIrYzz/R9BsVFNdgMA0RNCfjMmvPeMHNj5X4VbQSMa5crrTYZ47dXzdqG+DRFJKy aIAnKLqh6o+84T46OJalvOvHbdbZQlkoR6UHDk0e1Z7DmRra+UW2cvjC4lk5tQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AD3447CE55 for ; Sat, 25 May 2024 17:17:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAt8o-0008Vm-30; Sat, 25 May 2024 11:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAt8k-0008UU-VL for guix-patches@gnu.org; Sat, 25 May 2024 11:17:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAt8g-0008OZ-La for guix-patches@gnu.org; Sat, 25 May 2024 11:16:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAt8o-0003dJ-78 for guix-patches@gnu.org; Sat, 25 May 2024 11:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 May 2024 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70460 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70460@debbugs.gnu.org, felix@alternativebit.fr, Florian Pelz Received: via spool by 70460-submit@debbugs.gnu.org id=B70460.171665016713820 (code B ref 70460); Sat, 25 May 2024 15:17:02 +0000 Received: (at 70460) by debbugs.gnu.org; 25 May 2024 15:16:07 +0000 Received: from localhost ([127.0.0.1]:44005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAt7u-0003ap-DQ for submit@debbugs.gnu.org; Sat, 25 May 2024 11:16:06 -0400 Received: from mout01.posteo.de ([185.67.36.65]:36907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAt7s-0003aB-0r for 70460@debbugs.gnu.org; Sat, 25 May 2024 11:16:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3FDDC240028 for <70460@debbugs.gnu.org>; Sat, 25 May 2024 17:15:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1716650150; bh=q9NRP2n9ZJw2Wl5ikg1r7BG6TxC1wNd9U0Nlibe/Dh0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=LilT5FWxj0OSfFd9v9XjkD20I9LBB+ykLMJvWHtXD7bRzbtI+N5S95+rQheUgFb0/ m5+ah+mXtGs656qC4F0hpN40iJj3CLK5CKYEq9nBH+n+BgqXx9uRtGV2CcOreJpyTb Nx/H/kj2ka60nXSSM/QtoisVS3GCkinXyQUxFgu3T0ihZrREUKufPppoaQwFydc2dC YyzmjFnEgeQjVgJROtseXYGhgiUhEFeY+A+YB6qsJumBTRqnALtjZxN4fMvq/BP7Dk th6qjQs0TzmbSH/L835W+OAiBhD185M3P5FIMqCqjXheY7vTwlsQfwG4Foh3Frt9H4 li115uNPHdsCQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Vmlps1sfgz9rxN; Sat, 25 May 2024 17:15:48 +0200 (CEST) Message-ID: Date: Sat, 25 May 2024 15:15:47 +0000 MIME-Version: 1.0 References: <87msoe10l1.fsf@gnu.org> Content-Language: en-US From: Dariqq In-Reply-To: <87msoe10l1.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.45 X-Migadu-Queue-Id: AD3447CE55 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.45 X-TUID: B/msLlQSGFm4 Hi Ludo, Thanks for the feedback. As this was pushed to master last week i am unsure how to incorporate it. On 25.05.24 15:29, Ludovic Courtès wrote: > Hi! > > Dariqq skribis: > >> * gnu/services/pm.scm >> (power-profiles-configuration): New configuration. >> (power-profiles-daemon-shepherd-service): New procedure. >> (power-profiles-daemon-activation): New variable. >> (power-profiles-daemon-service-type): New procedure. >> * doc/guix.texi (Power Management Services): Document it. >> >> Change-Id: Ib035d993ed82eec2a43f3ba2b4c92f77e08a0fd7 > > […] > >> +@quotation Important >> +The @code{power-profiles-daemon} conflicts with other power management tools >> +like @code{tlp}. Using both together is not recommended. > > s/like/such as/ > s/Using.*/Pick one or the other./ > > What about UPower? Do I get it right that this actually builds upon > UPower? > This comment is based on the information from https://gitlab.freedesktop.org/upower/power-profiles-daemon#conflicts. The systemd unit file specifies a conflict with tuned.service, tlp.service, auto-cpufreq.service and system76-power.service and I was not sure how to communicate this other with a big warning in the documentation. Another option I thought about since then was to make p-p-d and tlp also provide a generic power-management name (suggestions for a better name are welcome) similiar to what is done with login-mangers providing xorg-server such that shepherd will not allow both at the same time. > Should it say a word about how it defers from TLP? Skimming through the tlp documentation (https://linrunner.de/tlp/faq/ppd.html) and the p-p-d README (https://gitlab.freedesktop.org/upower/power-profiles-daemon#why-not) main points seem to be: - tlp is more customizable offering more (potentially destructive) options and fine-grained control - p-p-d is more generic and with the integrations in DEs like GNOME, KDE, etc easier to use for normal desktop users. > >> +(define (power-profiles-daemon-shepherd-service config) >> + (match-record >> + config >> + (power-profiles-daemon) >> + (list (shepherd-service (provision '(power-profiles-daemon)) >> + (requirement '(dbus-system)) > > Rather: (requirement '(user-processes dbus-system)). > >> + (documentation "Run the power-profiles-daemon.") > > Nitpick: “Run the Power Profiles Daemon”. > > Also please indent this procedure similar to how this is done elsewhere. > >> + (description "Run the power-profiles-daemon")))) > > Same as above. :-) > > Thanks! > > Ludo’.