From: Dariqq <dariqq@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 70460@debbugs.gnu.org, felix@alternativebit.fr,
Florian Pelz <pelzflorian@pelzflorian.de>
Subject: [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type.
Date: Sat, 25 May 2024 15:15:47 +0000 [thread overview]
Message-ID: <b69edffc-4090-44f3-ba08-d312633f9bc0@posteo.net> (raw)
In-Reply-To: <87msoe10l1.fsf@gnu.org>
Hi Ludo,
Thanks for the feedback. As this was pushed to master last week i am
unsure how to incorporate it.
On 25.05.24 15:29, Ludovic Courtès wrote:
> Hi!
>
> Dariqq <dariqq@posteo.net> skribis:
>
>> * gnu/services/pm.scm
>> (power-profiles-configuration): New configuration.
>> (power-profiles-daemon-shepherd-service): New procedure.
>> (power-profiles-daemon-activation): New variable.
>> (power-profiles-daemon-service-type): New procedure.
>> * doc/guix.texi (Power Management Services): Document it.
>>
>> Change-Id: Ib035d993ed82eec2a43f3ba2b4c92f77e08a0fd7
>
> […]
>
>> +@quotation Important
>> +The @code{power-profiles-daemon} conflicts with other power management tools
>> +like @code{tlp}. Using both together is not recommended.
>
> s/like/such as/
> s/Using.*/Pick one or the other./
>
> What about UPower? Do I get it right that this actually builds upon
> UPower?
>
This comment is based on the information from
https://gitlab.freedesktop.org/upower/power-profiles-daemon#conflicts.
The systemd unit file specifies a conflict with tuned.service,
tlp.service, auto-cpufreq.service and system76-power.service and I was
not sure how to communicate this other with a big warning in the
documentation.
Another option I thought about since then was to make p-p-d and tlp
also provide a generic power-management name (suggestions for a better
name are welcome) similiar to what is done with login-mangers providing
xorg-server such that shepherd will not allow both at the same time.
> Should it say a word about how it defers from TLP?
Skimming through the tlp documentation
(https://linrunner.de/tlp/faq/ppd.html) and the p-p-d README
(https://gitlab.freedesktop.org/upower/power-profiles-daemon#why-not)
main points seem to be:
- tlp is more customizable offering more (potentially destructive)
options and fine-grained control
- p-p-d is more generic and with the integrations in DEs like GNOME,
KDE, etc easier to use for normal desktop users.
>
>> +(define (power-profiles-daemon-shepherd-service config)
>> + (match-record
>> + config <power-profiles-daemon-configuration>
>> + (power-profiles-daemon)
>> + (list (shepherd-service (provision '(power-profiles-daemon))
>> + (requirement '(dbus-system))
>
> Rather: (requirement '(user-processes dbus-system)).
>
>> + (documentation "Run the power-profiles-daemon.")
>
> Nitpick: “Run the Power Profiles Daemon”.
>
> Also please indent this procedure similar to how this is done elsewhere.
>
>> + (description "Run the power-profiles-daemon"))))
>
> Same as above. :-)
>
> Thanks!
>
> Ludo’.
next prev parent reply other threads:[~2024-05-25 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 18:31 [bug#70460] [PATCH 0/4] Update power-profiles-daemon and add a service-type for it Dariqq
2024-05-02 15:37 ` [bug#70460] [PATCH v2 0/3] " Dariqq
2024-05-02 15:37 ` [bug#70460] [PATCH v2 1/3] gnu: power-profiles-daemon: Update to 0.21 Dariqq
2024-05-02 15:37 ` [bug#70460] [PATCH v2 2/3] gnu: power-profiles-daemon: Build gtk-docs Dariqq
2024-05-02 15:37 ` [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type Dariqq
2024-05-25 13:29 ` Ludovic Courtès
2024-05-25 15:15 ` Dariqq [this message]
2024-05-09 8:00 ` [bug#70460] [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it Dariqq
2024-05-16 6:55 ` bug#70460: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b69edffc-4090-44f3-ba08-d312633f9bc0@posteo.net \
--to=dariqq@posteo.net \
--cc=70460@debbugs.gnu.org \
--cc=felix@alternativebit.fr \
--cc=ludo@gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.