From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MCaeFXsbvGEchgEAgWs5BA (envelope-from ) for ; Fri, 17 Dec 2021 06:09:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AOptEXsbvGF0VQAA1q6Kng (envelope-from ) for ; Fri, 17 Dec 2021 05:09:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15C7E1E4EC for ; Fri, 17 Dec 2021 06:09:14 +0100 (CET) Received: from localhost ([::1]:56446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1my5UV-00078M-TR for larch@yhetil.org; Fri, 17 Dec 2021 00:09:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1my5UN-00078C-Bg for guix-patches@gnu.org; Fri, 17 Dec 2021 00:09:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1my5UM-0003gR-R5 for guix-patches@gnu.org; Fri, 17 Dec 2021 00:09:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1my5UM-00041U-FP for guix-patches@gnu.org; Fri, 17 Dec 2021 00:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Dec 2021 05:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163971772715437 (code B ref 51838); Fri, 17 Dec 2021 05:09:02 +0000 Received: (at 51838) by debbugs.gnu.org; 17 Dec 2021 05:08:47 +0000 Received: from localhost ([127.0.0.1]:37622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1my5U3-00040s-EC for submit@debbugs.gnu.org; Fri, 17 Dec 2021 00:08:47 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:34539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1my5U0-00040c-UW for 51838@debbugs.gnu.org; Fri, 17 Dec 2021 00:08:42 -0500 Received: by mail-wm1-f65.google.com with SMTP id bg19-20020a05600c3c9300b0034565e837b6so2257040wmb.1 for <51838@debbugs.gnu.org>; Thu, 16 Dec 2021 21:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=QnUvDA5hWsFhtq2zrtK63++2yE+ekDg/YdStq5YOBdI=; b=Pukvv/aCmQUQzjAF+cUDUPo2V65SNU23itbhqosIJubhYpdxzaXCHiDYHMpp3wTg8+ aOCIBDc1BgkHDJgHrVjnuaxtz23LV1ZCbRPhJTLlvsGUGNNP9l67hlmUi2xdUDqulOIh domlrYksIapCjMbaCBL7VgV1CQh5sXDdWMqmfDdWqYm1WjKlsrodhxQT/tnAG/thpeKk 1w9Vz0q5uaPZucSD/vRh6YeA731SWsc4x6vP8dz1oiQPNFVFczNVsnzJFuHLX2SHVhGY bXs4TNj8LeqSPpl7OmJ64bqFjF9Vc/aE0vuMIr+GggFAsmB5O6CRH3GKlZJoYwvxbkxg +psw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=QnUvDA5hWsFhtq2zrtK63++2yE+ekDg/YdStq5YOBdI=; b=QatGSes4DA3l/np/Rf7XyP7jn14xn0yDJUsD8Yeu609U5qZRqzpJ3Dj2P8eNfqEs3I yQ5P9jm4YOVtzUXLj1h2n7aUxL4+DTRSQyLYE9q+ruSKbvNtrNYiirqQ+k8mvbi5HBPb axzupLMycLfJ/XI5y+BwGEJIDrD/n48mu8IJlI9WfTLBfbYExz4i7+inomN2QRmdn+BT EYRn+rVatc0q4QTfKfPB7Jw0JwI5kB0UjmQPKrU+KargPmyF4QGKvkCVhHnthjp8SX54 hz/iPoEYhp/y5eWbwcDGgKQnsYjT0E29cqEeII2FP1hC2BeGKkSWfrfo/SAIZlwWgyGg aqJQ== X-Gm-Message-State: AOAM532jlb+s4XHzcluZiXbPS0oxnOY+gkHXgXXd7BEIIe9SNj96dNs/ 3tD2/NPj2dyBVyscaronTok= X-Google-Smtp-Source: ABdhPJxhW/o15RwOr87EJberFr81fHKl6/ow1DUWbXwNEfi8b1L0stY/Zqz23U5DmJD+JI2lZXFmlw== X-Received: by 2002:a05:600c:21c3:: with SMTP id x3mr993021wmj.13.1639717715132; Thu, 16 Dec 2021 21:08:35 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 12sm4417488wmi.35.2021.12.16.21.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 21:08:34 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Fri, 17 Dec 2021 06:08:33 +0100 In-Reply-To: <20211217020325.520821-21-philip@philipmcgrath.com> References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-21-philip@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639717754; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QnUvDA5hWsFhtq2zrtK63++2yE+ekDg/YdStq5YOBdI=; b=XGz9sOy6E24lT3qaCsM9NVlNtEKedyizBc6hsESNRFzz56q2jFgXuRDWl9RwdbMPB6NN17 oJXWIFp2Oo0OFO/rlsOd8WVUWVRgM/awaOydXQv7SIloysHNkubtsy3sIGiOjNFt2uUlyq Lfdq5Il6cGeGxztTCO08kUIZJqoCvhzCZ69JZ46ox2CP02iOd94OKPYkwORi5md0J/YbK2 sSLpMoiHnll8EyLaTU+vYo8XsWR3uoURYckK0uBrfjM1Q/H5xpVeFl8AGxb/4Oiod8IeLD MEyuXq2cDeNw2HmD1++pvcGFDyBPH+pt/9PY7cqq3xhvSTYW9BsVDKPttzTteQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639717754; a=rsa-sha256; cv=none; b=QIc5FSt14Si82BBcyBRWM7k1PyKewrdemo7QKnOq9QJurxR52Fr0Hx2jJhwpOm4ieRc9vp w2wwWMv/XAdCmkVVcsPmghnD2aykJcO+ULxezpn52DAKR/bp99vyxRhvymcW7xBF6DrQ12 k4nyxbSYAzWIud2G6dK83DpcOjjfqd991R3kBsDDTZh9Wr4HSQEWM0KDeFvm31/pvR+Fww DmL25SMvdflJTzDIS9UwuvM4EegvdE2JIea8MzOL9StWbfGoHyln9Up5cRSm9mf5uzl6oz mZMPLahZtWyKlcQO7XktRgfApVo76C8jyFW7QY21GnnrW7bf1rqGfgWuA1Ox9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Pukvv/aC"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Pukvv/aC"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 15C7E1E4EC X-Spam-Score: -2.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: PPMCbdD1xHr1 Am Donnerstag, dem 16.12.2021 um 21:03 -0500 schrieb Philip McGrath: > * guix/build-system/node.scm (lower): Add the version of libuv > used as an input to the #:node package as an additional implicit > input, so that packages needing libuv always get the correct version. > --- >  guix/build-system/node.scm | 9 ++++++++- >  1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/guix/build-system/node.scm b/guix/build-system/node.scm > index 330d10dca5..47af4bb9e2 100644 > --- a/guix/build-system/node.scm > +++ b/guix/build-system/node.scm > @@ -2,6 +2,8 @@ >  ;;; Copyright © 2016 Jelle Licht >  ;;; Copyright © 2019 Timothy Sample >  ;;; Copyright © 2021 Ludovic Courtès > +;;; Copyright © 2021 Pierre Langlois > +;;; Copyright © 2021 Philip McGrath >  ;;; >  ;;; This file is part of GNU Guix. >  ;;; > @@ -62,10 +64,15 @@ (define private-keywords >                                `(("source" ,source)) >                                '()) >                          ,@inputs > - >                          ;; Keep the standard inputs of 'gnu-build- > system'. >                          ,@(standard-packages))) >           (build-inputs `(("node" ,node) > +                         ;; Many packages with native addons need > +                         ;; libuv headers. The libuv version must > +                         ;; be exactly the same as for the node > +                         ;; package we are adding implicitly, > +                         ;; so we take care of adding libuv, too. > +                         ("libuv" ,@(assoc-ref (package-inputs node) > "libuv")) >                           ,@native-inputs)) >           (outputs outputs) >           (build node-build) Do this and #21 have to be separated so far from the rest? If not, I'd do build system first, then new packages. Otherwise fair enough.