From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH] gnu: Add tipp10 touch typing tutor. Date: Sat, 31 Dec 2016 15:36:05 +0100 Message-ID: References: <1482074241-30845-1-git-send-email-h.goebel@crazy-compilers.com> <87poknzjhv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNKlZ-00052D-GS for guix-devel@gnu.org; Sat, 31 Dec 2016 09:36:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNKlW-0004EZ-D9 for guix-devel@gnu.org; Sat, 31 Dec 2016 09:36:13 -0500 In-Reply-To: <87poknzjhv.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: guix-devel@gnu.org Am 19.12.2016 um 22:39 schrieb Ludovic Court=C3=A8s: > >> + (uri (string-append "mirror://debian/pool/main/" >> + "t/tipp10/tipp10_2.1.0.orig.tar.gz"= )) > Is there really no upstream for this program? tipp10.com seems to be > live, no? There is, but guix is not able to handle the download URL, which is or .This page uses "". I asked the author for a different URL, but he did not answer. > >> + (patches (search-patches "tipp10-FixCompiling.patch" >> + "tipp10-RemoveLicenseCode.patc= h")))) > Please use lowercase and hyphens for file names. :-) Anything else unimportant I can waste my time on? These are the file-names of the patches at debian. I see absolutely no benefit in changing them. > >> + (description " TIPP10 is a free touch typing tutor for Windows, M= ac OS and > ^ > Extra space. > > Please don=E2=80=99t mention supported operating systems; what matters = is that > it works on GNU. IMO this is interesting for users and for spreading free software. If one reads this i might think: "O, coll, I can recommend this to some friend still using Windooze and ma convince her about free software." > >> +Linux. The ingenious thing about the software is its intelligence fe= ature. > =E2=80=9CIntelligence feature=E2=80=9D sounds vague; could it be rephra= sed in more > precise terms? > >> +Note: To change the language settings choose Datei (File) =E2=86=92 >> +Grundeinstellungen (Generell Settings) =E2=86=92 Sprache (Language) a= nd change from >> +Deutsch to English. The you have restart the program to have the chan= ge take >> +effect.") > This information doesn=E2=80=99t belong here. > > Does Debian have patches to make this program honor the current locale? > That would be the best option. No, there are not patches, this is why I put this information there. If ou dislike, please recommend a better place. > >> + (license license:gpl2))) > Version 2 only? This is what https://www.tipp10.com/en/download/ says. > >> +-Exec=3Dtipp10 >> ++Exec=3D/usr/bin/tipp10 > This doesn=E2=80=99t look useful. Yes, but this is part of the original Debian patch. I'd prefer to keep this patch unchanged to make it easier to follow any changes or fixes Debian incorporates. Since guix is fixing this path anyway, there is no use in maintaining a own set of patches. To be frank, some of your comment on this patch are nitpicking at its best. I have the impression that you did not trust me to have spend only a little thought on what I'm doing. And you are demanding things (patch filenames, change to upstream patches) which have no or negligible benefit =E2=80=93 even if seen in the long run. This *very* discouraging! --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |