From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GN+DEUqOQGIzZAAAgWs5BA (envelope-from ) for ; Sun, 27 Mar 2022 18:18:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UFInDkqOQGLE2wAAauVa8A (envelope-from ) for ; Sun, 27 Mar 2022 18:18:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CCD9FD5DF for ; Sun, 27 Mar 2022 18:18:17 +0200 (CEST) Received: from localhost ([::1]:60426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYVaq-0003E5-FM for larch@yhetil.org; Sun, 27 Mar 2022 12:18:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYVac-0003Dv-3m for guix-patches@gnu.org; Sun, 27 Mar 2022 12:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nYVab-0003AY-RC for guix-patches@gnu.org; Sun, 27 Mar 2022 12:18:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nYVab-0004qE-L4 for guix-patches@gnu.org; Sun, 27 Mar 2022 12:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48909] [PATCH] gnu: Add goldendict References: <20210607200532.27565-1-sarg@sarg.org.ru> In-Reply-To: <20210607200532.27565-1-sarg@sarg.org.ru> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 27 Mar 2022 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48909@debbugs.gnu.org Received: via spool by 48909-submit@debbugs.gnu.org id=B48909.164839782818544 (code B ref 48909); Sun, 27 Mar 2022 16:18:01 +0000 Received: (at 48909) by debbugs.gnu.org; 27 Mar 2022 16:17:08 +0000 Received: from localhost ([127.0.0.1]:56465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYVZj-0004p2-Mx for submit@debbugs.gnu.org; Sun, 27 Mar 2022 12:17:07 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:43450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYVZe-0004of-Mm for 48909@debbugs.gnu.org; Sun, 27 Mar 2022 12:17:06 -0400 Received: from [172.20.10.5] ([188.188.29.207]) by baptiste.telenet-ops.be with bizsmtp id BUH0270054U7BGC01UH0lJ; Sun, 27 Mar 2022 18:17:01 +0200 Message-ID: From: Maxime Devos Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Fl8j5lHdOdHji/KHFjxf" MIME-Version: 1.0 Date: Sun, 27 Mar 2022 18:09:46 +0200 User-Agent: Evolution 3.38.3-1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1648397821; bh=X2s3vvOJauvfJrqLU6JN5C/6ailZ4n2SKX0f2xd/7+Q=; h=Subject:From:To:Date; b=T4h8/bxTkPaampTdZ1RYnXuP8Xv+m0UO+oEibd2yc3yIlbUS+m0dR2hc7VzMvZ8YP TrIJ6ts8UIjGwCaQIBbh/Wzo5A5gyzEZ7AHEi7k9XpRkll4qTZIXo6+ArwVpHe59NK iyfcwC/X9U4NoXtb9L6b1TvirYhCkk1HQdRUCLngXoNRWDoo0yG4DNVJxQW74SA57D 4isXYHsOrA/toh9IEIyJWggZDz/7nL97pQUF6ACcrpY+MYou/fah2jtgFvfuTRV7Tl /RVnHZEhK/Y4rSIZhr6Q/WE6+GcGgxhFPIXIzOKFW+pheY3XHF+DSTv9SuMXygxj02 voCpBuvrD2ucQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648397897; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=X2s3vvOJauvfJrqLU6JN5C/6ailZ4n2SKX0f2xd/7+Q=; b=IjjfX6JKep7ZQGpUUARMZhfXW4zmfoe6150j6pWYz+88Wui5MnPYF69QF5SVDFTEelhvS2 Gsr6Ffc5jard98B5CjKjy9TpkbiLqh+7klwAqql0OsW7mw5/kfUSME7GMi1hJriWCTDEMv 0H5kwEWNGdjI1jxzSgAi4Gr8Y7yEu1zdeQhdrOAzf16MSWnaxYSSP0Bk732rQ5pn7dQNSU x53NcuP8HOSDp010+2nwLnpwUFMgH+FAOMLHwgNQWXEVwEWG3aYPeBvx+WFMxYkqJiumZ2 z0XaTgdBPcUVshkIs3kH1EFd8ZLhB9oraDditwvDD26taXIO2SrHWLM6usApOw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648397897; a=rsa-sha256; cv=none; b=Kufes3kW2URBJzCDVb9CRbM6kzk5licMErjNtja+J3oSOQIoxTBLntQ7UyOpt4+i2QL3Wi n3UUv4uxZihJ0Q2upJoM+VPnjK4fqcHOVhCimLld3V7cxhlpZHuh/qVgRLsiyHUPYxZxm0 SfmOBIkvfvtGce7weCCRDeoL2pWCkuNnq7ZHV3s+zJIUqlkqxnfoOQlvqC/tW4TDBoRdOw efsqwN/h18gFiDFsR7h0v25/R86LfKRjM9BreNO/yQbOCth8VbMLtopeVxwpCAJzu/BrEi 0DRxbEbCD6wgsjWdACS3c8jF65RWZjbQK4bD6NJKZHHSAIRNBlys3k+Ag+0S7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="T4h8/bxT"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.73 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="T4h8/bxT"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CCD9FD5DF X-Spam-Score: 3.73 X-Migadu-Scanner: scn0.migadu.com X-TUID: e4aLKXqQxvN0 --=-Fl8j5lHdOdHji/KHFjxf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, > + (let ((commit "baff02a14b3f70f0d0a55bef550dbb74dcbf0ce8") > + (version (git-version "1.5.0-RC2" revision commit)) > + (commit commit))) Is this an actual upstream version? If so, 'git-version' is not necessary here. Also, do we want to package release candidates, or only regular releases? > + #t)))) Not necessary anymore. > + (for-each delete-file-recursively > + '("winlibs" "maclibs")) What is the reason for removal? (bundling, nonfree, broken, ...?) > + "CONFIG+=3Dno_epwing_support" Why not support 'epwing', whatever that is?=20 > + https://github.com/NixOS/nixpkgs/blob/217b221/pkgs/applications/misc/golden= dict/0001-dont-check-for-updates.patch This will do, but ideally upstream would just have some kind of configuration flag that distributions could set. > + "Feature-rich dictionary lookup program") + (description + "GoldenDict is a feature-rich dictionary lookup program, +supporting multiple dictionary formats (StarDict, Babylon, Lingvo, Dictd, AARD, +MDict, SDict) and online dictionaries, featuring perfect article renderin This is leaning a bit against the =E2=80=98no marketing phrases rule=E2=80= =99 from (guix)Synopses and Descriptions. Greetings, Maxime. --=-Fl8j5lHdOdHji/KHFjxf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYkCMNxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lecAQDImpNDHt9m0YNUv7o7jk/2t1dy TSX/RyW2HkHMQrwTHwD/aLl0ESz1Wec+/5lDQ7vkC11J6Hq0aiuSBzJUrPfROQ0= =7l7j -----END PGP SIGNATURE----- --=-Fl8j5lHdOdHji/KHFjxf--