From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJfYHgedRmJ0ywAAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 08:34:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CDNyGwedRmIaEQEAauVa8A (envelope-from ) for ; Fri, 01 Apr 2022 08:34:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E60BB2FF for ; Fri, 1 Apr 2022 08:34:47 +0200 (CEST) Received: from localhost ([::1]:57222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naAru-0003kU-6C for larch@yhetil.org; Fri, 01 Apr 2022 02:34:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naAng-0002J4-Q2 for guix-devel@gnu.org; Fri, 01 Apr 2022 02:30:27 -0400 Received: from [2a02:1800:120:4::f00:14] (port=42000 helo=xavier.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naAnb-0007oj-33 for guix-devel@gnu.org; Fri, 01 Apr 2022 02:30:21 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by xavier.telenet-ops.be with bizsmtp id DJWD2700L4UW6Th01JWD4y; Fri, 01 Apr 2022 08:30:13 +0200 Message-ID: Subject: Re: New review checklist From: Maxime Devos To: Liliana Marie Prikler , guix-devel@gnu.org Date: Fri, 01 Apr 2022 08:30:07 +0200 In-Reply-To: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> References: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-WnhUfiMde1P3xKdjuYk6" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1648794614; bh=utV5wj+AB+z8V/sdY4rSQwBFl2QM8IdO3RpacD9c3qM=; h=Subject:From:To:Date:In-Reply-To:References; b=GlpOVVaPQmztrQQteZcZDCej5UMNhU+4x/Edxe9+24z+BAF6NSWnZFzSVQ0mhnqiZ GH44BMUUtmE4J2mOko6eieRR22IlkAA+lIHNheUf1oGW35XUJ310hbYayrexyZsAE2 iEw9IDk0JG9b2OlNHCsu79EC6Juxq6Neq2ECpy0BhFhB7wDR/PfkShJDgJGglNN68u gPW9aJbhYsFSAEFH34pluZwecA6WdO/Az7RgW7AmHzsL3rycD9YEMsoXPsVXYT8yfM 2C/d8QRvwn9h12odoW+rQ3mShBsk8eCAREAVBqCV31261jtjJXEAaKFEoWVslfHwCc 44tRVOmaDTx0g== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:120:4::f00:14 (failed) Received-SPF: pass client-ip=2a02:1800:120:4::f00:14; envelope-from=maximedevos@telenet.be; helo=xavier.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648794887; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=utV5wj+AB+z8V/sdY4rSQwBFl2QM8IdO3RpacD9c3qM=; b=JQtBObMHxxqeXd92TTEdJvxVoT2odSAwmHOf/Xk0c7pnc8iHuBtIcUWpNz/diG761KJPLR C5gwPY0DHQU3Dz/vrc6GLZV6L6o6XvCiwtpqBbzXFl2GAR83Ckzq2/VQF775Q5csLN1x+D uAiOA0+Rw7Weg4Bkcxkg0Ch3Ka0+wSbsv53BeOF15QK1FtVLqGH+bD3Ymf1NzkCsliMiSY 1b3EL0wn4+FqFfJv4QKLGrgtAtToeFgoVgWJYheFVhHCeUDO13lJ0a30Ol4jGe2IKh4RRg D0erVj0SGkde6UK96zfJNKrFRs+4GjbirUAR4nVQ37rAkNN8pIka/TN4j6qL9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648794887; a=rsa-sha256; cv=none; b=HWmFgPMVGXzrGs6CDbtAlTG1uubW8q5IksPUpaebDUolw7vkcbthuSEClBAZS953May6Cb 2Esi6CC+nqHz3btEb23gk8yw9H670P1EHXLi2lvg4znXlcMtSRoh8nLWfDm3aCMC3IM3IH dkd1sKfXjRa0m5phdZJAti9/11fE3x7SxaJQmLPPPV7xfTqIW/haDRZKMZk6LRKwB6l209 4koGqTCbVWBA0eZOo47gNcEt+sVcO222TBXF8dCjxbInHvUjDqlr51Xt4nXA3MggVXYyu8 qB3KvbiTPgtUJSAf6aJT0H3XjehPaisppk9pY701MYkYLqJLAcdkd8RSvWrCDg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r22 header.b=GlpOVVaP; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.27 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r22 header.b=GlpOVVaP; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1E60BB2FF X-Spam-Score: -6.27 X-Migadu-Scanner: scn1.migadu.com X-TUID: ftnyUbmIJP8T --=-WnhUfiMde1P3xKdjuYk6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler schreef op vr 01-04-2022 om 06:14 [+0200]: > It won't be added to Guix. Here's why it won't. > You appear to believe that > [...] > [ ] hard-coding the commit field is a good idea Does the following count: (define-public foo (package (name "foo") (version "1.0.0") (source (origin [...] (file-name (git-file-name name version)) ;; Upstream does not tag versions, see ;; for which commit ;; corresponds to which version. ;; ;; (alternatively) ;; ;; Upstream deletes old tags every N months, ;; so explicitly write the commit here.; ;; ;; (alternatively) ;; ;; There is consensus that the benefits of explicit commits ;; outweigh the downsides, see ;; (commit "cabba9e...")) [...])) -- would the commit need to be let-bound here? Greetings, Maxime --=-WnhUfiMde1P3xKdjuYk6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYkab7xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7k68AP9MgGd6U22X//5YvhGtObGvD9vd YQHn6omZisKJR574TQD/TBYIErENhr6EvriZY8SA77skFFUszByR3d/gEmEf2wo= =YrKX -----END PGP SIGNATURE----- --=-WnhUfiMde1P3xKdjuYk6--