From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GOJUOJ8xkGJ0HQEAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 04:04:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yDxPOJ8xkGLPHAAA9RJhRA (envelope-from ) for ; Fri, 27 May 2022 04:04:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9068050CE for ; Fri, 27 May 2022 04:04:15 +0200 (CEST) Received: from localhost ([::1]:45338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuPKn-0005yl-NR for larch@yhetil.org; Thu, 26 May 2022 22:04:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuPKc-0005yO-Fj for guix-patches@gnu.org; Thu, 26 May 2022 22:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuPKc-0008DX-7B for guix-patches@gnu.org; Thu, 26 May 2022 22:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuPKc-00052C-2Q for guix-patches@gnu.org; Thu, 26 May 2022 22:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55253] nginx-rtmp-module not compatible with nginx Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 02:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55253@debbugs.gnu.org Received: via spool by 55253-submit@debbugs.gnu.org id=B55253.165361698419285 (code B ref 55253); Fri, 27 May 2022 02:04:02 +0000 Received: (at 55253) by debbugs.gnu.org; 27 May 2022 02:03:04 +0000 Received: from localhost ([127.0.0.1]:60403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuPJf-00050z-UN for submit@debbugs.gnu.org; Thu, 26 May 2022 22:03:04 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:38382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuPJW-00050O-Je for 55253@debbugs.gnu.org; Thu, 26 May 2022 22:03:02 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuPJR-00047m-8U; Thu, 26 May 2022 22:02:49 -0400 Date: Thu, 26 May 2022 22:02:49 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: <20220522055157.31807-1-jackhill@jackhill.us> <871qwk8kyx.fsf_-_@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-1803228329-1653616969=:11587" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653617055; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=g8fP95H2qo0VXfOZd3tiJXdMiYJO2daStnJuY3Og9V0=; b=P1mabK/CVltTiPbviVqAbWVwotOLPV/et70eQqZ43PA8MAG3a66i2DJJg4RGGi8dSi/aYT P2lfocFplj+8648vEF0rDglmbhI6m1F0bCMdlmWiPRD9ASZ934hKXzrHb6yImL0VLsYAta TBIUY8tvfCE5fkDVdSX0OuHHt24GnVlaJcChz1GQFtUXUfbPh+M/Rvzb9uGQFzly93nXpF SglKv/wSMGX1RrV25B4fLHr9knDuAI4wSbyxYT3ITR12mozOy+TZolHdSvuJr0uI+JuPV0 JLS9pcfcoe+U75STVGwheJVfeWoaz6z0jse+DimhyFFiIdjyWWZC+XwSDu2Hjg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653617055; a=rsa-sha256; cv=none; b=Mv8Nju+pc3LFSxNnCfVZ8F03eRdU1zvcv0DE8BiXYBgx3tifYUYk3k4NPAWZoVjZQ19Dnl gZ2cTHbexf+KZWUvhtUPZAk5S+a9fKZllkMlIShsYvmSaQfjFxKm2dTKKsc9N+nMeLuYgW RIiCWeOUjRtfA/n0uTeyyeMfkxTUUe0ui6exWWuru9G1by8pUQCWsuo/dMHgdH0I7gD1ws uG9kDkQNILiKGWKP62SxsgCP1SJ6iuRsQ0cJrEj9UFxaE6gRvYAHVnuBuE1XKDMSajmgqL lN8SSTH3Ae9BOioDzXyo1wSr5PlLr3C0T4J2TzHp9uHv2+LbPxeFFIwzAapSwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9068050CE X-Spam-Score: -2.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: LuDgcVnrdBcJ This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1803228329-1653616969=:11587 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 23 May 2022, Jack Hill wrote: > On Mon, 23 May 2022, Ludovic Courtès wrote: > >> Jack Hill skribis: >>> >>> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm >>> index 600ef0c895..50401c07e1 100644 >>> --- a/gnu/packages/web.scm >>> +++ b/gnu/packages/web.scm >>> @@ -785,12 +785,9 @@ (define-public nginx-rtmp-module >>> `(("nginx-sources" ,(package-source nginx)) >>> ,@(package-inputs nginx))) >>> (arguments >>> - (substitute-keyword-arguments >>> - `(#:make-flags '("modules") >>> - #:modules ((guix build utils) >>> - (guix build gnu-build-system)) >>> - ,@(package-arguments nginx) >>> - #:configure-flags '("--add-dynamic-module=.")) >>> + (substitute-keyword-arguments (package-arguments nginx) >>> + ((#:configure-flags flags) >>> + #~(cons "--add-dynamic-module=." #$flags)) >> >> If I’m not mistaken, #:make-flags and #:modules are lost here, no? >> Or were they unnecessary in the first place? > > You are not mistaken, they are lost. They do seem to be unnecessary though. > nginx is able to load and make use of the module without them. I realized the value of the make-flags. It saves effort when building, as only the module is build not all of nginx again. The output is identical. I'll send a v2 with those added back. I still don't see the value of the modules. Best, Jack --925712948-1803228329-1653616969=:11587--