From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WIOxLFuWi2Kz+gAAbAwnHQ (envelope-from ) for ; Mon, 23 May 2022 16:12:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QCZZLFuWi2K4EgAAauVa8A (envelope-from ) for ; Mon, 23 May 2022 16:12:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 93F6210271 for ; Mon, 23 May 2022 16:12:42 +0200 (CEST) Received: from localhost ([::1]:46272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt8nZ-0002KE-Bb for larch@yhetil.org; Mon, 23 May 2022 10:12:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt8nF-0002If-Gs for guix-patches@gnu.org; Mon, 23 May 2022 10:12:21 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nt8mw-0007ad-1b for guix-patches@gnu.org; Mon, 23 May 2022 10:12:20 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nt8mv-0000gy-TN for guix-patches@gnu.org; Mon, 23 May 2022 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55253] nginx-rtmp-module not compatible with nginx Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 May 2022 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55253@debbugs.gnu.org Received: via spool by 55253-submit@debbugs.gnu.org id=B55253.16533150982628 (code B ref 55253); Mon, 23 May 2022 14:12:01 +0000 Received: (at 55253) by debbugs.gnu.org; 23 May 2022 14:11:38 +0000 Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt8mY-0000gK-6j for submit@debbugs.gnu.org; Mon, 23 May 2022 10:11:38 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:58318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt8mU-0000g2-1X for 55253@debbugs.gnu.org; Mon, 23 May 2022 10:11:36 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt8mO-0004sh-Sq; Mon, 23 May 2022 10:11:28 -0400 Date: Mon, 23 May 2022 10:11:28 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <871qwk8kyx.fsf_-_@gnu.org> Message-ID: References: <20220522055157.31807-1-jackhill@jackhill.us> <871qwk8kyx.fsf_-_@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-1670597693-1653315088=:11587" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653315163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=xSYv9pO32pyQgM2sxDBHAttVuJgQhy40AxJvg0jph8w=; b=JorqxcYn6TtCWZKK2Ril0VizLvUiXY9C9P0bxeR99XWvirKfy8T/YN22SVqM7z3MRnbERn rspqTvK38UzkjLoE+ZvF0p5oDi9RZcVlXnFwNIHvXCwmdGO/F6dSMT1XB5kSiupQheIQ2u viTXT9kl/67jiYmUmea89RJkL5qprwvOahi+Xu2yILXQ1bTslqtUGmbtUgezsJYsGE+GvH YjNgEQsjjlBjNL4R6x00+omCSqo6tfF9uxFp9qvc9o1H08o3bYnxhmyVoLLjk40PgeHEh3 7bm3Zlf+vpIAeZW7k+6jxb586n/wfLK2OLbiaINio3sN4Fm0jrioC9Bg3vihbg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653315163; a=rsa-sha256; cv=none; b=AjxzonrnA/E8MdsOv0OBgp4QmTxydYT/CGOZwjGhFAKy/fCJj8+QZPhvSdhZPIEOKUEL3I p0UVdbY2WNfQP/OOMB1f+H+vgSlRS8ISSYYbg0oMiipy/xiJpZFbiSUwp08Kku3kcYQhcB KhxwaUmShQgrvCb3bsSruNFMi6ABPhOv0sAHYTFaGOzeVGYL9h5eb4Tardtn6dC14Q71se BOMcPhv3l+b9HpQeDVj4jclsQBZJNiLCHAMsHBvgBsFXRKP42qHVCxJrZ1YffEF78sOLp4 kUqR/pB3I/esE2WLJGtGjvwsHVyekWY1nAW84Zc/CZaVE9D/KLRpj2wyEqDutg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.05 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 93F6210271 X-Spam-Score: -2.05 X-Migadu-Scanner: scn1.migadu.com X-TUID: Mz8mt1ROYwSi This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1670597693-1653315088=:11587 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 23 May 2022, Ludovic Courtès wrote: > Jack Hill skribis: >> >> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm >> index 600ef0c895..50401c07e1 100644 >> --- a/gnu/packages/web.scm >> +++ b/gnu/packages/web.scm >> @@ -785,12 +785,9 @@ (define-public nginx-rtmp-module >> `(("nginx-sources" ,(package-source nginx)) >> ,@(package-inputs nginx))) >> (arguments >> - (substitute-keyword-arguments >> - `(#:make-flags '("modules") >> - #:modules ((guix build utils) >> - (guix build gnu-build-system)) >> - ,@(package-arguments nginx) >> - #:configure-flags '("--add-dynamic-module=.")) >> + (substitute-keyword-arguments (package-arguments nginx) >> + ((#:configure-flags flags) >> + #~(cons "--add-dynamic-module=." #$flags)) > > If I’m not mistaken, #:make-flags and #:modules are lost here, no? > Or were they unnecessary in the first place? You are not mistaken, they are lost. They do seem to be unnecessary though. nginx is able to load and make use of the module without them. Best, Jack --925712948-1670597693-1653315088=:11587--