From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IJaNJSvawmB+VwEAgWs5BA (envelope-from ) for ; Fri, 11 Jun 2021 05:36:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8HzvICvawmDdUgAAbx9fmQ (envelope-from ) for ; Fri, 11 Jun 2021 03:36:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E2A52F522 for ; Fri, 11 Jun 2021 05:36:11 +0200 (CEST) Received: from localhost ([::1]:55718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrXxq-0005PC-Dv for larch@yhetil.org; Thu, 10 Jun 2021 23:36:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrXxi-0005On-Hn for guix-patches@gnu.org; Thu, 10 Jun 2021 23:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrXxi-0000Bk-28 for guix-patches@gnu.org; Thu, 10 Jun 2021 23:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lrXxh-00040J-Ue for guix-patches@gnu.org; Thu, 10 Jun 2021 23:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Jun 2021 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48953 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Raghav Gururajan Cc: 48953@debbugs.gnu.org Received: via spool by 48953-submit@debbugs.gnu.org id=B48953.162338253315352 (code B ref 48953); Fri, 11 Jun 2021 03:36:01 +0000 Received: (at 48953) by debbugs.gnu.org; 11 Jun 2021 03:35:33 +0000 Received: from localhost ([127.0.0.1]:37938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrXxE-0003zX-OY for submit@debbugs.gnu.org; Thu, 10 Jun 2021 23:35:32 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:36930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrXxC-0003zK-GP for 48953@debbugs.gnu.org; Thu, 10 Jun 2021 23:35:30 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrXx7-0005Cf-Cx; Thu, 10 Jun 2021 23:35:25 -0400 Date: Thu, 10 Jun 2021 23:35:25 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <20210611011550.27628-3-rg@raghavgururajan.name> Message-ID: References: <20210611011550.27628-1-rg@raghavgururajan.name> <20210611011550.27628-3-rg@raghavgururajan.name> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-126607694-1623382525=:2109" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 5E2A52F522 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: q/gc49qOdums This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-126607694-1623382525=:2109 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote: > * gnu/packages/messaging.scm (dino)[phases](wrap-env): New phase. > [inputs]: Add gspell, gstreamer, gst-plugins-base, gst-plugins-good, > icu4c, libsrtp and webrtc-audio-processing. > --- > gnu/packages/messaging.scm | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm > index 5be733f3a2..41f26ba8e0 100644 > --- a/gnu/packages/messaging.scm > +++ b/gnu/packages/messaging.scm > @@ -114,6 +114,7 @@ > #:use-module (gnu packages sphinx) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages tcl) > + #:use-module (gnu packages telephony) > #:use-module (gnu packages texinfo) > #:use-module (gnu packages textutils) > #:use-module (gnu packages tls) > @@ -1241,6 +1242,17 @@ Encryption to Gajim.") > (guix build glib-or-gtk-build-system)) > #:phases > (modify-phases %standard-phases > + (add-after 'install 'wrap-env > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (for-each > + (lambda (name) > + (let ((file (string-append out "/bin/" name)) > + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) > + (wrap-program file > + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))) > + '("dino"))) > + #t)) Nitpick of a sort: Can we forgo the #t with the (hopefully soon) upcoming core-updates merge? […] > + ("gspell" ,gspell) ; for spell-check support > + ("gstreamer" ,gstreamer) ; for A/V support > + ("gst-plugins-base" ,gst-plugins-base) > + ("gst-plugins-good" ,gst-plugins-good) […] > + ("webrtc-audio-processing" ,webrtc-audio-processing))) ; for A/V support Is there actual A/V support in this version of Dino, or is that only coming in 0.3.0? Best, Jack --925712948-126607694-1623382525=:2109--