From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WFSENkzZwmDQVgEAgWs5BA (envelope-from ) for ; Fri, 11 Jun 2021 05:32:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MAs5MUzZwmBlXAAA1q6Kng (envelope-from ) for ; Fri, 11 Jun 2021 03:32:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A16842F46A for ; Fri, 11 Jun 2021 05:32:28 +0200 (CEST) Received: from localhost ([::1]:55446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrXuF-00052T-6n for larch@yhetil.org; Thu, 10 Jun 2021 23:32:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrXtr-00052K-7G for guix-patches@gnu.org; Thu, 10 Jun 2021 23:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrXtq-0005Oa-Jg for guix-patches@gnu.org; Thu, 10 Jun 2021 23:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lrXtq-0003uK-Dn for guix-patches@gnu.org; Thu, 10 Jun 2021 23:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Jun 2021 03:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48953 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Raghav Gururajan Cc: 48953@debbugs.gnu.org Received: via spool by 48953-submit@debbugs.gnu.org id=B48953.162338227214957 (code B ref 48953); Fri, 11 Jun 2021 03:32:02 +0000 Received: (at 48953) by debbugs.gnu.org; 11 Jun 2021 03:31:12 +0000 Received: from localhost ([127.0.0.1]:37932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrXt2-0003tA-5w for submit@debbugs.gnu.org; Thu, 10 Jun 2021 23:31:12 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:36894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrXsw-0003sZ-KS for 48953@debbugs.gnu.org; Thu, 10 Jun 2021 23:31:10 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrXsq-000510-M9; Thu, 10 Jun 2021 23:31:00 -0400 Date: Thu, 10 Jun 2021 23:31:00 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <20210611011550.27628-2-rg@raghavgururajan.name> Message-ID: References: <20210611011550.27628-1-rg@raghavgururajan.name> <20210611011550.27628-2-rg@raghavgururajan.name> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-1863171853-1623382260=:2109" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: A16842F46A X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: YAWEDr/T8V7C This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1863171853-1623382260=:2109 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote: > These new inputs are referenced by the package but was missing in > the package definition. Some of these inputs might have been used > by the package indirectly via propagation from other inputs. Cool, thanks for working on improving Dino. > * gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection. > [inputs]: Add atk, cairo, gdk-pixbug+svg, libcanberra, libnice and pango. > --- > gnu/packages/messaging.scm | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm > index d85577e76c..5be733f3a2 100644 > --- a/gnu/packages/messaging.scm > +++ b/gnu/packages/messaging.scm […] > + ("libcanberra" ,libcanberra) I think canberra support is disabled by default even if the dependency is present. I found the following configure-flags enable it: #:configure-flags (list "-DDINO_PLUGIN_ENABLED_notification-sound=yes") Now I'm curious to find out from upstream why it's not enabled by default and if that should affect whether we enable it in Guix. Best, Jack --925712948-1863171853-1623382260=:2109--