From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uL3gMBWB21+DXwAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 16:02:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2NLDLBWB21/7YQAAbx9fmQ (envelope-from ) for ; Thu, 17 Dec 2020 16:02:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 731159404FE for ; Thu, 17 Dec 2020 16:02:26 +0000 (UTC) Received: from localhost ([::1]:60330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpvjV-0002iN-5w for larch@yhetil.org; Thu, 17 Dec 2020 11:02:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpvjK-0002hi-ES for guix-devel@gnu.org; Thu, 17 Dec 2020 11:02:14 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:41844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpvjI-0002Ex-J9 for guix-devel@gnu.org; Thu, 17 Dec 2020 11:02:14 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpvjF-0003ks-Vg; Thu, 17 Dec 2020 11:02:10 -0500 Date: Thu, 17 Dec 2020 11:02:09 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Christopher Baines Subject: Re: Help, and get help reviewing patches this Friday (18th) In-Reply-To: <87ft44323d.fsf@cbaines.net> Message-ID: References: <87ft44323d.fsf@cbaines.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.31 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 731159404FE X-Spam-Score: -2.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: yK5ijmEGr+BN On Thu, 17 Dec 2020, Christopher Baines wrote: > Hey, > > I mentioned in [1] that some "Scheduled and regular collaboration on IRC > to review patches" might help both get some patches reviewed, but help > get more people involved in reviewing patches, even if they haven't done > so before. > > 1: https://lists.gnu.org/archive/html/guix-devel/2020-11/msg00583.html > > The suggestion came to do this on a Friday, and I have some time > tomorrow (Friday the 18th) that I can set aside to be on IRC and try and > help. Thanks, this sounds like a great initiative, and I'll try to drop by. I'm in North America though, so I might be a little tardy (despite how much fun the 4am Guix Day was!). On the topic of patch review, I was recently asked how I reviewed a proposed Go upgrade. I responded on the bug tracker [0]. I'd be interested in hearing critiques on the method I used. It might be nice to collect some recipes for reviewing different kinds of changes in the cookbook :) [0] https://issues.guix.gnu.org/45161#11 Best, Jack