From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sMhRJpbKsV6GfAAA0tVLHw (envelope-from ) for ; Tue, 05 May 2020 20:20:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uKewCKLKsV52WQAAbx9fmQ (envelope-from ) for ; Tue, 05 May 2020 20:20:50 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32105940A3C for ; Tue, 5 May 2020 20:20:48 +0000 (UTC) Received: from localhost ([::1]:55690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW43c-0006Hu-M6 for larch@yhetil.org; Tue, 05 May 2020 16:20:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW3v8-0001f2-DH for guix-patches@gnu.org; Tue, 05 May 2020 16:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW3v8-0002yY-3w for guix-patches@gnu.org; Tue, 05 May 2020 16:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jW3v7-0007zh-VR for guix-patches@gnu.org; Tue, 05 May 2020 16:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41088] [PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 May 2020 20:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41088 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 41088@debbugs.gnu.org Received: via spool by 41088-submit@debbugs.gnu.org id=B41088.158870947130660 (code B ref 41088); Tue, 05 May 2020 20:12:01 +0000 Received: (at 41088) by debbugs.gnu.org; 5 May 2020 20:11:11 +0000 Received: from localhost ([127.0.0.1]:37635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW3uI-0007yS-MG for submit@debbugs.gnu.org; Tue, 05 May 2020 16:11:10 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:47092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW3uH-0007yE-0p for 41088@debbugs.gnu.org; Tue, 05 May 2020 16:11:09 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jW3uB-0003T9-LA; Tue, 05 May 2020 16:11:03 -0400 Date: Tue, 5 May 2020 16:11:03 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87imhaxnnb.fsf@devup.no> Message-ID: References: <20200504223005.11419-1-jackhill@jackhill.us> <20200504224036.11979-1-jackhill@jackhill.us> <87imhaxnnb.fsf@devup.no> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49579754968335]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.12), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DWL_DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[fastmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jackhill@jackhill.us,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[jackhill.us:email]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[jackhill.us]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: ger5bya0FXYp On Tue, 5 May 2020, Marius Bakke wrote: > Jack Hill writes: > >> + (snippet >> + '(begin (delete-file "schemas/gschemas.compiled") >> + (for-each delete-file (find-files "locale" "\\.mo$")) >> + #t)))) > > Can you add a comment about why this is necessary? I've added a commend and will send the updated patch shortly. However, I may have been wrong to remove these files as part of the snippet. I did it because the removed files are not source form, but instead can be generated from source during the package build. I believe that upstream includes them in the code repository because it is common for people to install GNOME Shell extensions by directly cloning the repo in their home directories. > Otherwise LGTM. Thanks for the review. Best, Jack