From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46373) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5B4x-00047Y-IA for guix-patches@gnu.org; Fri, 21 Feb 2020 11:23:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5B4w-0003Wn-OF for guix-patches@gnu.org; Fri, 21 Feb 2020 11:23:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41902) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5B4w-0003Wj-KX for guix-patches@gnu.org; Fri, 21 Feb 2020 11:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5B4w-0006vz-GF for guix-patches@gnu.org; Fri, 21 Feb 2020 11:23:02 -0500 Subject: [bug#39599] [PATCH v2] gnu: Add gnome-shell-extension-paperwm. Resent-Message-ID: Date: Fri, 21 Feb 2020 11:22:35 -0500 (EST) From: Jack Hill In-Reply-To: <1628381b-06af-4e2e-acd0-1f23238b361c@www.fastmail.com> Message-ID: References: <9a61841f-e79b-469f-af02-4a739cb0c5f2@www.fastmail.com> <20200221033733.11242-1-jackhill@jackhill.us> <20200221033733.11242-2-jackhill@jackhill.us> <1628381b-06af-4e2e-acd0-1f23238b361c@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Griffin Cc: 39599@debbugs.gnu.org Alex, On Fri, 21 Feb 2020, Alex Griffin wrote: > Thank you, I just committed your improvements with some slight > modifications! Thanks for the improvements. However, I don't think this change was warranted: - #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$" - "\\.xml$" "\\.compiled$"))))) + #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$" "\\.xml$"))) I think we still want to install the gschemas.compiled file that build in the new compile-schemas phase. > I had noticed the issue and intended to fix it myself, but after > stepping away from my computer for a while, I must have forgotten about > it and sent my patch too early. No worries, I'm happy to serve as a second set of eyes. Best, Jack