From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:54218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ibE-0005Yv-4l for guix-patches@gnu.org; Sun, 17 Mar 2019 23:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5ibC-0004eW-EL for guix-patches@gnu.org; Sun, 17 Mar 2019 23:06:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5ibC-0004eS-90 for guix-patches@gnu.org; Sun, 17 Mar 2019 23:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5ibB-0004IQ-VL for guix-patches@gnu.org; Sun, 17 Mar 2019 23:06:01 -0400 Subject: [bug#34900] Add emacs-semantic-refactor Resent-Message-ID: Received: from eggs.gnu.org ([209.51.188.92]:54040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5ia5-0005Gp-SP for guix-patches@gnu.org; Sun, 17 Mar 2019 23:04:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5ia4-0004GP-Ce for guix-patches@gnu.org; Sun, 17 Mar 2019 23:04:53 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:48302) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5ia4-0004FT-2X for guix-patches@gnu.org; Sun, 17 Mar 2019 23:04:52 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h5ia2-0003UV-Tt for guix-patches@gnu.org; Sun, 17 Mar 2019 23:04:50 -0400 Date: Sun, 17 Mar 2019 23:04:50 -0400 (EDT) From: Jack Hill Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="925712948-1325076525-1552878290=:16784" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 34900@debbugs.gnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1325076525-1552878290=:16784 Content-Type: text/plain; format=flowed; charset=US-ASCII Hi Guix, The attached patch adds the emacs-semantic-refactor package. When reviewing this patch some particular things to look out for/questions I have: 0) There are different sections in the (gnu packages emacs-xyz) module that are delineated by comments (e.g. Emacs Hacking, Web Browsing, and Miscellaneous). I've added the definition of emacs-semantic-refactor near the end of the file in the Miscellaneous section. I wonder if this is correct or if it should go in the Emacs Hacking section. Paredit, which would be used in similar scenarios to semantic-refactor is in the Emacs Hacking section. 1) The upstream source contains a number of animated gif files demonstrating usage in the srefactor-demos directory. I do not see a build process for these, and assume they were created by hand. Are we free to distribute these in Guix? 2) semantic-refactor has an optional integration with projectile whose availability is checked for with (featurep 'projectile). I have not added projectile as an input or propagated-input. Is this OK? 3) I'm still new to writing package definitions, so extra scrutiny is warranted, particularly for the synopsis and description. All the best, Jack --925712948-1325076525-1552878290=:16784 Content-Type: text/x-diff; name=0001-gnu-Add-emacs-semantic-refactor.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-gnu-Add-emacs-semantic-refactor.patch RnJvbSAxNDcwNzA1NTQyZjI4MzUxY2VhZjE4M2E0OWNkNWQ4NjlhNDU3NmRi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogSmFjayBIaWxsIDxq YWNraGlsbEBqYWNraGlsbC51cz4NCkRhdGU6IFN1biwgMTcgTWFyIDIwMTkg MjI6MDE6MTcgLTA0MDANClN1YmplY3Q6IFtQQVRDSF0gZ251OiBBZGQgZW1h Y3Mtc2VtYW50aWMtcmVmYWN0b3INCg0KKiBnbnUvcGFja2FnZXMvZW1hY3Mt eHl6LnNjbSAoZW1hY3Mtc2VtYW50aWMtcmVmYWN0b3IpOiBOZXcgdmFyaWFi bGUuDQotLS0NCiBnbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSB8IDQzICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystDQogMSBmaWxl IGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCg0K ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIGIvZ251 L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20NCmluZGV4IDhkNWVlNmM1ZmIuLmE4 YTU5YTJkZWUgMTAwNjQ0DQotLS0gYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbQ0KKysrIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20NCkBAIC0z Niw3ICszNiw3IEBADQogOzs7IENvcHlyaWdodCDCqSAyMDE4IE1hdGhpZXUg TGlyemluIDxtdGhsQGdudS5vcmc+DQogOzs7IENvcHlyaWdodCDCqSAyMDE4 LCAyMDE5IFBpZXJyZSBOZWlkaGFyZHQgPG1haWxAYW1icmV2YXIueHl6Pg0K IDs7OyBDb3B5cmlnaHQgwqkgMjAxOCwgMjAxOSBUaW0gR2VzdGh1aXplbiA8 dGltLmdlc3RodWl6ZW5AeWFob28uZGU+DQotOzs7IENvcHlyaWdodCDCqSAy MDE4IEphY2sgSGlsbCA8amFja2hpbGxAamFja2hpbGwudXM+DQorOzs7IENv cHlyaWdodCDCqSAyMDE4LCAyMDE5IEphY2sgSGlsbCA8amFja2hpbGxAamFj a2hpbGwudXM+DQogOzs7IENvcHlyaWdodCDCqSAyMDE4IFBpZXJyZS1BbnRv aW5lIFJvdWJ5IDxwaWVycmUtYW50b2luZS5yb3VieUBpbnJpYS5mcj4NCiA7 OzsgQ29weXJpZ2h0IMKpIDIwMTggQWxleCBCcmFuaGFtIDxhbGV4LmJyYW5o YW1AZ21haWwuY29tPg0KIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBUaG9yc3Rl biBXaWxtcyA8dF93X0BmcmVlbmV0LmRlPg0KQEAgLTEzNjkxLDYgKzEzNjkx LDQ3IEBAIGNvbW1hbmRcIiwgYnV0IGJlY2F1c2UgaXQgYWx3YXlzIGludm9s dmVzIGF0IGxlYXN0IHR3byBjb21tYW5kcyAoYSBwcmVmaXggYW5kDQogYSBz dWZmaXgpIHdlIHByZWZlciB0byBjYWxsIGl0IGp1c3QgYSBcInRyYW5zaWVu dFwiLiIpDQogICAgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKSkNCiAN CisoZGVmaW5lLXB1YmxpYyBlbWFjcy1zZW1hbnRpYy1yZWZhY3Rvcg0KKyAg OzsgVGhlIGxhc3QgcmVsZWFzZSwgMC41LCB3YXMgbWFkZSBvbiAyMDE1LTA3 LTI2IGFuZCB0aGVyZSBoYXZlIGJlZW4gNDcNCisgIDs7IGNvbW1pdHMgc2lu Y2UgdGhlbi4NCisgIChsZXQgKChjb21taXQgIjZmMmM5N2QxN2ZiNzBmNGNh MjExMmY1YTJiOTlhOGVjMTYyMDA0ZjUiKSkNCisgICAgKHBhY2thZ2UNCisg ICAgICAobmFtZSAiZW1hY3Mtc2VtYW50aWMtcmVmYWN0b3IiKQ0KKyAgICAg ICh2ZXJzaW9uIChnaXQtdmVyc2lvbiAiMC41IiAiMSIgY29tbWl0KSkNCisg ICAgICAoc291cmNlDQorICAgICAgIChvcmlnaW4NCisgICAgICAgICAobWV0 aG9kIGdpdC1mZXRjaCkNCisgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNl DQorICAgICAgICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXRodWIuY29tL3R1 aGRvL3NlbWFudGljLXJlZmFjdG9yIikNCisgICAgICAgICAgICAgICAoY29t bWl0IGNvbW1pdCkpKQ0KKyAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxl LW5hbWUgbmFtZSB2ZXJzaW9uKSkNCisgICAgICAgICAoc2hhMjU2DQorICAg ICAgICAgIChiYXNlMzINCisgICAgICAgICAgICIxbHl6M3pqa3gyY3NoMHhk eTF6cHg4czMycXAxcDNzaWc1N213aTl4aGdwcWp5ZjBheG1iIikpKSkNCisg ICAgICAoYnVpbGQtc3lzdGVtIGVtYWNzLWJ1aWxkLXN5c3RlbSkNCisgICAg ICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vdHVoZG8vc2VtYW50 aWMtcmVmYWN0b3IiKQ0KKyAgICAgIChzeW5vcHNpcyAiUmVmYWN0b3Jpbmcg dG9vbCBmb3IgQy9DKysgYW5kIExpc3AgZGlhbGVjdHMiKQ0KKyAgICAgIChk ZXNjcmlwdGlvbiAiQSByZWZhY3RvcmluZyB0b29sIGJhc2VkIG9uIHRoZSBF bWFjcyBTZW1hbnRpYyBwYXJzZXINCitmcmFtZXdvcmsuICBGb3IgQyBhbmQg QysrIGl0IHN1cHBvcnRzIG9wZXJhdGlvbnMgc3VjaCBhczoNCisNCitAZW51 bWVyYXRlDQorQGl0ZW0gR2VuZXJhdGluZyBjbGFzcyBpbXBsZW1lbnRhdGlv bnMNCitAaXRlbSBHZW5lcmF0aW5nIGZ1bmN0aW9uIHByb3RvdHlwZXMNCitA aXRlbSBDb252ZXJ0aW5nIGZ1bmN0aW9ucyB0byBmdW5jdGlvbiBwb2ludGVy cw0KK0BpdGVtIE1vdmluZyBzZW1hbnRpYyB1bml0cw0KK0BpdGVtIGV0Yy4u Lg0KK0BlbmQgZW51bWVyYXRlDQorDQorRm9yIExpc3AgZGlhbGVjdHMgbGlr ZSBDbG9qdXJlLCBFTGlzcCwgYW5kIFNjaGVtZSwgaXQgc3VwcG9ydHMgb3Bl cmF0aW9ucyBzdWNoDQorYXM6DQorDQorQGVudW1lcmF0ZQ0KK0BpdGVtIEZv cm1hdHRpbmcgdGhlIHdob2xlIGJ1ZmZlcg0KK0BpdGVtIENvbnZlcnRpbmcg c2V4cHJlc3Npb25zIHRvIG9uZSBvciBtdWx0aXBsZSBsaW5lcw0KK0BpdGVt IGV0Yy4uLg0KK0BlbmQgZW51bWVyYXRlXG4iKQ0KKyAgICAgIChsaWNlbnNl IGxpY2Vuc2U6Z3BsMyspKSkpDQorDQogKGRlZmluZS1wdWJsaWMgZW1hY3Mt bmhleGwtbW9kZQ0KICAgKHBhY2thZ2UNCiAgICAgKG5hbWUgImVtYWNzLW5o ZXhsLW1vZGUiKQ0KLS0gDQoyLjIxLjANCg0K --925712948-1325076525-1552878290=:16784--