From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uEK5NoIFRmIBmgAAgWs5BA (envelope-from ) for ; Thu, 31 Mar 2022 21:48:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OEh1MoIFRmJHXQAAauVa8A (envelope-from ) for ; Thu, 31 Mar 2022 21:48:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26EC62EFBF for ; Thu, 31 Mar 2022 21:48:18 +0200 (CEST) Received: from localhost ([::1]:56950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na0mH-0001uT-6U for larch@yhetil.org; Thu, 31 Mar 2022 15:48:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na0m5-0001rv-0X for guix-devel@gnu.org; Thu, 31 Mar 2022 15:48:05 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:52901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na0m3-0003mB-0O for guix-devel@gnu.org; Thu, 31 Mar 2022 15:48:04 -0400 Received: from hermia.goebel-consult.de ([79.211.186.179]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MWixU-1nXwMH1LTc-00X3Mw; Thu, 31 Mar 2022 21:47:25 +0200 Received: from [127.0.0.1] (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 6C2076210B; Thu, 31 Mar 2022 21:47:34 +0200 (CEST) Message-ID: Date: Thu, 31 Mar 2022 21:47:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Removing #:skip-build? from the crate importer? Content-Language: en-US To: Maxime Devos , guix-devel@gnu.org References: <32ae0e474e295fa7f7052abd1bbb8053d2fddf16.camel@telenet.be> From: Hartmut Goebel Organization: crazy-compilers.com In-Reply-To: <32ae0e474e295fa7f7052abd1bbb8053d2fddf16.camel@telenet.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:UuP1Up5oVxLyiz7Kmd1cscfe26Jy/EflQTGvBY+c0RWfi1niorw rvWarqXlIj+2hk+r0W/ey//e7loFaLzlwR3fa5xZT6FqhZxmAE1QcgDxkTrfvFEoLZSNZaO 8plcKTbkiWkp6IeLFcD95U9XwAVr8JJ5jDf8VJ6lgPGXNDZ/WtfMOJJDAMjapi2vlqSmEor HCmldxScW5vOXeJm+qQjg== X-UI-Out-Filterresults: notjunk:1;V03:K0:sgrxRNsL9Wk=:pPGylfb4ltwfXM96AP2DlZ cjxSk1tFzhWJBA4Dq2fj+6fJJRo8cAM7Pzhne+kk9dVeV17tBoI3UgvaeksA41+zm04r+dutr dNGrcBJ3AhxkODqzZgcByFWzEDDbVKYMgvmqhCLSU8EiD75BkYi/3QNUV3l9rgEd+WbVAcwNz sL/OCTBIwyS2wCx7AnNpgqbqsvq2HokAeqQWpW2qvce8vzwMZufUnrmb+Az7uQvrMFvrF5mM3 p8OiONsR/Q6afNG5aoxECwr/hjEDHcST/PENub13G8ffE9bXj3PMfN89Ko8KDHUuZ89BxWTHW BlubnrI39EIrYgNnQGo5qYhSpGTCeLrRcE/TeHd83kBsyWJtsPgsaKlEzVvLv3ma9l4KqSAJT 2p4tycpF+5I8H1EjvFHLl32SJW0Vn5rp3VG/FJix4/idAfadR6KBf1HAyZclkCyquWq41zyMy QRt9hF78huICmoVjEnAjfGWy2Rdss4lipWlMcNjReXYptWfL8vDkPM0nEs8A9e7KgyWZ2zPZO k7WBDk0WSp8gxmGPdZhmGITN+HatgmHI+tCGvaCVSjwtbR5LiBb/R1FH/kWvn5nVvYo355Tdc JM0HQ52f9Hpug5qXvkfrNID81EhpYURvgeY8Q/L2eq8PJ6DylpqcKng+7G8udgtr1e+UxNw93 DKfzlb0ekCoAKUJI/gve0/cHJCXq9SfuaTY8wGOLyLmo04nZUEIvzZeXL45Oax5M/eZdFSInF /ur9rdyJInxD8O8K Received-SPF: none client-ip=212.227.126.187; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Becze Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648756098; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=J6E+yYQdTWDHjgaOsfg0pxQt7Rwp9NHcTXbb5y7o8iw=; b=cA5Le0RvnIEXEjOA6ZxNM1PgvvNGoods/Xoi0J0Ig1z/InMg8xO6554TDVDrrV8IcA8cnf s/Kpx8gHFhxIyue4rSKr9xowz3H56a7YesiBmsczxbalBYwTbAbRYAOG5Un/O8AWmK24Q2 +lU+kFzxbSMDMdRMiBdmeQwvH3mw12dyZrq2w2xfV7PSAyyHISnktcFKoYNfawc7HOHPGO q5K42asbU0Wimbxi0RYEnr/sQpgSg9go/uwDFs79iJ/JuCG+Jva8w2izY7JHXoRAZkhDDx 6mRo4JeqauKH9ifyDtoAFvKPXcu1Uo9J5Z9o7M4tLU7QxXajIKViX1EcHcl6Jg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648756098; a=rsa-sha256; cv=none; b=EmBk3ppGqTd1EqbnOrxufIxbhT/o8JU6KOXZNaDS/lXzBwOuBf4dUJBH1eWEA3HfHFW5lE WFwnHqiKOdxcRRDh5CIBjZ0xMLMLGkzqtLCZs8rhBdhU6PtSLhyVG0GhFDKvMOG45ksDQc ZXZXEk/YKRsxx0UuhOKvzNdhNbO1EDfm6+wgIid5yGZnAhnxlPCqSrg9tKR5pZ8QD+nGyZ 0HiBCXKxG5GEktrBIBaW0Jq/5Mls0jmJr/vTM6pteWyKwx1mjlBxKj309qF8Ew+mPLZAQk zY48UWr1XzsQ8gq1dH3X48rYJmxybCK9W57boDHAOi1RzT3no+BfJbvmK5/+7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 26EC62EFBF X-Spam-Score: -1.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: yEq0ZFcAO9ib Hi, since rust does not support anything like static or dynamic libraries, building (intermediate) crates is useless like a hole in my head. Any output on any intermediate crate will just be thrown away. > Often, when new rust package definitions are submitted at guix- > patches@, I see #:skip-build? #false. Apparently it's added by default > in (guix import cargo), with some exceptions. The idea behind is to have #:skip-buiild #f for all "top level" crates, which are assumed to be programs. Thus, only crates imported recursively will get get #:skip-buiild #t. If one imports a single crate, it well get #:skip-buiild #f — which is what you experience. > However, ‘(guix)Rust > Crates’ states: > > Care should be taken to ensure the correct version of dependencies > are used; to this end we try to refrain from skipping the tests or > using ‘#:skip-build?’ when possible. Of course this is not always > possible [...] This text is from 2020-02-17 (written by Effraim) and predates 269c1db41bd8 (committed 2020-12-02). While I understand the intention of this, I'm not convinces about it. Primary this will lead to a huge wast of time and electrical power - just to trash the results. This will not only effect our own build farm, but also each user. Please be aware, that with #:skip-buiild #t, every crate will be build again by every other crate using it. So if crate AA is used by B1 and B2 and C1 depends on B1 and B2, AA will be build 4 times! > As such, WDYT of removing #:skip-build? #false from (guix import > crate)? FWIW, this was added in commit I would propose the opposite: Keep it and make #t the default. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |