all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: nee <nee@cock.li>
Cc: 26488@debbugs.gnu.org
Subject: bug#26488: [PATCH] gnu: Add crawl.
Date: Wed, 19 Apr 2017 11:41:34 +0530	[thread overview]
Message-ID: <af1b313c.ADsAAHQO6XkAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY9v-d@mailjet.com> (raw)
In-Reply-To: <43dae64d-8d60-8930-ce6b-12afd44fe787@cock.li>


> Thank you very much, for your intensive help with cleaning up this package!

No problem! That's what I'm here for... :-) And, thank you for your
patience with all my corrections!

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)
> +         ;; Test cases require the source to be rebuild with the -DDEBUG define.
> +         ;; Do 'check before 'build to avoid a 3rd build on make install.
> +         (add-before 'build 'check
> +           (lambda* (#:key inputs outputs make-flags
> +                     parallel-build? parallel-tests? #:allow-other-keys)

Since you are not using the parallel-build? and parallel-tests? keyword
arguments anymore, why keep them in the argument list?

> +             (zero? (apply system* "make" "debug" "test"
> +                           (cons (format #f "-j~d" (parallel-job-count))
> +                                 make-flags))))))))

As noted earlier, only the last argument of apply needs to be a
list. So, this can be shortened to something like:

(zero? (apply system* "make" (format #f "-j~d"
(parallel-job-count)) "debug" "test" make-flags))

Everything else LGTM! Only the graphical build remains now.

  reply	other threads:[~2017-04-19  6:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 21:26 bug#26488: [PATCH] gnu: Add crawl nee
     [not found] ` <cu7shlbed1g.fsf@systemreboot.net>
2017-04-14  8:07   ` Arun Isaac
2017-04-14 16:10     ` nee
2017-04-14 17:23       ` Danny Milosavljevic
2017-04-14 18:04       ` Arun Isaac
     [not found]       ` <c09ea559.AEMAJMF3UlcAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com>
2017-04-17  4:46         ` nee
2017-04-17 18:37           ` Arun Isaac
2017-04-18 22:15             ` nee
2017-04-19  6:11               ` Arun Isaac [this message]
2017-04-21 17:10                 ` Christopher Allan Webber
2017-04-21 20:25                   ` Arun Isaac
2017-04-17 19:29           ` Arun Isaac
2017-04-17 21:29             ` nee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af1b313c.ADsAAHQO6XkAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY9v-d@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=26488@debbugs.gnu.org \
    --cc=nee@cock.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.