From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 2/2] gnu: Add evilwm. Date: Tue, 20 Oct 2015 14:37:22 -0500 Message-ID: References: <1444948609-29345-1-git-send-email-ericbavier@openmailbox.org> <1444948609-29345-2-git-send-email-ericbavier@openmailbox.org> <87vba7tdig.fsf@gnu.org> <20151019065541.771c7a5e@openmailbox.org> <87zizex9a7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zocj8-0000Xy-7V for guix-devel@gnu.org; Tue, 20 Oct 2015 15:37:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zociz-00027s-Iy for guix-devel@gnu.org; Tue, 20 Oct 2015 15:37:42 -0400 Received: from smtp1.openmailbox.org ([62.4.1.35]:37274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zociz-00024U-AF for guix-devel@gnu.org; Tue, 20 Oct 2015 15:37:33 -0400 In-Reply-To: <87zizex9a7.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: ludo@gnu.org Cc: guix-devel@gnu.org On 2015-10-20 02:56, ludo@gnu.org wrote: > Eric Bavier skribis: >=20 >> On Fri, 16 Oct 2015 10:37:43 +0200 >> ludo@gnu.org (Ludovic Court=C3=A8s) wrote: [...] >> + 'install 'install-fonts-dir >> + ;; The X font server will not add directories to=20 >> the font >> + ;; path unless they contain a "fonts.dir" file, so= =20 >> add some >> + ;; dummy files. >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out"))) >> + (for-each (lambda (d) >> + (call-with-output-file >> + (string-append out=20 >> "/share/fonts/X11" >> + "/" d=20 >> "/fonts.dir") >> + (lambda (p) >> + (format p "0~%")))) >> + '("75dpi" "100dpi" "misc"=20 >> "cyrillic")) >=20 > So how did you settle on "0~%"? :-) I ran 'mkfontdir' on an empty directory, and the "fonts.dir" file it=20 wrote contained just a "0" on a line of its own. I'm not sure whether things=20 would work with just an empty file. >> From 45c524710742550013a8513b641e8d488806f7c9 Mon Sep 17 00:00:00 2001 >> From: Eric Bavier >> Date: Thu, 15 Oct 2015 17:34:26 -0500 >> Subject: [PATCH 4/4] gnu: Add evilwm. >>=20 >> * gnu/packages/wm.scm (evilwm): New variable. >=20 > [...] >=20 >> + (arguments >> + `(#:modules ((srfi srfi-26) >> + ,@%gnu-build-system-modules) >=20 > Note that %GNU-BUILD-SYSTEM-MODULES is the set of modules *imported* in > the build environment (inputs of the derivation), not the set of=20 > modules > visible in the build script. See =E2=80=98%default-modules=E2=80=99 > vs. =E2=80=98%gnu-build-system-modules=E2=80=99 in (guix build-system g= nu) for the > difference. Thanks for the pointer. I saw some other packages using=20 %gnu-build-system-modules and wasn't aware of the subtleties. > So it should rather be: >=20 > #:modules ((srfi srfi-26) > (guix build utils) > (guix build gnu-build-system)) I'll use that then. > In practice it probably won=E2=80=99t make any difference. I don't mind being pedantic. :) > Otherwise LGTM. Great! Thanks for the reviews. I'll push with those changes. --=20 `~Eric