From: Adam Faiz via Guix-patches via <guix-patches@gnu.org>
To: 57625@debbugs.gnu.org
Subject: [bug#57625] [PATCH 1/3] gnu: Add libgc-private-headers-for-pnet.
Date: Wed, 7 Sep 2022 10:48:45 +0800 [thread overview]
Message-ID: <ae783ede-aaea-3d88-5a1f-426360a6695f@disroot.org> (raw)
In-Reply-To: <13dfa7fa-a27f-f68d-43ba-4be55e14ba16@telenet.be>
On 9/7/22 00:55, Maxime Devos wrote:
> Also, why a hidden package?
> Greetings,
> Maxime.
I wasn't sure if the package would be useful being exposed to the user
interface, since it's specific to pnet's needs.
> (*) Untested proposal:
>
> (define-public libgc-all-headers ; TODO(core-updates) merge into libgc
> (package
> (inherit libgc)
> (name "libgc-all-headers")
> (outputs "out")
> (arguments
> (append (package-arguments libgc)
> (list #:imported-modules
> '((guix build gnu-build-system) (guix build copy-build-system))
> #:phases
> #~(modify-phases
> (add-after 'install 'delete-library
> (lambda _
> (delete-file-recursively (string-append #$output "/lib"))))
> (add-after 'install 'delete-private-header
> (lambda _
> (delete-file-recursively (string-append #$output "/lib"))))
Why is 'delete-private-header the same as 'delete-library?
Was it a typo, and supposed to delete something else("include/private"?)
> (add-after 'install 'install-private
> (lambda arguments
> ((@ (guix build copy-build-system) install)
> (append (list #:install-plan '(("include/config.h" [...]) [...]))
> arguments))))))))
> (synopsis ...)
> (description ...)))
Thanks, this looks much better than what I wrote. I didn't know how I
could inherit it from libgc. I can use this in the V1 for this patch.
next prev parent reply other threads:[~2022-09-07 2:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 8:48 [bug#57625] [PATCH 0/3] WIP: Add pnet Adam Faiz via Guix-patches via
2022-09-06 15:34 ` [bug#57625] [PATCH 1/3] gnu: Add libgc-private-headers-for-pnet Adam Faiz via Guix-patches via
2022-09-06 16:55 ` Maxime Devos
2022-09-07 2:48 ` Adam Faiz via Guix-patches via [this message]
2022-09-06 15:39 ` [bug#57625] [PATCH 2/3] gnu: Add treecc Adam Faiz via Guix-patches via
2022-09-06 18:07 ` Maxime Devos
2022-09-06 15:53 ` [bug#57625] WIP: gnu: Add pnet Adam Faiz via Guix-patches via
2022-09-06 17:23 ` Maxime Devos
2022-11-18 9:15 ` [bug#57625] [PATCH v1 01/03] gnu: Add libgc-all-headers Adam Faiz via Guix-patches via
2022-11-18 9:20 ` [bug#57625] [PATCH v1 02/03] gnu: Add treecc Adam Faiz via Guix-patches via
2022-11-18 9:28 ` [bug#57625] [PATCH v1 03/03] WIP : gnu: Add pnet Adam Faiz via Guix-patches via
2022-11-19 10:33 ` [bug#57625] [PATCH v2 1/3] gnu: Add libgc-all-headers Adam Faiz via Guix-patches via
2022-11-19 10:35 ` [bug#57625] [PATCH v2 2/3] gnu: Add treecc Adam Faiz via Guix-patches via
2022-11-19 10:37 ` [bug#57625] [PATCH v2 3/3] gnu: Add pnet Adam Faiz via Guix-patches via
2023-06-26 13:17 ` [bug#57625] [PATCH v3 1/4] gnu: Add libgc-all-headers Adam Faiz via Guix-patches via
2023-06-26 13:20 ` [bug#57625] [PATCH v3 2/4] gnu: Add treecc Adam Faiz via Guix-patches via
2023-06-26 13:23 ` [bug#57625] [PATCH v3 3/4] gnu: Add pnet Adam Faiz via Guix-patches via
2023-06-26 13:25 ` [bug#57625] [PATCH v3 4/4] gnu: Add pnetlib Adam Faiz via Guix-patches via
2023-06-26 23:38 ` Adam Faiz via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae783ede-aaea-3d88-5a1f-426360a6695f@disroot.org \
--to=guix-patches@gnu.org \
--cc=57625@debbugs.gnu.org \
--cc=adam.faiz@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.