From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uADUGMeN0mWIygAA62LTzQ:P1 (envelope-from ) for ; Mon, 19 Feb 2024 00:07:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id uADUGMeN0mWIygAA62LTzQ (envelope-from ) for ; Mon, 19 Feb 2024 00:07:51 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b="Xl+qV7/r"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708297671; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=L+HzX9yJiyn9ziwFy4NipK6KADwY2e4YAwzg4PQ2uuA=; b=Ko5YvEcx0mi8HYB4GLewZZVEojOmLMAMuUYSvtDkcbudf5aP2gvhCAqSstN9OKHTWOZlfT aDEg27RVDtkng3CkHnARscJFiOmmq/lHgttLLWzOP/+RHWdmLbj6woh1eS2DTGp9ZRrrzO i0thxvto34N8GuyQglfpULy8RMUXVpRYZv+rnRroiSl1mzn2UCllkuNMKlka4Mvksj6ZLp OdPOLnD0tJS+Etv11nlRltW6rxMTZD8Yiv9BALTbpOW+GtFDQCB0HGOed3l3xrcW35gVBP bS1AHetVtjiVxTbPyaDL9acfLr6L8R3WAZslpCm/3/mtCW1XjZuu1ylRDx/t0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b="Xl+qV7/r"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708297671; a=rsa-sha256; cv=none; b=J2vHV9QQ78QJ88ag79Nw4ipRZOAfpR9UW8IZ7ieyuzuUGq0Us+Ys3k8KdP2XfSMB6HQlQ7 CvakY+7bOMTHYS5HbzcvRYDegSEOm00qbQ0kD9MX1VzVFrpB+9zV72bg8d/RSisKHMDC4O no8fqhVDGkJ/LYkT7OFzFdObmhjIqV2a7XrT1ss+9htUSm6J3fkeF5TjUZ+G7IJvaXXZ85 FQY4jvwkR60OcR++RSoYhIphZAXN4nLZIoab0f51i40ds5j2J1wMkoOeMfbWSYJotuvj/A gUR5CMRdNuRsiyasGAI2uiZLWqYoPsyAyz89ENsEwAH4iZc9d+0oUzTUD3Ynrw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D0855C5DE for ; Mon, 19 Feb 2024 00:07:51 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbqG7-0006K9-F7; Sun, 18 Feb 2024 18:07:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbqG5-0006Jh-FX for guix-patches@gnu.org; Sun, 18 Feb 2024 18:07:41 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbqG5-0001j9-5E for guix-patches@gnu.org; Sun, 18 Feb 2024 18:07:41 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rbqGP-0001l8-QL for guix-patches@gnu.org; Sun, 18 Feb 2024 18:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69251] [PATCH] gnu: Add r-abbreviate. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Feb 2024 23:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69251 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Wiktor =?UTF-8?Q?=C5=BBelazny?= , 69251@debbugs.gnu.org Cc: Ricardo Wurmus Received: via spool by 69251-submit@debbugs.gnu.org id=B69251.17082976456711 (code B ref 69251); Sun, 18 Feb 2024 23:08:01 +0000 Received: (at 69251) by debbugs.gnu.org; 18 Feb 2024 23:07:25 +0000 Received: from localhost ([127.0.0.1]:39944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqFp-0001kA-Bu for submit@debbugs.gnu.org; Sun, 18 Feb 2024 18:07:25 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:19271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqFn-0001jv-05 for 69251@debbugs.gnu.org; Sun, 18 Feb 2024 18:07:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1708297616; x=1708556816; bh=L+HzX9yJiyn9ziwFy4NipK6KADwY2e4YAwzg4PQ2uuA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Xl+qV7/rvnwmUkrwQhCUDLqiklEfUwyjxDdb2F18MM9Lv/jQqrSTG+pDohkhCBqP/ PDK5Dqj90Skah7hztIQCwDYDthgZvvFLRKnW4AjbnDffUlnus5xPkh3uLLx+weCqdH pfsb7ssRi2HCt+n99gfOwCO450JITU3HD8wgvfo/byUEArcZ3ImWmk4fUmHEg5NUYw dAb/RwlI0fMkoeTSw9Bc6YlGv0/s4TkZBNT4PJRGFvjPtVsLQ0tazxOMX5f/mUsrz1 p89fnm/P4IUT/xa10339j3aKsEmthMjHBywErryBJJgoI0Oy5DCegWdMrbxMEtuit+ 9UhwJYl21227g== Date: Sun, 18 Feb 2024 23:06:44 +0000 Message-ID: In-Reply-To: References: Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.98 X-Spam-Score: -6.98 X-Migadu-Queue-Id: 1D0855C5DE X-Migadu-Scanner: mx11.migadu.com X-TUID: Mm/jkHziVpMP Each section includes a checklist based on (and expands upon) the items=20 listed in the manual (22.7 "Submitting Patches"). Each checklist item=20 may have one of the following statuses: C: Commitable. This item looks as expected for a final commit. CC: Commitable with Context. Like commitable, but some notes have been=20 added providing context about anything notable or unusual. These notes=20 are provided for transparency and should not be interpreted as meaning=20 that I object to the patch. MR: Minor Repair. There is something about the patch which I think=20 should ideally be changed, but I do not think that the patch should be=20 refused on this basis alone. A: Attention. Something in the patch needs attention from the author,=20 the committer, or both. Resolving the matter may or may not require a=20 change to the patch. XX: This item is not relevant to the patch. Blank: I did not review this aspect of the patch. [C ] Applies cleanly (commit fdbf4192f5eaa7fdb5e6e2e98ada0726c8104824) [C ] Commit message looks correct & complete [CC] Cryptographic hash [A ] Project is maintained [C ] Synopsis & Description [C ] Package license matches source license [C ] No compiler warnings (guix project, not package build) [CC] `guix lint` output [C ] `guix style` output [C ] Package builds (my host is an x86_64 Xen guest) [=C2=A0 ] Builds for other architectures [C ] No bundled software [CC] Works in container with minimal inputs [C ] `guix size` output [XX] Dependent packages (`guix refresh --list-dependent PACKAGE`) [C ] `guix build --rounds=3D2` [C ] Gender-neutral wording [C ] One set of related changes [CC] Simulated guix pull # Cryptographic Hash I was not able to locate a cryptographic hash for this package. # Project is Maintained All of the commits are from the end of 2021 and the version remains at=20 "0.1". However, the package is doing something relatively simple and=20 there are no open issues on the GitHub page (to be fair, there is only=20 one closed issue and it was handled ~2 months after the project was=20 uploaded). There were about 1000 downloads within the past month at time of writing=20 (https://cranlogs.r-pkg.org/badges/last-month/abbreviate), implying that=20 some number of people are using the package. Combined with the lack of=20 issue reports, this gives some confidence that the lack of new commits=20 is "this doesn't need any changes" rather than "this is unmaintained". # guix lint There is a note that the source is not archived on Software Heritage or=20 Disarchive database. The 'archival' section in the "Invoking 'guix=20 lint'" chapter (9.8) indicates that the Software Heritage will pick up=20 the source at some point in the future. # Works in container with minimal inputs I used the following environment: $ ./pre-inst-env guix shell -C r-abbreviate r > library(abbreviate) Then I entered some of the example commands from the README. The calls=20 were successful and produced reasonable-looking output. # Simulated Guix Pull I committed the diff locally and used `--disable-authentication`, which=20 I think is fine because the signature on the commit is unrelated to the=20 contents of the commit in this context.