From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien lepiller Subject: [PATCH] Re: The usability of Guix configurations Date: Tue, 07 Nov 2017 17:25:33 +0100 Message-ID: References: <868tfjw4is.fsf@gmail.com> <20171106221621.GA2534@jasmine.lan> <86o9oex34v.fsf@gmail.com> <779b1b6f2043e03a2f911981142e7740@lepiller.eu> <777f3534955ec61a520ff5f9b7054673@lepiller.eu> <86tvy6tbz5.fsf@gmail.com> <86efpat6z6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_953a8da7106796f41bc3e38347f947d1" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC6h2-0008Eg-11 for guix-devel@gnu.org; Tue, 07 Nov 2017 11:25:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC6gy-0005Az-Sz for guix-devel@gnu.org; Tue, 07 Nov 2017 11:25:40 -0500 Received: from lepiller.eu ([2a00:5884:8208::1]:36778) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eC6gy-00058T-IZ for guix-devel@gnu.org; Tue, 07 Nov 2017 11:25:36 -0500 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id b8303260 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Tue, 7 Nov 2017 16:27:23 +0000 (UTC) In-Reply-To: <86efpat6z6.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=_953a8da7106796f41bc3e38347f947d1 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Le 2017-11-07 16:59, myglc2 a écrit : > On 11/07/2017 at 15:52 julien lepiller writes: >> >> Maybe that's too much? > > Not for me. Looks great! Just a couple minor suggestions: > > 1) How about narrowing search to locations like this: > > Hint: You may use `guix package --show=foo | grep location` to search > for foo's location. Oh, I didn't know this option, good idea, thanks :D > > 2) I think you mean to say "foo" where you say "ssh" in the last two > HINTs You're right, though I prefer to use "bar" to show there is no relation between the package name and its module. I added "[PATCH]" to the subject to get others look at this message. I plan to push it in a few days unless it gets more comments. If an experienced schemer could look at that, I'm sure the coding style could be improved a lot ;) --=_953a8da7106796f41bc3e38347f947d1 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Catch-use-modules-errors-in-configuration.patch Content-Disposition: attachment; filename=0001-Catch-use-modules-errors-in-configuration.patch; size=2844 RnJvbSBlMDkyNzI1YzA1NjI1ZjFiNmM1NzA1MTc3YjNmMDgwNDcxNjExZTg1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gTGVwaWxsZXIgPGp1bGllbkBsZXBpbGxlci5ldT4K RGF0ZTogVHVlLCA3IE5vdiAyMDE3IDExOjQ2OjM0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQ2F0 Y2ggdXNlLW1vZHVsZXMgZXJyb3JzIGluIGNvbmZpZ3VyYXRpb24uCgoqIGdudS5zY20gKHVzZS1w YWNrYWdlLW1vZHVsZXMsIHVzZS1zZXJ2aWNlLW1vZHVsZXMsIHVzZS1zeXN0ZW0tbW9kdWxlcyk6 CkNhdGNoIHVzZS1tb2R1bGVzIGVycm9ycyBhbmQgc2hvdyBhIHNtYWxsIGV4cGxhbmF0aW9uIGFi b3V0IGl0LgotLS0KIGdudS5zY20gfCA0MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2dudS5zY20gYi9nbnUuc2NtCmluZGV4IDkxM2NlNjE2MC4uMWFl NWYyZDFkIDEwMDY0NAotLS0gYS9nbnUuc2NtCisrKyBiL2dudS5zY20KQEAgLTIsNiArMiw3IEBA CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTQsIDIwMTUsIDIwMTYgTHVkb3ZpYyBDb3VydMOocyA8bHVk b0BnbnUub3JnPgogOzs7IENvcHlyaWdodCDCqSAyMDE1IEpvc2h1YSBTLiBHcmFudCA8amdyYW50 QHBhcmVudGhldGljYWwuaW8+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTcgTWF0aGlldSBPdGhhY2Vo ZSA8bS5vdGhhY2VoZUBnbWFpbC5jb20+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMTcgSnVsaWVuIExl cGlsbGVyIDxqdWxpZW5AbGVwaWxsZXIuZXU+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBv ZiBHTlUgR3VpeC4KIDs7OwpAQCAtNTIsMTMgKzUzLDQ4IEBACiAgICAgICAgICAgICAgICAgICAo bW9kdWxlLXVzZSEgaSAocmVzb2x2ZS1pbnRlcmZhY2UgbSkpKSkKICAgICAgICAgICAgICAgJXB1 YmxpYy1tb2R1bGVzKSkpCiAKKyhkZWZpbmUgKGltcG9ydC1lcnJvciB0eXBlIG1vZHVsZSBzeW50 YXgpCisgIChkZWZpbmUgcGFja2FnZS1oaW50CisgICAgKHN0cmluZy1hcHBlbmQKKyAgICAgICJI aW50OiBZb3UgbWF5IHVzZSBgZ3VpeCBwYWNrYWdlIC0tc2hvdz1mb28gfCBncmVwIGxvY2F0aW9u YCB0byBzZWFyY2hcbiIKKyAgICAgICJIaW50OiBmb3IgZm9vJ3MgbG9jYXRpb24uXG4iCisgICAg ICAiSGludDogSWYgeW91IGdldCB0aGUgbGluZSBcImxvY2F0aW9uOiBnbnUvcGFja2FnZXMvYmFy LnNjbToxNzQ6MlwiLFxuIgorICAgICAgIkhpbnQ6IHlvdSB3YW50IHRvIGFkZCBiYXIgaW4gdXNl LXBhY2thZ2UtbW9kdWxlcy4iKSkKKyAgKGRlZmluZSBzZXJ2aWNlLWhpbnQKKyAgICAoc3RyaW5n LWFwcGVuZAorICAgICAgIkhpbnQ6IFlvdSBtYXkgdXNlIGBndWl4IHN5c3RlbSBzZWFyY2ggZm9v YCB0byBzZWFyY2ggZm9yIGZvbydzIGxvY2F0aW9uLlxuIgorICAgICAgIkhpbnQ6IElmIHlvdSBn ZXQgdGhlIGxpbmUgXCJsb2NhdGlvbjogZ251L3NlcnZpY2VzL2Jhci5zY206MTg4OjJcIixcbiIK KyAgICAgICJIaW50OiB5b3Ugd2FudCB0byBhZGQgYmFyIGluIHVzZS1zZXJ2aWNlLW1vZHVsZXMu IikpCisgIChlcnJvciAoc3RyaW5nLWFwcGVuZAorICAgICAgICAgICB0eXBlICIgbW9kdWxlIFwi IiBtb2R1bGUgIlwiIGRvZXMgbm90IGV4aXN0LlxuIgorICAgICAgICAgICAiQ2hlY2sgdGhlIFwi IiBzeW50YXggIlwiIGxpbmUgaW4geW91ciBjb25maWd1cmF0aW9uLlxuIgorICAgICAgICAgICAo aWYgKGVxdWFsPyB0eXBlICJQYWNrYWdlIikKKyAgICAgICAgICAgICAgIHBhY2thZ2UtaGludAor ICAgICAgICAgICAgICAgKGlmIChlcXVhbD8gdHlwZSAiU2VydmljZSIpCisgICAgICAgICAgICAg ICAgICAgc2VydmljZS1oaW50CisgICAgICAgICAgICAgICAgICAgIiIpKSkpKQorCiAoZGVmaW5l LXN5bnRheC1ydWxlICh1c2UtcGFja2FnZS1tb2R1bGVzIG1vZHVsZSAuLi4pCi0gICh1c2UtbW9k dWxlcyAoZ251IHBhY2thZ2VzIG1vZHVsZSkgLi4uKSkKKyAgKGJlZ2luCisgICAgKGNhdGNoICN0 IChsYW1iZGEgKCkgKHVzZS1tb2R1bGVzIChnbnUgcGFja2FnZXMgbW9kdWxlKSkpCisgICAgICAg ICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChpbXBvcnQtZXJyb3IgIlBhY2thZ2UiIChzeW1i b2wtPnN0cmluZyAnbW9kdWxlKSAidXNlLXBhY2thZ2UtbW9kdWxlcyIpKSkKKyAgICAuLi4pKQog CiAoZGVmaW5lLXN5bnRheC1ydWxlICh1c2Utc2VydmljZS1tb2R1bGVzIG1vZHVsZSAuLi4pCi0g ICh1c2UtbW9kdWxlcyAoZ251IHNlcnZpY2VzIG1vZHVsZSkgLi4uKSkKKyAgKGJlZ2luCisgICAg KGNhdGNoICN0IChsYW1iZGEgKCkgKHVzZS1tb2R1bGVzIChnbnUgc2VydmljZXMgbW9kdWxlKSkp CisgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChpbXBvcnQtZXJyb3IgIlNlcnZp Y2UiIChzeW1ib2wtPnN0cmluZyAnbW9kdWxlKSAidXNlLXNlcnZpY2UtbW9kdWxlcyIpKSkKKyAg ICAuLi4pKQorCiAKIChkZWZpbmUtc3ludGF4LXJ1bGUgKHVzZS1zeXN0ZW0tbW9kdWxlcyBtb2R1 bGUgLi4uKQotICAodXNlLW1vZHVsZXMgKGdudSBzeXN0ZW0gbW9kdWxlKSAuLi4pKQorICAoYmVn aW4KKyAgICAoY2F0Y2ggI3QgKGxhbWJkYSAoKSAodXNlLW1vZHVsZXMgKGdudSBzeXN0ZW0gbW9k dWxlKSkpCisgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChpbXBvcnQtZXJyb3Ig IlN5c3RlbSIgKHN5bWJvbC0+c3RyaW5nICdtb2R1bGUpICJ1c2Utc3lzdGVtLW1vZHVsZXMiKSkp CisgICAgLi4uKSkKKwogCiA7OzsgZ251LnNjbSBlbmRzIGhlcmUKLS0gCjIuMTMuNgoK --=_953a8da7106796f41bc3e38347f947d1--