all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tomas Volf <~@wolfsden.cz>
To: 74508@debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [bug#74508] [PATCH v3 2/3] services: mingetty: Rename misnamed accessors.
Date: Tue,  3 Dec 2024 01:11:38 +0100	[thread overview]
Message-ID: <adac71d33dd2a6a2f7e98cd1181e3717b80bd00e.1733184699.git.~@wolfsden.cz> (raw)
In-Reply-To: <746975a119582d4dc85f1e5615d6b870a81164a9.1733184699.git.~@wolfsden.cz>

Rename the accessors to ensure all start with `mingetty-configuration-'
prefix.  Some were named just `mingetty-$FIELD', instead of
`mingetty-configuration-$FIELD'.

The renaming *is* backwards compatible, since in the define-module's #:export
argument the correct (`mingetty-configuration-$FIELD') were used already and
thus the accessors were not accessible.

* gnu/services/base.scm (<mingetty-configuration>): Rename accessors for
auto-login, login-program, login-pause?, clear-on-logout?.

Change-Id: I4557a82498805ade0b341feda9d33eccc305690f
---
v2: Now is a separate commit.

 gnu/services/base.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 798356ed84..f1995640f1 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1248,14 +1248,14 @@ (define-record-type* <mingetty-configuration>
   mingetty-configuration?
   (mingetty          mingetty-configuration-mingetty ;file-like
                      (default mingetty))
-  (tty               mingetty-configuration-tty) ;string
-  (auto-login        mingetty-auto-login         ;string | #f
+  (tty               mingetty-configuration-tty)       ;string
+  (auto-login        mingetty-configuration-auto-login ;string | #f
                      (default #f))
-  (login-program     mingetty-login-program ;gexp
+  (login-program     mingetty-configuration-login-program ;gexp
                      (default #f))
-  (login-pause?      mingetty-login-pause? ;Boolean
+  (login-pause?      mingetty-configuration-login-pause? ;Boolean
                      (default #f))
-  (clear-on-logout?  mingetty-clear-on-logout? ;Boolean
+  (clear-on-logout?  mingetty-configuration-clear-on-logout? ;Boolean
                      (default #t))
   (delay             mingetty-configuration-delay ;Integer | #f
                      (default #f))
--
2.46.0




  reply	other threads:[~2024-12-03  0:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24 14:28 [bug#74508] [PATCH 0/2] Improvements for mingetty-service-type Tomas Volf
2024-11-24 14:31 ` [bug#74508] [PATCH 1/2] services: mingetty: Add additional configuration options Tomas Volf
2024-11-25  1:45   ` Maxim Cournoyer
2024-11-25 15:37     ` Tomas Volf
2024-11-24 14:31 ` [bug#74508] [PATCH 2/2] services: mingetty: Support waiting on shepherd services Tomas Volf
2024-11-25  1:49   ` Maxim Cournoyer
2024-11-25 16:05 ` [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options Tomas Volf
2024-11-25 16:05   ` [bug#74508] [PATCH v2 2/3] services: mingetty: Rename misnamed accessors Tomas Volf
2024-11-25 16:05   ` [bug#74508] [PATCH v2 3/3] services: mingetty: Support waiting on shepherd services Tomas Volf
2024-12-02 11:05   ` [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options Ludovic Courtès
2024-12-03  0:18     ` Tomas Volf
2024-12-03  0:11 ` [bug#74508] [PATCH v3 " Tomas Volf
2024-12-03  0:11   ` Tomas Volf [this message]
2024-12-03  0:11   ` [bug#74508] [PATCH v3 3/3] services: mingetty: Support waiting on shepherd services Tomas Volf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='adac71d33dd2a6a2f7e98cd1181e3717b80bd00e.1733184699.git.~@wolfsden.cz' \
    --to=~@wolfsden.cz \
    --cc=74508@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.