[PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.

[PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.

[Thompson, David]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

In which Dave begins to learn how to design PCBs.

TIA for review,

- Dave

[-- Attachment #2: 0001-gnu-geda-gaf-Make-gsch2pcb-work-out-of-the-box.patch --]
[-- Type: text/x-patch, Size: 2154 bytes --]

From f4c901decb414681256b3d0278678a2a4c853b56 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson@vistahigherlearning.com>
Date: Wed, 13 Apr 2016 10:41:57 -0400
Subject: [PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.

* gnu/packages/engineering.scm (geda-gaf)[inputs]: Add m4 and pcb.
[arguments]: Add configure flags that point to PCB data files.
---
 gnu/packages/engineering.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 9a36ffb..9a299d9 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 David Thompson <davet@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -45,6 +46,7 @@
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages linux)               ;FIXME: for pcb
+  #:use-module (gnu packages m4)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -124,13 +126,22 @@ plans and designs.")
         'check 'set-home
         (lambda _
           (setenv "HOME" (getenv "TMPDIR")))
-        %standard-phases)))
+        %standard-phases
+        )
+       #:configure-flags
+       (let ((pcb (assoc-ref %build-inputs "pcb")))
+         (list (string-append "--with-pcb-datadir=" pcb "/share")
+               (string-append "--with-pcb-lib-path="
+                              pcb "/share/pcb/pcblib-newlib:"
+                              pcb "/share/pcb/newlib")))))
     (inputs
      `(("glib" ,glib)
        ("gtk" ,gtk+-2)
        ("guile" ,guile-2.0)
        ("desktop-file-utils" ,desktop-file-utils)
-       ("shared-mime-info" ,shared-mime-info)))
+       ("shared-mime-info" ,shared-mime-info)
+       ("m4" ,m4)
+       ("pcb" ,pcb)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("perl" ,perl))) ; for tests
-- 
2.7.3

Re: [PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.

[Eric Bavier]

On 2016-04-13 09:45, Thompson, David wrote:
> * gnu/packages/engineering.scm (geda-gaf)[inputs]: Add m4 and pcb.
> [arguments]: Add configure flags that point to PCB data files.

Nitpick: '[' should align with "gnu".

Is m4 really required at runtime?

Otherwise LGTM.

-- 
`~Eric

Re: [PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.

[Thompson, David]

On Wed, Apr 13, 2016 at 12:05 PM, Eric Bavier
<ericbavier@openmailbox.org> wrote:
> On 2016-04-13 09:45, Thompson, David wrote:
>>
>> * gnu/packages/engineering.scm (geda-gaf)[inputs]: Add m4 and pcb.
>> [arguments]: Add configure flags that point to PCB data files.
>
>
> Nitpick: '[' should align with "gnu".

The GNU ChangeLog standards say not to do this.  We used to indent for
awhile, but have since stopped.

> Is m4 really required at runtime?

Yes, it is.  Transforming a schematic to a PCB, for example, requires
processing M4 macros.

Thanks for the review! I'm going to push this.

- Dave

Re: [PATCH] gnu: geda-gaf: Make gsch2pcb work out-of-the-box.

[Ricardo Wurmus]

Eric Bavier <ericbavier@openmailbox.org> writes:

> On 2016-04-13 09:45, Thompson, David wrote:
>> * gnu/packages/engineering.scm (geda-gaf)[inputs]: Add m4 and pcb.
>> [arguments]: Add configure flags that point to PCB data files.
>
> Nitpick: '[' should align with "gnu".
>
> Is m4 really required at runtime?

Yes.  As far as I understand some of the configurable footprints such as
“CONNECTOR” are m4 macros.

~~ Ricardo