From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SFXZKWi3h2FC0gAAgWs5BA (envelope-from ) for ; Sun, 07 Nov 2021 12:24:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uERLJWi3h2FkbgAAbx9fmQ (envelope-from ) for ; Sun, 07 Nov 2021 11:24:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35E989D3D for ; Sun, 7 Nov 2021 12:24:24 +0100 (CET) Received: from localhost ([::1]:48266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjgHf-0008Nt-DD for larch@yhetil.org; Sun, 07 Nov 2021 06:24:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjgHK-0008Nk-5k for guix-patches@gnu.org; Sun, 07 Nov 2021 06:24:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjgHJ-00023e-Sl for guix-patches@gnu.org; Sun, 07 Nov 2021 06:24:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjgHJ-00042A-Kz for guix-patches@gnu.org; Sun, 07 Nov 2021 06:24:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#49672] [PATCH 0/9] Target check fixes and cleanups References: <20210721004615.631777-1-bauermann@kolabnow.com> In-Reply-To: <20210721004615.631777-1-bauermann@kolabnow.com> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Nov 2021 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49672 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49672@debbugs.gnu.org Received: via spool by 49672-submit@debbugs.gnu.org id=B49672.163628422315478 (code B ref 49672); Sun, 07 Nov 2021 11:24:01 +0000 Received: (at 49672) by debbugs.gnu.org; 7 Nov 2021 11:23:43 +0000 Received: from localhost ([127.0.0.1]:51919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjgH0-00041a-Vm for submit@debbugs.gnu.org; Sun, 07 Nov 2021 06:23:43 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:42156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjgGx-00041Q-Ap for 49672@debbugs.gnu.org; Sun, 07 Nov 2021 06:23:41 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id FPPd2600D4UW6Th01PPdPQ; Sun, 07 Nov 2021 12:23:37 +0100 Message-ID: From: Maxime Devos Date: Sun, 07 Nov 2021 11:23:37 +0000 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1636284217; bh=ryj+L4IuB7qePFEHABe9Q280nxYvAcFUAhteeOvfWes=; h=Subject:From:To:Date; b=pzJDkWQI6CCHWAh/oaF6MmvTJ8LyI51R0pPqJINKkI3PHpZ4GsGCrnQTEMfNGdySv VFnOfUk+PWjhyrF3Qsma/KUr5ORJuRAARlwyyafXPx+4UlJABufwFbJtqhJThIdR3Z 6WM8q+39uIaORbgkE6bKLhJRqH221C0JGNhIIqKMZYeCqc1sxb+DX/s1hMX3Oc9Egq aGW3e3CRtQ5Xgl4KqkNfiuP2LVLn8W7isGn+KatkDd+rtGmHjC2Rheu3LylaIvhOea ohAie42rhNnRsNWj02DtULj5X8kA2yT5ww+xbdO/mxraDeVXOsE08Pa8K8rGFVMK8m qifmu6Z/lKi8g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636284264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ryj+L4IuB7qePFEHABe9Q280nxYvAcFUAhteeOvfWes=; b=SEg59mztNd53ppMLdL94GHsHVRfr4Csn4B6ad2MbTbF6shJ5mBO5BxuYXiZp92aKIiCHMY 5VBp1L/z617jHupe4NiBVTFZ+X5zXxGiCOl2Zvu88CpJhXrV6U6pKobPuwIgstfSPhmtSZ MG6hzTP4jZABcTxBzCRzGF0/d31yNXVB789uZEMDBV+vRwf5ydQar35/iqPkrE4wdYjRQ2 C8mTyjit16RWvRaQHECEeXIle34UccDKzqSPGIh+loVjRL9o/DijgBxJNnb448v0bCqOk7 qxfSn0a4sHQwD24uff33dlPHiYtJX6ttz6cutlaagHYe1d73DjD40UvNsF++vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636284264; a=rsa-sha256; cv=none; b=tFTLIh5IOtu2w1oTemuBCWQBUNOWhM2jm+s8Qs5WLfwkSBsRYRucU3OvBqgmXQGcv83dWX yw4htC9xR/xUNCDpHyToXEeaUQZdprUyqfW9CYH+8jpOJk33cNHr+1r9mGl88/vxRddJTg 3iZ4RGzLtsDRzljDZs9tXOg4V5qbbdoxIfQp2Xlhj+hmt2AqIozPTiUtDi/YTT0sA3JkeI 4WKrXWGqI1ztKEP9ovRCnaLPZgZl3T+cBzKBQPpQCy8WFyBIPv/W2o5Qo1YfV0o+twdSr1 yKgwSj+UBeBDJ8STckRppTr84UUDHw5lW4svVKMZQxcRAuYgD+6q2yfTx/xqNg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=pzJDkWQI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=pzJDkWQI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 35E989D3D X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3dZVjuTOrBPG Hi, I looked over the patch series, and almost all seems reasonable to me. though I would split patch 7/9 into a patch defining current-target-gnu-triplet and into a patch using current-target-gnu- triplet, and possibly a rebase might be neccesary. Warning: I only looked at the patches, I didn't apply them for testing. I don't think the following change is necessary though: -           ,@(if (string-match "^x86_64-linux" -                               (or (%current-target-system) -                                   (%current-system))) +           ,@(if (string-match "^x86_64-linux" (current-target-nix- system)) because the regex ^x86_64-linux would match both the nix system and GNU triplet IIUC. Greetings, Maxime.