From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KOMbC9QA6mYH3wAA62LTzQ:P1 (envelope-from ) for ; Tue, 17 Sep 2024 22:21:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KOMbC9QA6mYH3wAA62LTzQ (envelope-from ) for ; Wed, 18 Sep 2024 00:21:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="qrj/y2Vi"; dkim=fail ("headers rsa verify failed") header.d=lunabee.space header.s=purelymail3 header.b=sxe8xpq3; dkim=fail ("headers rsa verify failed") header.d=purelymail.com header.s=purelymail3 header.b=b3UUIMAo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726611668; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6QDduj8PmMzbiroxxRDhs4FIRHnCb1q9Cm5MUNPqd2Y=; b=iGOgSEuhViJ1rEhrRMaFUqTes7Nz57Chfu3Z2P9ovo3VDNZV8q/qAbaDAeYl03JqTC1rtt gsYjcy7b9KzXXemfbQdgY5snK/P7+mdYFNMGLljW7qdkb+6T63OI7UmYh5LTfjcmQj8Aui gCPvkhHRBsVuxLl1C5hC4Bt80a8iF06Q/VW7bLI/1Ld5t0tdkSFYgw3YudiPR5zvHGhDGy cnOZ50o9HrYl3tVM73KRmzJv1+fN89w6aZbCdz6sX48BNlkLGhJTLZkfLLvSgsBh91CXVZ ZslroEEhqA7PhwSZ0+sEugLfz8rUwuu2/obAiuJnqZEgE7RdVkV9UbUJiPhA3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726611668; a=rsa-sha256; cv=none; b=TmfRHPze5TtA5LXxYobPATQ1btsqiGnNYtZiOM+JIkgaci/Qvbg3sUgO6GAEIRPHNtT4UK 0SRsaSLxIbiw+dMzohRLKErB/qH76cynsD1ypBIwn1XXCoqOyJ0JQwIUsQgz7Dd70dQ+SY pX8wMM2XmKma3TNugD4hXsaF3qKpn4sA+4bigbiCCbS/u0/26lMMdQEl46zXGsDBERB3rk gyTvqaXHqyPqqYG25WbBlpnCkOf1orALdIDWM7r/nyIevCAJKc7qLhiwfRGsiDul5grgUd VjfZTMzBhMCvfA/xGw963R0fg+Q8OyMKyjbgOQQ0CPh6wfprwQ3j+irqcVJRmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="qrj/y2Vi"; dkim=fail ("headers rsa verify failed") header.d=lunabee.space header.s=purelymail3 header.b=sxe8xpq3; dkim=fail ("headers rsa verify failed") header.d=purelymail.com header.s=purelymail3 header.b=b3UUIMAo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E16CD1EB99 for ; Wed, 18 Sep 2024 00:21:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqgZ0-0006SA-9i; Tue, 17 Sep 2024 18:20:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqgYx-0006RA-Ot for guix-patches@gnu.org; Tue, 17 Sep 2024 18:20:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqgYx-0008Da-FQ for guix-patches@gnu.org; Tue, 17 Sep 2024 18:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=6QDduj8PmMzbiroxxRDhs4FIRHnCb1q9Cm5MUNPqd2Y=; b=qrj/y2ViPfCSGZO5xiMZpS0Io9J4frWzR5yTFl7i6pXPIT8SQsHhGzT8SA4zvzcyCgaJTmtSQLiKbpzUJ9AYQfh1UTtd5krFLuewYhhDRxReaDReacYjaXlG8KWZMETF6nx30yp0JMVEOAu/pcO+gSNIaDO93unMBDHE7o4Zpe2GLh9fhgHT4dEC+0/JUbDbpC+1XPutehQKgVuAgndQJfSILFA2VTOOX/8K1wHVm19wldCO2DrO/Cet6PAMOuSvctRKRrsMj/KeLsSRg04/a8Lk02RwAkysf2OG1a9FYvz7gzfs1aHwqmk51IFmcGSJKk6zv03SyT+oi3unHWI19w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqgZC-0001Cq-Eo for guix-patches@gnu.org; Tue, 17 Sep 2024 18:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72457] [PATCH v5 00/15] Rewrite bootloader subsystem. Resent-From: Lilah Tascheter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Sep 2024 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72457@debbugs.gnu.org Cc: Herman Rimm Received: via spool by 72457-submit@debbugs.gnu.org id=B72457.17266116374579 (code B ref 72457); Tue, 17 Sep 2024 22:21:02 +0000 Received: (at 72457) by debbugs.gnu.org; 17 Sep 2024 22:20:37 +0000 Received: from localhost ([127.0.0.1]:56163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqgYm-0001Bm-L0 for submit@debbugs.gnu.org; Tue, 17 Sep 2024 18:20:37 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:35938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqgYj-0001BS-KC for 72457@debbugs.gnu.org; Tue, 17 Sep 2024 18:20:35 -0400 DKIM-Signature: a=rsa-sha256; b=sxe8xpq3lBOQ4+Ohrj10a48d5nWFjf4qm07Yq51sntLg5pMJjPepRxToC+KRR3s580Keji/QoUjIYvHp/1QIS3GMbb9R8H+x/p7ci4K+TbIIPUDfMxIJg+b+RfxJwtWoIdif1AZYWAksYE1NYmX8utCe265Y3tXS3mstvKWHjY11Y4SYcno+uObHM4J7q78LH4teDuxXVgAMhrAUyLwjv/vK/dB4HpDoqQ450D/sfUyoa3owSoMYHZvnmwzCB3rgi1RUHBTlL1Yfmlrj+8H7+fwn9VlW8SPrCt08R0uLz3ZwCZX4FLwKUTDR4JcTMa/uxd8yHEM9sDeJWpPm02HqMA==; s=purelymail3; d=lunabee.space; v=1; bh=6QDduj8PmMzbiroxxRDhs4FIRHnCb1q9Cm5MUNPqd2Y=; h=Received:Subject:From:To:Date; DKIM-Signature: a=rsa-sha256; b=b3UUIMAoBfX2pzrPS3FlrHLOGZ9By7zdTBcr2062jJgtI5LhxSw+3ZL5sLo3Y1vXgxv36OK5rS+YN9e+GFjLxQtUOejhtevD5DI+3yQdmT9bkcdG0ggBodZKSFfPIwrf4N05wO3mN9E6hu64tyi8H22BpHswbMhRQeJ80llOxqak2W4NahyFrFkD/VaNFXJ0gL1Ap/H9FE6qAvnQNnFlpiTb4m1l9ECkgK2OBfJ0pH9dyRykXSwIibv8UD+uPRLhdhDf0u5HbN4la7Dq/oLZ9RrellYu64oQ6rGEn/fL54BzoIi+XZ549XvSdgS2gSCV91GgA8yjU2qKxMgAM3Qo0g==; s=purelymail3; d=purelymail.com; v=1; bh=6QDduj8PmMzbiroxxRDhs4FIRHnCb1q9Cm5MUNPqd2Y=; h=Feedback-ID:Received:Subject:From:To:Date; Feedback-ID: 8937:2070:null:purelymail X-Pm-Original-To: 72457@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2058625093; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 17 Sep 2024 22:20:07 +0000 (UTC) Message-ID: Date: Tue, 17 Sep 2024 17:20:05 -0500 In-Reply-To: References: Organization: Dissociation for Heresiographal Computation Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lilah Tascheter via Guix-patches Reply-To: Lilah Tascheter Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -7.00 X-Migadu-Queue-Id: E16CD1EB99 X-Spam-Score: -7.00 X-TUID: XkPOfDVvb5C3 > I dislike that so few patches change from revision to revision, > according to the diffstat. yeah, didn't feel the best to have to re-send the whole series for each small change. > I would like to submit a rewritten patch series.=C2=A0 Basically, it woul= d > consist of patches #4, #6, #12, #13, and #14. since efi's getting split out, would it make sense to split #6 out too? though, that could pose issues if it gets forgotten and the others get merged. your choice! > I want to submit #1, #2, #3, #5 and #15 to issue #73202 so, #73202'd end up being a general cleanup of the current bootloader system, right? I feel #2 wouldn't quite fit there, seeing as it just adds the infastructure needed for #4. > #7, #8, #9, #10 (excl. efibootmgr) and #11 to #68524. I'll send an unmerge to #68524 then! > Parts of patch #4 which fit better with #73202 or function standalone > would be submitted to #73202.=C2=A0 Finally, #4 will be split into seven > to ten patches, hopefully making referring to changes easier and > review less demanding. this sounds great! but, good fucking luck splitting up #4. a ton of the changes are interconnected, and it'll be a pain to do so if you don't want some commits to just not compile. if you can pull it off, that'd be amazing! > [1]: https://codeberg.org/herman_rimm/guix typo in gnu/build/bootloader.scm "thtat", also gnu/system/install.scm(embedded-installation-os) operating-system- bootloader's default is '(), not #f. otherwise, this looks great!!! I'm also thinking now, since you mentioned the operating-system- bootloader sanitizer in a previous email, it'd probably be a good idea to expand the sanitizer to detect for 'part type targets too. a simple /dev/.*[0-9] regex should work well? I can write a quick patch up for you, or you can just include that when making the new patch series if you'd prefer? > [2]: ... looks like the failure here was caused by cpan failing to build, which shouldn't be (hopefully isn't) a result of this patchset. what does the build log mentioned say? thanks so much for all the help, by the way :) - lilah