all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 65879@debbugs.gnu.org
Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com
Subject: [bug#65879] [PATCH gnome-team v4 0/2] Commit style update − still failing
Date: Sun, 17 Sep 2023 18:23:23 +0200	[thread overview]
Message-ID: <acc0190100e020f62585fffe291c86cbca0e14e7.camel@gmail.com> (raw)
In-Reply-To: <cover.1694959943.git.vivien@planete-kraus.eu>

Am Sonntag, dem 17.09.2023 um 16:12 +0200 schrieb Vivien Kraus:
> Hi!
> 
> I split the patch in 2, first to add the patch, and then to do the
> update. Is it better that way?
> 
> > I wonder what's this about the firmware security panel :)
> 
> I’m sorry for messing up the commit style. You made the charitable
> assumption that there was something more than my negligence here, but
> unfortunately I’m just to blame.
It's fine – two patches or one both work.  Sorry for being a little
cheeky in my review.

> > The biggest issue that keeps me from pushing this is the reported
> > crash; we should be able to at least somehow get a working
> > gnome-control-center even if it means spawning an extra dbus
> > session from a pure shell or something.
> > If you can resolve this by testing in qemu, then fine, but until
> > you do, let's keep this on the wait list :)
> 
> I keep the gnome-shell idea in mind too. Anyway, I’ll wait for CI to
> rebuild qemu once it is merged.
Note, qemu builds locally even with the first patch removed, so I'll
push that next weekend.

Happy hacking in the meantime!




  parent reply	other threads:[~2023-09-17 16:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 21:31 [bug#65879] [gnome-team 0/1] Update gnome-control-center Vivien Kraus via Guix-patches via
2023-09-11 21:26 ` [bug#65879] [gnome-team 1/1] gnu: gnome-control-center: Update to 44.3 Vivien Kraus via Guix-patches via
2023-09-12  4:15   ` Liliana Marie Prikler
2023-09-12 10:03     ` Vivien Kraus via Guix-patches via
2023-09-12 18:25       ` Liliana Marie Prikler
2023-09-12 19:00         ` [bug#65879] [gnome-team v2 0/1] Still failing: Updage gnome-control-center and disable the firmware security panel Vivien Kraus via Guix-patches via
2023-09-11 21:26           ` [bug#65879] [gnome-team v2 1/1] gnu: gnome-control-center: Update to 44.3 Vivien Kraus via Guix-patches via
2023-09-12 20:41           ` [bug#65879] [gnome-team v2 0/1] Still failing: Updage gnome-control-center and disable the firmware security panel Liliana Marie Prikler
2023-09-12 22:31             ` Vivien Kraus via Guix-patches via
2023-09-15 22:13             ` Vivien Kraus via Guix-patches via
2023-09-16  4:02               ` Liliana Marie Prikler
2023-09-17 12:56                 ` [bug#65879] [PATCH gnome-team v3 0/1] Gnome-control-center passes all tests, but still crashes Vivien Kraus via Guix-patches via
2023-09-11 21:26                   ` [bug#65879] [PATCH gnome-team v3 1/1] gnu: gnome-control-center: Update to 44.3 Vivien Kraus via Guix-patches via
2023-09-17 13:37                     ` Liliana Marie Prikler
2023-09-17 14:12                       ` [bug#65879] [PATCH gnome-team v4 0/2] Commit style update − still failing Vivien Kraus via Guix-patches via
2023-09-11 21:26                         ` [bug#65879] [PATCH gnome-team v4 2/2] gnu: gnome-control-center: Update to 44.3 Vivien Kraus via Guix-patches via
2023-10-09 20:38                           ` bug#65879: " Liliana Marie Prikler
2023-09-17 14:08                         ` [bug#65879] [PATCH gnome-team v4 1/2] gnu: gnome-control-center: Add gnome-control-center-firmware-security.patch Vivien Kraus via Guix-patches via
2023-09-17 16:23                         ` Liliana Marie Prikler [this message]
2023-10-08 12:04 ` [bug#65879] [gnome-team 0/1] Update gnome-control-center Vivien Kraus via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acc0190100e020f62585fffe291c86cbca0e14e7.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=65879@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.