all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: antlers via Guix-patches via <guix-patches@gnu.org>
To: zimon.toutoune@gmail.com, 68163@debbugs.gnu.org
Cc: dev@jpoiret.xyz, othacehe@gnu.org,
	"Ludovic Courtès" <ludo@gnu.org>,
	me@tobias.gr, rekado@elephly.net, guix@cbaines.net
Subject: [bug#68163] [PATCH] gnu: Prevent stale cache use when `%package-module-path' is parameterized.
Date: Wed, 17 Jan 2024 00:32:39 -0800	[thread overview]
Message-ID: <ac191eec-887e-4e96-bc65-09b0917389c4@app.fastmail.com> (raw)
In-Reply-To: <4bc21e5a-dccb-4427-9ad4-2225ce132d39@app.fastmail.com>

Updates:

> I don't know if a.) there's any cause to be concerned about the
> performance of this tweak, or b.) that you care to support the
> behavior at all, but I hope I've made my own use-case clear and the
> patch is there if you see fit c:

a.) I glued hyperfine to a pair of guix repl endpoints, scaled up until I hit segfaults, no difference
b.) Maybe `specification->package' just has some particular notion of what's "current", like "current-channels" does, in which case we can rule out complacence with the parameter as a non-feature-- but I certainly isn't the same notion.
c.) I had the bright idea to set GUIX_PACKAGE_PATH at build time, first on the command-line and then in the channel modules, but it didn't work out-- felt silly for a minute there. Hey, how do third party channels usually resolve `search-path'? Isn't that the same thing, packages and patches in the same repo? Or are they just expected to use `local-file' and relative paths? I'll look into this another time.

If B or C had come to fruition I'd have closed the issue with 'em, and something like B is up for interpretation-- I don't mind either way (happy to carry the patch on my own). But if I enjoy these instances of syntax-sugar in my own channels (which I do :p), and if the Guix repo utilizes + is cleaner for them as well, then I figure it'd be a shame (barring a solution like C) to interpret the implementation as one which excludes other channels.




      reply	other threads:[~2024-01-17  8:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31  6:06 [bug#68163] [PATCH] gnu: Prevent stale cache use when `%package-module-path' is parameterized antlers via Guix-patches via
2024-01-08 17:06 ` Ludovic Courtès
2024-01-08 23:04   ` antlers via Guix-patches via
2024-01-08 23:56     ` antlers via Guix-patches via
2024-01-11 18:24 ` Simon Tournier
2024-01-13  0:23   ` antlers via Guix-patches via
2024-01-13  4:41     ` antlers via Guix-patches via
2024-01-17  8:32       ` antlers via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac191eec-887e-4e96-bc65-09b0917389c4@app.fastmail.com \
    --to=guix-patches@gnu.org \
    --cc=68163@debbugs.gnu.org \
    --cc=antlers@illucid.net \
    --cc=dev@jpoiret.xyz \
    --cc=guix@cbaines.net \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=rekado@elephly.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.