From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8OhlNKPckGLxYwAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 16:13:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8ABiNKPckGJzPwAA9RJhRA (envelope-from ) for ; Fri, 27 May 2022 16:13:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E18D2E2C2 for ; Fri, 27 May 2022 16:13:54 +0200 (CEST) Received: from localhost ([::1]:53008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuaiu-0002C3-3x for larch@yhetil.org; Fri, 27 May 2022 10:13:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuaYR-0005TB-5d for guix-patches@gnu.org; Fri, 27 May 2022 10:03:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuaYP-00021Z-Qw for guix-patches@gnu.org; Fri, 27 May 2022 10:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuaYP-00040M-Oe for guix-patches@gnu.org; Fri, 27 May 2022 10:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.165366016615373 (code B ref 55673); Fri, 27 May 2022 14:03:01 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 14:02:46 +0000 Received: from localhost ([127.0.0.1]:35531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuaY9-0003zt-OS for submit@debbugs.gnu.org; Fri, 27 May 2022 10:02:45 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:55300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuaY7-0003zh-76 for 55673@debbugs.gnu.org; Fri, 27 May 2022 10:02:44 -0400 Received: from [172.20.10.5] ([188.188.246.167]) by michel.telenet-ops.be with bizsmtp id bq2g270023dS87Q06q2geG; Fri, 27 May 2022 16:02:41 +0200 Message-ID: From: Maxime Devos Date: Fri, 27 May 2022 16:02:29 +0200 In-Reply-To: References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be> <02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fxBjGupYufBB3okcZz5B" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1653660161; bh=9SXbu5+8idzcy6lvQoNSWInju/hjfU/2QmsdE/YYRVQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=EZYHkq3z1Lt/SYu/kocZnJpxfPTph+jteRtYTeX1DN91jVPFnQGrMfj9QNBSo59ih +knw5S8XVeZQ4lC4I7kB03oN7utd0Vp1oQJ8jRkeKaNHOcJxKtsIouVUD9hEn9akjO mbZR3edBk/w9z/Ys/So6gr1OXVpxUaRWaAS4nYz3N1aEHF/L/G76dDuu2RmVOHmPba MZ/ctGjfVgUrNXNNT32ToMLV+oT+gYQVpk4stUjG1+rB6pAKh19A1BfdvqhsKTIRge Kr3QOcpl/SWMta/hhrBHOkvXJC1ZdpiQjxIaE6KXQFw++x7RW+fvmtIfXFuvmUOZAT dk0MLdGRMY6aw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653660834; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9SXbu5+8idzcy6lvQoNSWInju/hjfU/2QmsdE/YYRVQ=; b=UlgdtahB0i8gFHIyTpFEd386Cp6UShn1QwspzKDUEtDFkYXN9k341Hl2utkRMFs5rzzXFV 491PYNuWft2svE/76I+Dpe5E0IBM8zINsUm93NjkOoWrX9PE8N99GaSMXNOLspbNGfhl5Q BpY61NUeStRGdex5Z+Cdjs0U0f1EK+lIbQGujvl3IGq2VxEYOoZo/eaRj0uuncHY4gA0fR CGhxYpw12gPM1nrkznk2rpPXjCXAaGsQP3SRCdLqoDorcRDyXTK4OzXGcWDWB2RYK7W/n0 T4moNdlEyaXJEuFv4xiZsu9ua81DQK71CW6SxrTpwVad/ifFAdrgIhht8Q/kDQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653660834; a=rsa-sha256; cv=none; b=eQBYu0ZFxSlaXimMEezI2Dum+peKU4JdBGatyByrQynAnKSXs47NKtacOE9/SHDBUsBOPP 2dP7q2DyDdi/H4fAhybndM6Wnhkx4mDZpY79Y8CGAyWDtuvtOF8VxT2JHSZOVhBqu6HxfQ XQ4NS3reUP9xyEFs4DdvAqWiKRZG8rzNkpPM8xNyGZwxyH/UhAAQbZL4CwOc1fUwoQtV3K ZV6z+DyJw7oHIUoNfGKXVTZvwmOvtc+Qcx7SX8BXsbepxaT0Ru/ks3SobjyFEkEQz3ao4J qgwDXK1LPrEMsfI3GgJDc+/7jfgBYRFERD4wPvB/iHJrTtfTxsa2dGkGDQ00MQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=EZYHkq3z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.55 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=EZYHkq3z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7E18D2E2C2 X-Spam-Score: 2.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: hvGCSn25Nnb9 --=-fxBjGupYufBB3okcZz5B Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > The difference is that ^R is interpreted as a symbol, whereas "foo > > cannot be interpreted as anything at all by 'read'. > I do not understand what you mean ^R is interpreted as a symbol: (symbol? (call-with-input-string "\x12" read)). "foo" is interpreted as a string: (string? (call-with-input-string "\"foo\"" read)) "foo without a terminating string cannot be interpreted at all: (call-with-input-string "\"foo" read) > and I think you are overengineering. It's not any more overengineering than catching not-an-integer IMO. AFAICT, this does not find the definition of overengineering I found on Wikipedia. Also, I do not understand the resistance -- I have a simple proposal for generalising your patch to more failure modes, with a demonstration and test case (see the file "a") on when it is necessary and a proposed implementation. zimoun schreef op vr 27-05-2022 om 15:23 [+0200]: If you are able to produce a corrupted file which breaks "guix time-machine", then we can examine.=C2=A0 Else let move on. :-) I previously produced the corrupted file, see the file "a". I am not willing to deliberately corrupt my file system for this, especially when I can just give a synthetic example of corrupted file (see the file "a") and especially since making a synthetic example is much simpler and faster. Greetings, Maxime. --=-fxBjGupYufBB3okcZz5B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpDZ9RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7icOAPwPHcd5Z6PsdU6lw8lk7HcX1iFG kLtK37QV5tnJSMZYHwD+ObFnnfbUhNH1mxjxADTLaVFS/XZ6DoxyQHuB39vX6QI= =RLZx -----END PGP SIGNATURE----- --=-fxBjGupYufBB3okcZz5B--