From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: Add lrzip. Date: Thu, 21 Jul 2016 22:21:15 +0200 Message-ID: References: <20160720225413.2903-1-me@tobias.gr> <20160721002436.13651c1f@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQKTE-0008Dg-KS for guix-devel@gnu.org; Thu, 21 Jul 2016 16:21:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQKT9-0001hM-Fu for guix-devel@gnu.org; Thu, 21 Jul 2016 16:21:24 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQKT9-0001hH-8t for guix-devel@gnu.org; Thu, 21 Jul 2016 16:21:19 -0400 In-Reply-To: <20160721002436.13651c1f@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org Eric, Thanks for the review! On 2016-07-21 07:24, Eric Bavier wrote: > ASM support seems to be supported only on x86/32-bit systems. Could > you make this input conditional on the system type? An example would > be the "lame" package in gnu/packages/mp3.scm. And thank you for the specific pointers as well, they probably saved me a lot of time. Now, I decided to go for a slightly different approach that seemed more straightforward. The ‘lame’ example seems to be aimed more at the build architecture than the target's. My understanding of such intricacies is still quite limited so someone please double-check. Unless someone's using their Raspberry Pi to cross-compile for their i7, I suspect the difference is theoretical. >> + (inputs >> + `(("bzip2" ,bzip2) > > Configure checks for libbz2 and the build instruction mention it as a > requirement, but there are no references retained in the output and I > don't see any references to libbz2 in the Makefile's. Any ideas? I'm afraid you lost me here. $ grep lbz2 Makefile LIBS = -llzo2 -lbz2 -lz -lm -lpthread In fact, the ./configure check is (probably incorrectly) non-fatal so the build doesn't fail until you call ‘make’. Building with ‘bzip2’ results in a correctly statically-linked BZ2_bzBuffToBuffCompress(), so I don't see what other type of (input) this could be. Surely not native? That would totally break the i7 gal's build. > Could you send an updated patch? Will do! Kind regards, T G-R