From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +C4tKY4gGWBHBAAA0tVLHw (envelope-from ) for ; Tue, 02 Feb 2021 09:51:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kKapJI4gGWC1eAAAbx9fmQ (envelope-from ) for ; Tue, 02 Feb 2021 09:51:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 69D3F94042F for ; Tue, 2 Feb 2021 09:51:10 +0000 (UTC) Received: from localhost ([::1]:45620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6sKz-0007Fs-BC for larch@yhetil.org; Tue, 02 Feb 2021 04:51:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6sKs-0007FV-Jz for guix-patches@gnu.org; Tue, 02 Feb 2021 04:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6sKs-0002w9-CE for guix-patches@gnu.org; Tue, 02 Feb 2021 04:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6sKs-0007IZ-Ae for guix-patches@gnu.org; Tue, 02 Feb 2021 04:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45954] Telegram-CLI (v7/v8) Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Feb 2021 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45954 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 45954@debbugs.gnu.org Received: via spool by 45954-submit@debbugs.gnu.org id=B45954.161225946128053 (code B ref 45954); Tue, 02 Feb 2021 09:51:02 +0000 Received: (at 45954) by debbugs.gnu.org; 2 Feb 2021 09:51:01 +0000 Received: from localhost ([127.0.0.1]:34170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6sKr-0007IK-Jg for submit@debbugs.gnu.org; Tue, 02 Feb 2021 04:51:01 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:58454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6sKo-0007I7-BB for 45954@debbugs.gnu.org; Tue, 02 Feb 2021 04:51:00 -0500 Received: from nijino.local (217-149-173-242.nat.highway.telekom.at [217.149.173.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DVKnV4dTGz3w9M; Tue, 2 Feb 2021 10:50:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1612259454; bh=gjza/KFuaD1oGkB1BC5xuG0W2SvxPusCjutW0LunsdI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=HFEyfdQion1WQ20+tPHmyklvjf0A7u+t+oiT2VewrJwDZWks0jGVjO2cPwEEpHYjT DH0/yyvi9XDrILF8tYwK8Tk4JbnfIJDja53T4IptNSyKvWmU2TTARdHmgro+feQH68 /0oLWluP3+JWkulaO5osxyfsVT3txTUYQU60TP40= Message-ID: From: Leo Prikler Date: Tue, 02 Feb 2021 10:50:53 +0100 In-Reply-To: <596596fa-35d4-a7db-d890-153f51728780@raghavgururajan.name> References: <515542411e38fa921ef936fe116bd3e0fb2a44d1.camel@student.tugraz.at> <596596fa-35d4-a7db-d890-153f51728780@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=HFEyfdQi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 69D3F94042F X-Spam-Score: -1.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: sHZTV8mLwjSH Hi Raghav, Am Montag, den 01.02.2021, 21:33 -0500 schrieb Raghav Gururajan: > Hi Leo! > > > I didn't notice this before, but is there a reason to package this > > version over 1.3.1? > > Yeah, there are quite a lot of improvements after the 1.3.1 release. Anything particularly worth noting? > > Please stop trying to use this as a snippet to mean "the root of > > the > > source and build directory". It is extremely obscure and people > > are > > already using "../source" just fine. (Just do an rgrep if you > > aren't > > convinced.) > > Fixed in v8. "Fixed". While it is true, that you're no longer using getenv, binding source for string-append later on is not a particularly elegant solution either. > > > Hmm. I tried but couldn't come up with a way to do it like that. > > > :( > > You can still try harder for v8 ;) > > I tried different ways but the arguments key-words between gnu and > copy > differ a lot. I am unable use key-words from both build systems at > the > same time. Like using #:configure-flags (from gnu) and #:install > (from > copy). Use something along the lines of (replace 'install (lambda args (apply (assoc-ref copy:%standard-phases 'install) #:install-plan args))) Phases should be written in a way, that gratuitous arguments will not be read, but passing it in arguments through the package-arguments fields remains tricky. Though even if it were possible, the snippet above has better locality. > Also, I spent significant amount time to come up the phase I have. So > if > there are no critical issues, I would like to keep it as-is. :-) I personally regard readability as a severe issue in this case. Of course there would be ways of doing this without invoking copy-build- system, but in my personal opinion an install plan would likely be the most concise here. For instance instead of using string-append source everywhere, you could just use a directory excursion. But more importantly, why is it, that all of the stuff you're installing is located in the source directory? Do you even build anything that ends up in the installation? Would it make more sense to have #:out-of-source? #f? In tgl, you use several directory excursions when arguably only one would be needed. Try to simplify your install process, so that you need to bind as few variables as possible. Regards, Leo