From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6Pt7MUeBCWZncgAA62LTzQ:P1 (envelope-from ) for ; Sun, 31 Mar 2024 17:29:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 6Pt7MUeBCWZncgAA62LTzQ (envelope-from ) for ; Sun, 31 Mar 2024 17:29:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=u1kUpIM2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711898951; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=44T9o/1s8zNfvcewmoqaxyeMyPvB25d3J1iCe8EA3DU=; b=qXKSNkdnnEVPv6CvecumK7AOG9UWHM0E131aLlPgy5s6+ZVgHDzLx8EKiRXuI85w/E3PWo +iWiW9s65Y8w+ZfEKpq0Yl/0kt6gQtC80xAeRPuoRSdGoKeq9pute+D9WmzpYD6jTmaUSj qWxkRAa3MKXXtcqzRoxiTvBDd5p/1i6cXwXQVDzLjjp8IcE/Ss6mAaotcn6KuiSdrcUDSW h62PPLUHLQz17NRHF1Hq1NZUCWMsRrRh+DTYM3KQJ6FFf/xnpFdj3TPigY1q7BORrPLbja whutdXeKbZ8484cpgKJrtt4t2sQgSPCMRRO+8CzQvEB/S0nOzxcV3GHS8BHTsQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=u1kUpIM2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711898951; a=rsa-sha256; cv=none; b=hR3htJwFCs9jQIDONZc9uoQENyZ9Pro2wQ4cwL7AlVcSvCyQRkzo95j7tG70uuKqC7GZTJ 7WDKKAC97BzuD6IXlB7CbXxon+HDQHkrzio24E0vfqNFsr7qRlVAEVsgwgDpPVLSHLXE0n VWdJ1Lbmq7nCsWeTKMMoxRAIFR78AFaTP5orD1dbvQ27DM3QpgU1BcsyY4Q2H2/NctXQ5L 79pJJ8neQvGRu48X0sWnmJdoSrXiUGYK2tvuEcnnt9g+P9MH/VgdxGuUCY0tn2kNUUxndN gtGXcqVM+h2Yxf5PI4z2eBw8YSurMirxI3NQsOHjIE6HtgHaoVJICVhBrWRn9A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6834A8E69 for ; Sun, 31 Mar 2024 17:29:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqx7F-0006yF-Hw; Sun, 31 Mar 2024 11:29:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqx7D-0006y7-Pv for guix-patches@gnu.org; Sun, 31 Mar 2024 11:29:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqx7D-0000iZ-He for guix-patches@gnu.org; Sun, 31 Mar 2024 11:28:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqx7G-000058-3K for guix-patches@gnu.org; Sun, 31 Mar 2024 11:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70065] [PATCH 4/6] gnu: chez-scheme: Update to 10.0.0. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 31 Mar 2024 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70065 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 70065@debbugs.gnu.org Cc: Katherine Cox-Buday , Liliana Marie Prikler , Andrew Tropin Received: via spool by 70065-submit@debbugs.gnu.org id=B70065.171189893132762 (code B ref 70065); Sun, 31 Mar 2024 15:29:02 +0000 Received: (at 70065) by debbugs.gnu.org; 31 Mar 2024 15:28:51 +0000 Received: from localhost ([127.0.0.1]:48266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqx73-0008W9-FO for submit@debbugs.gnu.org; Sun, 31 Mar 2024 11:28:51 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:17939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqx70-0008VR-Hk for 70065@debbugs.gnu.org; Sun, 31 Mar 2024 11:28:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1711898916; x=1712158116; bh=44T9o/1s8zNfvcewmoqaxyeMyPvB25d3J1iCe8EA3DU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=u1kUpIM2l9X1cUGsD91kj0YJhcZOJvHvsUjQ7YR5BvpzsMpP4ZkwEx3IIexcKq+Bs KwQQr6L+lidFZ+QR180ihPsAHgyf8NvLh5m8On3QtZm1u+DcxvUbNg5noZmOw0N4Ft dTndQCfKeYxaVTmsbGJcJO0typrxM9vSo15mz1JIB6nkMmmp/r+3EsSfPKPkbkKQuv tqUa7qnjzB7qfMg9NyQDbt4PEYUB3feWWZ/9DcKR07cMMJrVcfXYyLDhef83BMGJUW pCMdN9OiMGDhmz/YttfJv7goCo5Ap++BYAj5O674IpQGh8f1qToUYyi3WSnTW2tP5o 5iIlbLbi/PPrQ== Date: Sun, 31 Mar 2024 15:28:29 +0000 Message-ID: In-Reply-To: References: <1f2ac17f-8095-41b7-a0c3-db6487d74aea@protonmail.com> Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 6834A8E69 X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -5.35 X-Spam-Score: -5.35 X-TUID: YfScSVKzvCLh Hi again! I stepped away from my desk to do something else and as often=20 happens the answer came to me. I'll include full steps to reproduce the=20 issue below, in order to build confidence in my explanation, but the=20 TLDR is that your definition is correct and it was a problem on my end.=20 Additionally, I confirmed that loko-scheme still builds and runs. I'll=20 keep this situation in mind for future reviews. Thank you for all your=20 hard work! Explanation: The loko.scm file was not recompiled so it searched chez.scm for a=20 variable named chez-scheme-for-system, which is now a syntax=20 transformer. But compiled files have already completed the expansion=20 phase, so this means that a syntax transformer is invalid. This will not=20 cause a problem for `guix pull` because guix rebuilds itself from=20 scratch when it gets updated. Reproduction: 1. Build the tree without patch 4/6 applied =C2=A0=C2=A0 `guix shell -D guix -CPW -- make` 2. Apply the patch =C2=A0=C2=A0 `git apply /path/to/patch` 3. Build the tree again =C2=A0=C2=A0 `guix shell -D guix -CPW -- make` 4. Try to build loko-scheme =C2=A0=C2=A0 `./pre-inst-env guix build loko-scheme` 5. Delete the compiled loko file =C2=A0=C2=A0 `rm gnu/packages/loko.go` 6. Build the tree again =C2=A0=C2=A0 `guix shell -D guix -CPW -- make` 7. Build loko-scheme =C2=A0=C2=A0 `./pre-inst-env guix build loko-scheme` On 3/31/24 07:35, Skyler Ferris wrote: > On 3/30/24 15:49, Philip McGrath wrote: >> I still don't understand why the deprecation definition isn't working. I >> expected the expansion at the repl, and (chez-scheme-for-system) >> expanded to (%chez-scheme-for-system/deprecated), which was defined by >> the expansion of define-deprecated as: >> >> =C2=A0=C2=A0=C2=A0 (define %chez-scheme-for-system/deprecated >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (begin >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda () chez-scheme) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda* (#:optional (system = #f)) chez-scheme))) >> >> I guess, unless I figure something out or someone has a better >> suggestion, I could just remove chez-scheme-for-system without >> deprecation, but that seemed less friendly. > > So, I started poking at this and ran into something strange. I removed=20 > the surrounding parentheses from chez-scheme-for-system in loko.scm,=20 > and it gave me the expected error about an invalid package, where the=20 > value was a procedure rather than a package. Which sounds like what I=20 > would expect if it was working, except that it didn't work with the=20 > parentheses. Then, after adding the parentheses back it stopped giving=20 > me the error, even after running make again. > > I haven't worked with define-deprecated before. It's a macro, and I=20 > know that the guile compiler misses recompiling macro dependencies=20 > sometimes, so maybe it was a problem on my end with having mismatching=20 > build artifacts. I'll try a clean build with these patches and a=20 > simulated guix pull within the next couple of days (hopefully today),=20 > and if those both work then the definition is probably correct.... but=20 > I'd be more comfortable if we could explain exactly why that error=20 > occurred. I'll also look more at the definitions, but I think it will=20 > be a little difficult to be confident in any explanation if I can't=20 > reproduce the error. Here's the full error output, in case it's=20 > helpful to anyone: > > Backtrace: > In ice-9/boot-9.scm: > =C2=A0 1752:10 19 (with-exception-handler _ _ #:unwind? _ # _) > In guix/ui.scm: > =C2=A0=C2=A0=C2=A0 485:6 18 (_) > In guix/scripts/build.scm: > =C2=A0=C2=A0=C2=A0 711:5 17 (_) > In srfi/srfi-1.scm: > =C2=A0=C2=A0 673:15 16 (append-map # =E2=80=A6) > =C2=A0=C2=A0 586:17 15 (map1 ("x86_64-linux")) > In guix/scripts/build.scm: > =C2=A0=C2=A0 713:21 14 (_ _) > In guix/store.scm: > =C2=A0 1382:11 13 (map/accumulate-builds # =E2=80=A6) > =C2=A0=C2=A0 1300:8 12 (call-with-build-handler # =E2=80=A6) > In guix/scripts/build.scm: > =C2=A0=C2=A0 667:16 11 (_ #) > =C2=A0=C2=A0 656:24 10 (_ # =E2=80=A6) > In guix/packages.scm: > =C2=A0 1378:17=C2=A0 9 (supported-package? # =E2=80=A6) > In guix/memoization.scm: > =C2=A0=C2=A0=C2=A0 101:0=C2=A0 8 (_ # # =E2=80=A6) > In guix/packages.scm: > =C2=A0 1356:39=C2=A0 7 (_) > =C2=A0 1618:16=C2=A0 6 (package->bag _ _ _ #:graft? _) > =C2=A0 1722:47=C2=A0 5 (thunk) > In gnu/packages/loko.scm: > =C2=A0=C2=A0=C2=A0 77:11=C2=A0 4 (native-inputs #) > =C2=A0=C2=A0=C2=A0 77:11=C2=A0 3 (native-inputs _) > In ice-9/boot-9.scm: > =C2=A0 1685:16=C2=A0 2 (raise-exception _ #:continuable? _) > =C2=A0 1685:16=C2=A0 1 (raise-exception _ #:continuable? _) > =C2=A0 1685:16=C2=A0 0 (raise-exception _ #:continuable? _) > > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > Wrong type to apply: # >