From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KAv3FhV2VWUJKAEAauVa8A:P1 (envelope-from ) for ; Thu, 16 Nov 2023 02:53:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KAv3FhV2VWUJKAEAauVa8A (envelope-from ) for ; Thu, 16 Nov 2023 02:53:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B301D5FEB9 for ; Thu, 16 Nov 2023 02:53:24 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=VEcGcuMk; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="v yQM8+N"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700099605; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=8DyiNTeUn5M2pxv3P7AVGCI9jYcvtX48uIlOBeNF+X0=; b=QeigMpJHWNpDFKUxSgSA/yqH4lCTdd1Ted2bEiVbg/E8nArL0Zn216+Q4A73T/FEaivPu8 4+28WtuOlSbHXsY7S8Ee/rPo/RYrZ6Gqu5yYL3eQan2dlchgc0m1t55kOzhQ4hkhWAaALk /MFMrRSePW/aJklGJdx0IJut8GyF9PZXKyTwGc7Yz1l7OeVQgLhmwY51OAcp3o4qRLXsd4 cnStAlS8UZyvdNeLrVlSwxHHMvp6KRqmh1M4mscFbXJ8WHfgpJLFoRa0ob8KMwUjbFibY/ yiyBPJfmzmBNUy8ft0Q+GPKMD2TONpch3M+512h5uxjxBhqgoZeq+fBDr/huFg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=VEcGcuMk; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="v yQM8+N"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700099605; a=rsa-sha256; cv=none; b=uamdE8hkU7y2jiOyhhAJScxnTo1Ji6TclZap9N0WO9WIytihsCZ9KDqKEVLLJJJHBTomC1 CiBVqTTnR0PGJm5jEor+lozLAuI7IZTG+h3qjA1V4DtUbInbsSHwJvkVPiuILjDcr+yh9H lc/SkrIRED2V5x/vm2PAElvlzG2g/uw7hDgJNKyucaKGqtQyquNzgiwGHBMVTBY6MsNDqF uA9nN0gC63tEZHetEgg4mNjg/jV1SuCwjQ64elivd08Y9tBv8+yMVE3LRCS/4LkcQihn7H /bd7mPSQb+dxsLRWaFDEpWvFh8h23UorTx1zlGvjqx5XGH0pengWObQZI6+E4w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3RZ6-0000fP-AO; Wed, 15 Nov 2023 20:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3RZ2-0000f8-8l for guix-patches@gnu.org; Wed, 15 Nov 2023 20:53:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3RZ0-0007QV-UO for guix-patches@gnu.org; Wed, 15 Nov 2023 20:53:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3RZ0-0000yC-09 for guix-patches@gnu.org; Wed, 15 Nov 2023 20:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67019] [PATCH 03/16] gnu: Add lessc. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Nov 2023 01:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67019 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 67019@debbugs.gnu.org Received: via spool by 67019-submit@debbugs.gnu.org id=B67019.17000995243650 (code B ref 67019); Thu, 16 Nov 2023 01:53:01 +0000 Received: (at 67019) by debbugs.gnu.org; 16 Nov 2023 01:52:04 +0000 Received: from localhost ([127.0.0.1]:54245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3RY4-0000wn-31 for submit@debbugs.gnu.org; Wed, 15 Nov 2023 20:52:04 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:42367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3RXy-0000wF-1x for 67019@debbugs.gnu.org; Wed, 15 Nov 2023 20:52:02 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 64F96320098B; Wed, 15 Nov 2023 20:51:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 15 Nov 2023 20:51:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1700099511; x=1700185911; bh=8DyiNTeUn5 M2pxv3P7AVGCI9jYcvtX48uIlOBeNF+X0=; b=VEcGcuMkZN7me8S3OmBgo6frR1 E5CJ+nsJ68ECMvmQedxJdSobPC8qy7k9cHKCDriNi+v2l7G8rGeKpcVgCfo3+egu iOETvuiUcLrQQkoRvVlAVvRNW2bsCg44msOFfQsOL9K5wUkTrfgl3nlK4dtLXVKg 4eVmCKESTV3xdA0WrUC2APIoV4VjqSlVdBN8eLKn4u39GLXjcJ5OYMFzN5U4NKHG FQnTZucaxK47ZvRHGPLIuXrlO9MknMqZIy4H2jVFyVWsevIolwyJk7nu3p8XJeMX s01NBMjqwAp13asUMDhwv/XMDlUDS+anM9k8Amiu4ifyGc4T0i7AAusMotIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700099511; x= 1700185911; bh=8DyiNTeUn5M2pxv3P7AVGCI9jYcvtX48uIlOBeNF+X0=; b=v yQM8+NS+FQv2TxC5kXq8On3G73KejXUrrbFzoAWN66CK4uzYYg52Q/BU4tNhXArH gdRDix3/Q/B9h5em13R3TLAvERQWZWJwMneKrcKAgxDyjyTxyyqCWd7Md4fowfq1 SeXU/5YFiZ1EGohQbqrvHEpyaIgN4TDMke3BTegqRYEmAxbxg36EZsjhx4vwZxKv qXOdt6akLfO3WYHbmpretbhFPTUBIgtn9QqU67dW5sbr0VzlKjIIxQxrQl9ZIZQl v01E0dNuVEwNja5wR6kV+evaul/SAyKz4UQzHt02bdhOsyI9eK6g0LNdIs/FMcQB QFA+ErroX58RFwgGaug6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefjedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttddvjeenucfhrhhomheprfhhihhl ihhpucfotgfirhgrthhhuceophhhihhlihhpsehphhhilhhiphhmtghgrhgrthhhrdgtoh hmqeenucggtffrrghtthgvrhhnpedvieekfffgtdeiiedtjeejjeffvefghfdtvddvleel udejhfevuddttedugfejfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehphhhilhhiphesphhhihhlihhpmhgtghhrrghthhdrtghomh X-ME-Proxy: Feedback-ID: i2b1146f3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Nov 2023 20:51:51 -0500 (EST) Message-ID: Date: Wed, 15 Nov 2023 20:51:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: <522f4e2a30c81dc738096bac21f46be50ddd8563.camel@gmail.com> <13a1da53-4273-4ebf-aa58-4c23d1f5a641@philipmcgrath.com> <4d72986a039c897ba8a91c34fc1d9b7ef16d49dc.camel@gmail.com> From: Philip McGrath Autocrypt: addr=philip@philipmcgrath.com; keydata= xsFNBFxfDXMBEAC50KOX7FVfbH5kzv1IWAu58hz77HfgH46izt8+3X51/AzD0QsrVnzz3fS0 37e5wnB4hpT/a6iGPbaah02nOhrCWjllWQrnp7rb0q9w8rnA41W5Aeajsob3/mPlSTkgX77/ nfXHFSaIPi+6DseAQO6EMbQrA/Ue4Yal/LWaAcpmGeAXUQabvH1I7LY5f6RI/pMii5cVmqm/ ea/oVroVeT4lBLh/1jEKv+tCVn1h9ks5L5AcbumaenEjgtJZ22/WUNowLD21uug7WCHlVdf+ 3PKSg/Hd7jotxYrfbhIEH2494KnenslxX4psavsH/AAWWTouvdiY5Q2d7eDH6P6ggWa1fXgs LlxFgtTTOmNTKViBKYk/g6gE2DpTaNG2pPqblxVlgy751O9y5UTBET0zj75BY55dKzoKg541 hBwKuwhNj0fA3xKesYzs2VdrzredEHegPeucQfTBSQ0G8lNdofElyv1e92rJtkAJXpodwNJf gmfJpdP33PPd1a7WQwWbo96JAkTkYnisEQyvJbQ8AvJw7V9xY79/pd2dXJkz88HZP486UiSK RmO9kItVSjCYz2Tqv75aZocpC661fv66GuLZfOCR1I0nbXNFxNs6K3/otJ3ignDFJCD4wk6j TlSODDeeXxDJtyBBrnYIzgb86KI3RJxoKrfbos0oavfWA2NGpwARAQABzSlQaGlsaXAgTWNH cmF0aCA8cGhpbGlwQHBoaWxpcG1jZ3JhdGguY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBPRlq6zWN66sFBVVz8oDY436Pxx6BQJkZmCHBQkJlXgUAAoJEMoD Y436Pxx6JvoQAKufvt1nAdezaIj+LccaKMOCNnVFxXBIDyaU9+Gmqh1ANQGLpdljfFmecpWm 1SA3sqDZapF2zg/hMHWbDGvdHJnPbtfnfS7ZZtOpdgRtMpE4zVeSi4t2NcIV0wQiPBXZhR0O Qp2PCMsExunJ0DV1pPMEt5r825haNPXZErSM3ectFgJwxjxEeOZ7khmrVrWZe0OddSsEEQsn 9jxpftLRgE/6N31wDuM/BDIrz+6AOc98zKFIoMmv8z9p1EEOvoFs7WunJklpWq6W4FggIPT0 UxlycFQBxzpVj2ga6MZVZ8Sp2fq0jgKn3uubYySyNi8SE6PfSre+QIG54OA+j9NSiVi36um7 Z4nqRC6JPoBe2VTwaZLskeO4grYHKFZHKVyOk3jcvDY5R8uyh+hPPj5kvYS34YFESZf+5LTA HoYmaOY8YGEqH66p9ukYbXaAoH9lmQig0zVcyyE9o8OuKhkvksiJ+2pEYtWXOkVqvj18xlfQ mLfhlWYo/o42x975zACjrZQe5+ZdQS9sz7ietWrHbZ9+hl79iSfeVkNvMikdZ5CZ81YvF42z kpDr6vWc2ImxIpgCTRp5HAUtKVsUJE/+yJop+AeVMonzzGaFd5tG/aT5BOz3w6ua3WfXqA9b NpeO4ANi2IQrhhWNq26JWx3Yx/QgxrNm44skIzuEEyL3b6Q7zsFNBFxfDXMBEADq/Vlop4lx W9Bi7cYaxjnhNMbDxR3aVV3GMy7zkuV3fGjvTAuO7raDoqN91y2bvm+vkM54Mw+Fu3ThBHCc niYkdgyIlpLNfFhQOOBtlj1jNmCGTOp7JBJ8mjQucOGy3A0uUaqvkMncO2trsfEsRD25nTZV dji4cHePP86Uc/w98OBt5cPLyM5/WU+GTpPBATFc1u4DocMSqbCZcNLDr1O7P6Knl8vsCtRj r4X4xp3d3I+aZ1h5l/Hu20u+/7fg8PO/WDOCMwqN64xB2OHLv7bQm0piwVN+Gkyjhk9EJINO m05ieGxvsyAaQDMkgvm/Hp1G2LJEWkxaTalnBawaVYM4TgpE5hU9gda3Ld/pdT2lkNmVq47v d//NBYWa1/aJGqBP2XlW0JMywmDEVH2fFwVqMQ3ZzE+N4HnSR6Uslv4DpIeYLGevheHLqegO o5VySo/P+lGQDO0vSHbBZgRJ/ROwNvkJVEQ9pI34Edt2zCfUYqjUU+3tcd2xgR8/JP2dnjYp NDq4CK/8ywk+sl8WY8MQpKccJdWp0CVgp2y88YALn6x9wxsPGQ8Lk7sB4ADwwPX87pFdJqe2 2oKgG9HklBTSxvdr1fN+/n4AD5XPBhMpi9UZHdaVuWzVfXU6EKMHlsJfJ7sF1atKVPcQDIN/ SxwTlxmsHVCMxifikklhQwmD/wARAQABwsF8BBgBCAAmAhsMFiEE9GWrrNY3rqwUFVXPygNj jfo/HHoFAmNsLkkFCQmC/B0ACgkQygNjjfo/HHrGqxAAgdV2GRCEIJwbLtRTv4qpfANsfX/I S0KZBDbwtZuCDceQTfsS8lF5WGJOPxF7MDkVGRhBPYpVamO56V+Y/o6drX0JEeWqLwB3nc8b PFpFcGTFOxp6Q1Ps4n/L/+hhTsI4vO79jsf97s7GPhSLpnzakb2Enh25G/MoToj6qQvuuqFW lDX1hxBC9Jf6pnuX1XGUik9LZVpuqf9suVgNa4Wf6ZverzphPWObXifpjVREk7jJ0g2OBGZz CATDfgEfu4OtV2JEeSrPZeFoHPQzsFfO/n99ZxBWVLbiXJgNTnU/vwbPkMpPjED3WSwTesW+ SgXfZf4KHFigC3Z34uhXfxn4I1XEW7UGgbtsrFqJI+WVzP2mUeOzNoz980N1tfowzoNShfKD rcDhtpyZZcaA+0O1oVSKs3LUT4QNiYl/lcg4l0qnBvj+ilG3ViXikhKn4RMJUppbXCx09ZBK Pz1PAvig0mnpCWCjizdbtuFzkZsLmfYjIbxkXBLMmQdqMgqUnsUGvUh0u+v5zQlc3IQnpLBt vkQuitsVuqkCKSILz8p2DyA6PWRI988fGPakjvV13iGwAIfFPsNvOoWsVLz3GT6f9chF4fAY JuOem41lA82RZB9fPty0S8YVavucU7qzTfHRj6LwvrWzLk6wRA7ThPHWVAZsyH1iYO+nUOsU FFu7icw= In-Reply-To: <4d72986a039c897ba8a91c34fc1d9b7ef16d49dc.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.18 X-Spam-Score: -2.18 X-Migadu-Queue-Id: B301D5FEB9 X-Migadu-Scanner: mx10.migadu.com X-TUID: NrH5wcjMXu7G Hi, On 11/15/23 20:17, Liliana Marie Prikler wrote: > Hi, > > Am Mittwoch, dem 15.11.2023 um 19:03 -0500 schrieb Philip McGrath: >> Hi, >> >> On 11/15/23 15:23, Liliana Marie Prikler wrote: >>> Am Mittwoch, dem 15.11.2023 um 14:35 -0500 schrieb Philip McGrath: >>>> [...] >>>> >>>> To clarify, do you mean vertical or horizontal? >>> I do mean horizontal. >>> >>> [...] >>  > >>>> >>>> I could also imagine breaking these lines: >>>> >>>>   >> +                           (("scripts" @ . alist) >>>>   >> +                            `("scripts" @ ,@(map (match- >>>> lambda >>>> >>>> instead as: >>>> >>>>   >> +                           (("scripts" >>>>   >> +                             @ . alist) >>>>   >> +                            `("scripts" >>>>   >> +                              @ ,@(map (match-lambda >>>> >>>> but that doesn't seem like much of an improvement to me. >>> But what about breaking lines before (match-lambda?  That ought to >>> at least give us enough to get (_ #f) onto a single line, no? >>> >> >> Maybe I'm confused: there isn't (_ #f) anywhere. > There was a (_ #t) in the filter, though :) > In any case, such trivial matches should fit onto one line imho. > >> There is currently enough space to put (other other) on a single >> line, but I thought it was better style to put a newline between the >> match pattern and the expression, especially when the pattern is not >> _. > IMHO, this only makes sense for non-trivial replacements. If you keep > some piece of data as-is, you more often than not don't want to draw > attention to this implementation detail by blowing up its size. > I don't think the content of the right-hand side is relevant: in my view, the purpose of the newline is to make the shape of the clause clear, especially given that the left-hand side is not an expression. The fact that Guix's style forbids square brackets makes the newline even more necessary, IMO. In any case, what arrangement of whitespace in patch-build-script would unblock this patch series for you? >> >> Using delete in do-not-target-es5 does seem like a minor improvement: >> >>>           (add-after 'avoid-parse-node-version 'do-not-target-es5 >>>             (lambda args >>>               ;; esbuild can't compile all features to ES5 >>>               (with-atomic-json-file-replacement "tsconfig.json" >>>                 (match-lambda >>>                   (('@ . alist) >>>                    (cons '@ >>>                     (map (match-lambda >>>                            (("compilerOptions" '@ . alist) >>>                             `("scripts" @ ,@(delete '("target" >>> "ES5") >>>                                                     alist))) >>>                            (other >>>                             other)) >>>                          alist))))))) > Fun fact, you could inline this delete into the "compilerOptions" line > – or sexp at least, by using (= (cute delete '("target" "ES5") <>) > options). That being said, it's not necessary to do so; the delete you > currently have works fine. > > Anyhow, since this isn't a clean alist, I'd use a different variable > name, perhaps "options"? > All of the variables named alist are, in fact, alists. I noticed, though, that this was inadvertently renaming "compilerOptions" to "scripts" and thus effectively patching out all the other options, too: things seemed to work regardless, but here's a correct version: > (add-after 'avoid-parse-node-version 'do-not-target-es5 > (lambda args > ;; esbuild can't compile all features to ES5 > (with-atomic-json-file-replacement "tsconfig.json" > (match-lambda > (('@ . alist) > (cons '@ > (map (match-lambda > (("compilerOptions" '@ . alist) > `("compilerOptions" @ ,@(delete '("target" . "ES5") > alist))) > (other > other)) > alist))))))) Philip