bug#26637: [PATCH] gnu: Add gcompris-qt.

bug#26637: [PATCH] gnu: Add gcompris-qt.

[Glenn Morris]

Report reassigned to guix-patches.

If you want to report bugs by bcc (?), you must specify a Package: in
the first line of the body.

Efraim Flashner wrote:

> * gnu/packages/education.scm (gcompris-qt): New variable.
> ---
>  gnu/packages/education.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm
> index 808be203c..797fe69f6 100644
> --- a/gnu/packages/education.scm
> +++ b/gnu/packages/education.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright © 2016 Danny Milosavljevic <dannym@scratchpost.org>
>  ;;; Copyright © 2016, 2017 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
> +;;; Copyright © 2017 Efraim Flashner <efraim@flashner.co.il>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,6 +29,7 @@
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages kde-frameworks) ; extra-cmake-modules
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages python)
> @@ -102,6 +104,47 @@ of categories with some of the activities available in that category.
>  ")
>      (license license:gpl3+)))
>  
> +(define-public gcompris-qt
> +  (package
> +    (name "gcompris-qt")
> +    (version "0.70")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "http://gcompris.net/download/qt/src/gcompris-qt-"
> +               version ".tar.xz"))
> +        (sha256
> +         (base32
> +          "01r7i8dmwb2nlfyp0y0mzs8yydmvn5gq7xn1w7g21lysak1mliwa"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:configure-flags (list "-DQML_BOX2D_MODULE=disabled")
> +       #:tests? #f)) ; no test target
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("gettext" ,gettext-minimal)
> +       ("perl" ,perl)))
> +    (inputs
> +     `(("python-2" ,python-2)
> +       ("qt" ,qt)))
> +    (home-page "http://gcompris.net/index-en.html")
> +    (synopsis "Educational games for small children")
> +    (description
> +     "A large collection of educational games for small children, designed to be
> +a unified interface to integrate more educational games.  Language-oriented
> +games contain vocabulary, sounds, and voices for many different languages.
> +Currently available boards include:
> +@enumerate
> +@item learning how to use a mouse and keyboard
> +@item learning simple arithmetic
> +@item learning how to read an analog clock
> +@item recognize letters after hearing their names
> +@item reading practice
> +@item small games (memory games, jigsaw puzzles, ...)
> +@end enumerate\n")
> +    (license license:gpl3+)))
> +
>  (define-public tipp10
>    (package
>      (name "tipp10")

bug#26637: [PATCH] gnu: Add gcompris-qt.

[Thomas Danckaert]

Hi!

> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("gettext" ,gettext-minimal)
> +       ("perl" ,perl)))
> +    (inputs
> +     `(("python-2" ,python-2)
> +       ("qt" ,qt)))

*This time also replying to debbugs*

I think it's nicer to use the modular qt packages if possible?  I
checked and it compiles with the following inputs:

    (native-inputs
     `(("extra-cmake-modules" ,extra-cmake-modules)
       ("gettext" ,gettext-minimal)
       ("perl" ,perl)
       ("qttools" ,qttools)))
    (inputs
     `(("python-2" ,python-2)
       ("qtbase" ,qtbase)
       ("qtdeclarative" ,qtdeclarative)
       ("qtmultimedia" ,qtmultimedia)
       ("qtsvg" ,qtsvg)
       ("qtxmlpatterns" ,qtxmlpatterns)
       ("qtsensors" ,qtsensors)))

otherwise LGTM!

Thomas

bug#26637: [PATCH] gnu: Add gcompris-qt.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 213 bytes --]


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #1.2: Type: message/rfc822, Size: 3461 bytes --]

[-- Attachment #1.2.1.1: Type: text/plain, Size: 1808 bytes --]

On Fri, Apr 28, 2017 at 11:37:19AM +0200, Thomas Danckaert wrote:
> Hi!
> 
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > * gnu/packages/education.scm (gcompris-qt): New variable.
> > ---
> > 
> > [...]
> > 
> > +    (inputs
> > +     `(("python-2" ,python-2)
> > +       ("qt" ,qt)))
> 
> I think it's preferable to use the modular qt packages when possible.  I
> and the package builds with the following inputs:
> 
>     (native-inputs
>      `(("extra-cmake-modules" ,extra-cmake-modules)
>        ("gettext" ,gettext-minimal)
>        ("perl" ,perl)
>        ("qttools" ,qttools))) ; qtlinguist
>     (inputs
>      `(("python-2" ,python-2)
>        ("qtbase" ,qtbase)
>        ("qtdeclarative" ,qtdeclarative)
>        ("qtmultimedia" ,qtmultimedia)
>        ("qtsvg" ,qtsvg)
>        ("qtxmlpatterns" ,qtxmlpatterns)
>        ("qtsensors" ,qtsensors)))
> 
> Otherwise LGTM!
> 
> Thomas

here's what I have in my WIP area for later testing:

    (native-inputs
     `(("extra-cmake-modules" ,extra-cmake-modules)
       ("gettext" ,gettext-minimal)
       ("perl" ,perl)
       ("qttools" ,qttools)
       ))
    (inputs
     `(("python-2" ,python-2)
       ;("qt" ,qt) ; cannot find qtquick with modular-qt
       ("qtbase" ,qtbase)
       ("qtdeclarative" ,qtdeclarative)
       ("qtmultimedia" ,qtmultimedia)
       ("qtsensors" ,qtsensors)
       ("qtsvg" ,qtsvg)
       ("qtxmlpatterns" ,qtxmlpatterns)
       ))

So it looks like we have the same package list, unfortunately I couldn't
get it working with modular-qt

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #1.2.1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]