From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OA+3M7JuTWQaFQAASxT56A (envelope-from ) for ; Sat, 29 Apr 2023 21:23:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0NK1M7JuTWRilwAA9RJhRA (envelope-from ) for ; Sat, 29 Apr 2023 21:23:30 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9BFD23E5D2 for ; Sat, 29 Apr 2023 21:23:30 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Pb0g4Ly5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682796210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9LFeL7l7LE5J2ndqbCbw5hKIGzSWVdt45VK5TRc55k4=; b=PF2w9a92LFAiIL+9UdcXldsYQW3aneLCtMpGJ5g3kTa/NDl7yjQW6zi4puFnLdsKDXRL7T EiS7/pM4pU0HF7Ro7BYoOVlUrrwT14MqtzGaZ+kfhcmGsVIYhvLQp40drwwYMIREFDvp/7 YX2dJUxDuuo+9L+WxLLyZtlQR2wTT7/ACzIkG6dtKBPAjYzs5bYvDUonDohznLyxyl6X5g rXSyLt3l5E+7R6FPajsxnpSMicElbm0acSdsxkVaaMvPRkmkSoXGlSDh8NG520Zn+/adt7 jqFizFBv+qnUegdpiDSpDauZaei559MDWw07PkDO4gW6FvHjK3ykXwJ/7QkU3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Pb0g4Ly5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682796210; a=rsa-sha256; cv=none; b=TeL0hDIVCZ/TxFB4MfmGUmDoIVkX30zjSX1vK23Rk2cucFke9RCTM3mXCYqyzb9liGZw7R NkQKldmGoNBbY/+LgrEW4eyPHosSXUTR21MTdJ5IeYEitp4MJhzN3sr2/H372OEuPaZ4H3 FSOdw4YrJV4BnwsJUv8fgz5a5XRBH6s/6NrokO+55ctieF/tNYljh0E1h16/a1fToUm95j qxUPhpXYYiUSd0wmyINLBBVvKIi+GncmHEnavAZiE9x3vMsRdOnd/bmd0kTvah+FSWqFD4 FOb5j8NWv7Dr4aokreDzJNis+EQVkPDcvJa0y/axCuHpISL4o3+epFH18Xtaiw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psoHs-00017G-K8; Sat, 29 Apr 2023 13:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psoHp-00014U-RV for bug-guix@gnu.org; Sat, 29 Apr 2023 13:23:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1psoHp-0003N5-Id for bug-guix@gnu.org; Sat, 29 Apr 2023 13:23:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1psoHp-00007u-DU for bug-guix@gnu.org; Sat, 29 Apr 2023 13:23:05 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v2 11/16] services: mpd: Warn when the MPD user is not in the "audio" group. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 29 Apr 2023 17:23:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 63082@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168278894132730 (code B ref 63082); Sat, 29 Apr 2023 17:23:05 +0000 Received: (at 63082) by debbugs.gnu.org; 29 Apr 2023 17:22:21 +0000 Received: from localhost ([127.0.0.1]:36564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psoH6-0008Vi-P3 for submit@debbugs.gnu.org; Sat, 29 Apr 2023 13:22:21 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:62486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psoH1-0008T6-9Q for 63082@debbugs.gnu.org; Sat, 29 Apr 2023 13:22:15 -0400 Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7515631b965so184093085a.0 for <63082@debbugs.gnu.org>; Sat, 29 Apr 2023 10:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682788935; x=1685380935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9LFeL7l7LE5J2ndqbCbw5hKIGzSWVdt45VK5TRc55k4=; b=Pb0g4Ly5kDJ8COpXrAMwrgXHzbUqeJsVkn7f5eQDxxI9ps1jKqn07BGOHBL5z+M9W+ UumAQ3AEpD12JynIEAqjQ99JzZ2EZEgkL+/Sr1ajJI0mr4gEQ6lexfUYNaWFkHEjSZz3 LJkxu9RC81riKD8UaVmUWNIq06w7b8EQGmwoDdhOdw7DYP4jGOyrHn+mPm1dbQkJRX9F 9peXOLg6NQvtAX5x1CxTKN1Ksx3RiRTFzWir/ZqDx8rckzF3gfgKa4AfgYnH/O11eEqD 13eqatvlazmdFU82sWNA8lqSRK2TJdEaKk3IDNIxWoBSgKElxZfHnGJhdQ8yli+HpdY9 TZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682788935; x=1685380935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9LFeL7l7LE5J2ndqbCbw5hKIGzSWVdt45VK5TRc55k4=; b=EqgaVVBgW7lSijdJTz+6z0ND4SAii4ZDgv/lSIuiXsTZQlON2NQYh035PwLElRbh2p zX9e64GH8lf/JbGNa3LZwzCyX4DYYRv/d4PEMHgvZjDqXv0xvh0VgeHdCCN9h3FCS5fN XPDEmAqAx2pCgkt5FlaaSKwGrf7RuLdYw7G5gf94MbQUy2xYhLuYEXk5grw1v7/ZYLdW 6JKa+MlFfQOUTTR93OaIbVV1SS1yOPUXyiKtuJNurVuHeTbyhd6uOcpz2lNu7XVoUFju JFsph5cn6ryw5ZLITgjIjvX0nnG7NhKDrVzz7Ziq+WXC1I0b5bZUDaBihW0lckdbWc1k /FbQ== X-Gm-Message-State: AC+VfDzSg4wZMZTWU56ySLs6wR5IYFnklTsM5dZ+PB9QnVGKsaY0gZwr pxZ13ls3zywUhugmzJA6ma+sGnmdSSc= X-Google-Smtp-Source: ACHHUZ5yswg+Jjw85xBt9/iZGosVY5XN3rZWYcRmUp9bBIbF3nbWeBIeXAgsPhHJFj05NvnN2vr0SQ== X-Received: by 2002:a05:6214:5297:b0:5e7:c44f:5098 with SMTP id kj23-20020a056214529700b005e7c44f5098mr23284874qvb.13.1682788934771; Sat, 29 Apr 2023 10:22:14 -0700 (PDT) Received: from localhost.localdomain (dsl-155-245.b2b2c.ca. [66.158.155.245]) by smtp.gmail.com with ESMTPSA id dm45-20020a05620a1d6d00b0074cf009f443sm7582489qkb.85.2023.04.29.10.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 10:22:14 -0700 (PDT) From: Maxim Cournoyer Date: Sat, 29 Apr 2023 13:21:48 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: UNKNOWN X-Migadu-Spam-Score: 5.95 X-Spam-Score: 5.95 X-Migadu-Queue-Id: 9BFD23E5D2 X-Migadu-Scanner: in3.migadu.com X-TUID: oZNiSijyJimR Relates to . * gnu/services/audio.scm (%mpd-user) [group]: Add comment. (mpd-user-sanitizer): Warn if the MPD user is not in the audio group. --- gnu/services/audio.scm | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm index f470ca20e0..7040a63ecd 100644 --- a/gnu/services/audio.scm +++ b/gnu/services/audio.scm @@ -31,6 +31,7 @@ (define-module (gnu services audio) #:use-module (gnu services configuration) #:use-module (gnu services shepherd) #:use-module (gnu services admin) + #:use-module (gnu system accounts) #:use-module (gnu system shadow) #:use-module (gnu packages admin) #:use-module (gnu packages mpd) @@ -173,6 +174,8 @@ (define-maybe boolean (prefix mpd-)) (define %mpd-user (user-account (name "mpd") + ;; Being in the audio group ensures that PulseAudio can access sound + ;; devices. (group "audio") (system? #t) (comment "Music Player Daemon (MPD) user") @@ -209,10 +212,17 @@ (define (mpd-serialize-port field-name value) (define-maybe port (prefix mpd-)) -;;; Procedures for unsupported value types, to be removed. - +;;; Sanitizer procedures. (define (mpd-user-sanitizer value) - (cond ((user-account? value) value) + (cond ((user-account? value) + (match-record value + (group supplementary-groups) + (unless (or (string=? "audio" group) + (member "audio" supplementary-groups)) + ;; Being in the "audio" group is necessary for access to the + ;; sound devices. + (warning (G_ "mpd user not member of \"audio\" group~%")))) + value) ((string? value) (warning (G_ "string value for 'user' is deprecated, use \ user-account instead~%")) -- 2.39.2