all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>,
	Guix-devel <guix-devel@gnu.org>
Cc: blake@reproduciblemedia.com,
	"Julien Lepiller" <julien@lepiller.eu>,
	"Ludovic Courtès" <ludo@gnu.org>,
	"Philip McGrath" <philip@philipmcgrath.com>
Subject: Re: [PATCH] doc: Update contribution guidelines on patches, etc.
Date: Tue, 9 Aug 2022 22:40:30 +0200	[thread overview]
Message-ID: <a7afdca1-6b43-f988-c31c-07d1293a2a8d@telenet.be> (raw)
In-Reply-To: <f4fd706dd08e2bc194b1f697bf2cfed220e037ae.camel@gmail.com>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 1514 bytes --]


On 09-08-2022 21:08, Liliana Marie Prikler wrote:
>> To be clear, do you mean you:
>>   * think it's not better, maybe even worse
>>   * think it's not_much_  better (but still_slightly_  better)
>>   * are undecided
>>   * or something else
>> ?
>> Also, "guix build -S" returns the source code (after snippet / patch,
>> if any), not its derivation. For the latter: "guix build -S -d"
> FWIW I don't think mentioning patch-and-repack is too helpful here
> either.  Also, I'd like to use consistent wording at least within this
> section, so here "source" means "upstream source" whereas "source
> derivation" is a shorthand for the stuff Guix builds.  Yes, the
> derivation is not the same thing as the output, but I again fail to see
> how being overly precise is helpful.  That being said, I'm open to
> suggestions.
>
I am not reading an answer to my question.

I don't think I've mentioned patch-and-repack (at least not by name, 
which you seem to be referring to?).

I would not recommend "source = upstream source", as the more general 
meaning is used in (guix)Introduction and 
<https://www.gnu.org/philosophy/free-sw.html> and elsewhere, otherwise 
terminology would become inconsistent, which can lead to misinterpretations.

I don't think there's such a thing as 'overly precise'.

My suggestion is the same as your suggestion:

> You could s/source derivation/the result of
> @code{guix build -S}/, but I don't think that's much better.
Greetings,
Maxime.


[-- Attachment #1.1.1.2: Type: text/html, Size: 2514 bytes --]

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  parent reply	other threads:[~2022-08-09 20:41 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  3:17 A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Maxime Devos
2022-07-25  5:21 ` Julien Lepiller
2022-07-25 11:18   ` Maxime Devos
2022-07-25 11:37     ` Julien Lepiller
2022-08-04  8:51 ` Ludovic Courtès
2022-08-05  3:23 ` Philip McGrath
2022-08-05  8:13   ` Maxime Devos
2022-08-05  3:38 ` Philip McGrath
2022-08-05  8:09   ` Maxime Devos
2022-08-05 10:18 ` Maxime Devos
2022-08-05 13:59 ` v2: " Maxime Devos
2022-08-06  6:55   ` [PATCH] doc: Update contribution guidelines on patches, etc Liliana Marie Prikler
2022-08-06  6:55     ` [PATCH v2] " Liliana Marie Prikler
2022-09-02 13:12       ` Ludovic Courtès
2022-09-02 18:05         ` Maxime Devos
2022-09-05  9:47           ` Ludovic Courtès
2022-09-05 13:12             ` Maxime Devos
2022-09-05 16:05               ` Maxime Devos
2022-08-09 16:45     ` [PATCH] " Maxime Devos
2022-08-09 17:05       ` Liliana Marie Prikler
2022-08-09 18:19         ` Maxime Devos
2022-08-09 19:08           ` Liliana Marie Prikler
2022-08-09 20:30             ` Maxime Devos
2022-08-10  4:25               ` Liliana Marie Prikler
2022-08-09 20:40             ` Maxime Devos [this message]
2022-08-08 21:51   ` v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Andreas Enge
2022-08-09 15:06     ` Maxime Devos
2022-08-09 17:10       ` Andreas Enge
2022-09-05 13:03     ` Maxime Devos
2022-09-07 12:17       ` Andreas Enge
2022-09-07 18:08         ` Maxime Devos
2022-08-09 18:58   ` david larsson
2022-08-09 20:53     ` Maxime Devos
2022-08-10 11:23       ` david larsson
2022-08-05 16:59 ` blake
2022-08-09 16:30   ` Maxime Devos
2022-09-05 14:06     ` Maxime Devos
2022-08-10  6:10   ` blake
2022-08-10  9:06     ` Maxime Devos
2022-08-10 10:33     ` blake
2022-08-10 10:44       ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7afdca1-6b43-f988-c31c-07d1293a2a8d@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=blake@reproduciblemedia.com \
    --cc=guix-devel@gnu.org \
    --cc=julien@lepiller.eu \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    --cc=philip@philipmcgrath.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.