* [bug#43743] [PATCH] Add package emacs-windsize
@ 2020-10-01 12:23 Tomás Ortín Fernández via Guix-patches via
2020-10-04 9:40 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Tomás Ortín Fernández via Guix-patches via @ 2020-10-01 12:23 UTC (permalink / raw)
To: 43743
Add windsize.el Emacs package
* gnu/packages/emacs-xyz.scm (emacs-windsize): Add package definition.
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2b3247f763..e2397bdc85 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -80,6 +80,7 @@
;;; Copyright © 2020 Peng Mei Yu <i@pengmeiyu.com>
;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net>
;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
+;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -24754,3 +24755,24 @@ web development.")
;; file and the header of the main elisp file which indicates
;; that it is licensed under the GPL version 3 or later.
(license (list license:mpl2.0 license:gpl3+)))))
+
+(define-public emacs-windsize
+ (package
+ (name "emacs-windsize")
+ (version "20181029")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/grammati/windsize")
+ (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa")))
+ (sha256
+ (base32
+ "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/grammati/windsize")
+ (synopsis "Easy resizing of emacs windows")
+ (description "Move the borders of the active window with the arrow
+keys (C-S-<dir> by default). Always prefers to move the right or
+bottom border when possible, and falls back to moving the left or top
+border otherwise.")
+ (license license:gpl3+)))
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#43743] [PATCH] Add package emacs-windsize
2020-10-01 12:23 [bug#43743] [PATCH] Add package emacs-windsize Tomás Ortín Fernández via Guix-patches via
@ 2020-10-04 9:40 ` Nicolas Goaziou
2020-10-04 14:58 ` Tomás Ortín Fernández
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2020-10-04 9:40 UTC (permalink / raw)
To: 43743; +Cc: tomasortin
Hello,
Tomás Ortín Fernández via Guix-patches via <guix-patches@gnu.org>
writes:
> Add windsize.el Emacs package
Thank you. Somme comments follow.
> + (version "20181029")
This is not the official release number. This should be "0.1", with an
appropriate revision number since you're not using the release tag. Also
there should be a comment explaining why you're not using that release
tag (almost 10 years old here).
See, for example, emacs-dhall-mode package.
> + (source (origin
Please move origin below source.
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/grammati/windsize")
> + (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa")))
The commit should be bound to a variable at the top of the package
definition.
> + (sha256
> + (base32
> + "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))
Nitpick: Please move the hash on the same line as base32
> + (build-system emacs-build-system)
> + (home-page "https://github.com/grammati/windsize")
> + (synopsis "Easy resizing of emacs windows")
-> Emacs windows
> + (description "Move the borders of the active window with the arrow
> +keys (C-S-<dir> by default). Always prefers to move the right or
> +bottom border when possible, and falls back to moving the left or top
> +border otherwise.")
I suggest to use non-imperative wording, e.g., This package allows
moving... It always prefers…
I also suggest to remove the reference to (C-S-<dir> ...) since it
belongs to the documentation of the package, not to its description.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#43743] [PATCH] Add package emacs-windsize
2020-10-04 9:40 ` Nicolas Goaziou
@ 2020-10-04 14:58 ` Tomás Ortín Fernández
2020-10-07 19:54 ` bug#43743: " Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Tomás Ortín Fernández @ 2020-10-04 14:58 UTC (permalink / raw)
To: 43743
Thank you for the feedback. Here is the updated patch:
* gnu/packages/emacs-xyz.scm (emacs-windsize): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3ec431d94..c158aa22e5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -80,6 +80,7 @@
;;; Copyright © 2020 Peng Mei Yu <i@pengmeiyu.com>
;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net>
;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
+;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -24778,3 +24779,27 @@ web development.")
;; file and the header of the main elisp file which indicates
;; that it is licensed under the GPL version 3 or later.
(license (list license:mpl2.0 license:gpl3+)))))
+
+(define-public emacs-windsize
+ ;; There is no proper release. The base version is extracted from the
+ ;; "Version" keyword in the main file.
+ (let ((revision "1")
+ (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa"))
+ (package
+ (name "emacs-windsize")
+ (version (git-version "0.1" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/grammati/windsize")
+ (commit commit)))
+ (sha256
+ (base32 "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/grammati/windsize")
+ (synopsis "Easy resizing of Emacs windows")
+ (description "This package allows moving the borders of the active window
+with the arrow keys. It prefers to move the right or bottom border when
+possible, and falls back to moving the left or top border otherwise.")
+ (license license:gpl3+))))
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#43743: [PATCH] Add package emacs-windsize
2020-10-04 14:58 ` Tomás Ortín Fernández
@ 2020-10-07 19:54 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2020-10-07 19:54 UTC (permalink / raw)
To: Tomás Ortín Fernández; +Cc: 43743-done
Hello,
Tomás Ortín Fernández <tomasortin@mailbox.org> writes:
> Thank you for the feedback. Here is the updated patch:
>
> * gnu/packages/emacs-xyz.scm (emacs-windsize): New variable.
I moved the package definition elsewhere (the bottom of the file can
lead to merge conflicts) and applied your patch.
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-07 19:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-01 12:23 [bug#43743] [PATCH] Add package emacs-windsize Tomás Ortín Fernández via Guix-patches via
2020-10-04 9:40 ` Nicolas Goaziou
2020-10-04 14:58 ` Tomás Ortín Fernández
2020-10-07 19:54 ` bug#43743: " Nicolas Goaziou
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.