From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4ea1::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SCqQJYhpyGFqqQAAgWs5BA (envelope-from ) for ; Sun, 26 Dec 2021 14:09:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id b4KmH4hpyGHtHgAAG6o9tA (envelope-from ) for ; Sun, 26 Dec 2021 14:09:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48C911D801 for ; Sun, 26 Dec 2021 14:09:28 +0100 (CET) Received: from localhost ([::1]:56282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1THD-0001jE-5U for larch@yhetil.org; Sun, 26 Dec 2021 08:09:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1TGo-0001ix-Rc for guix-patches@gnu.org; Sun, 26 Dec 2021 08:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1TGo-0004rI-Gu for guix-patches@gnu.org; Sun, 26 Dec 2021 08:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1TGo-0002hz-D7 for guix-patches@gnu.org; Sun, 26 Dec 2021 08:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52774] [PATCH] import: elpa: Also check NonGNU ELPA for updates. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52774 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 52774@debbugs.gnu.org Received: via spool by 52774-submit@debbugs.gnu.org id=B52774.164052410910363 (code B ref 52774); Sun, 26 Dec 2021 13:09:02 +0000 Received: (at 52774) by debbugs.gnu.org; 26 Dec 2021 13:08:29 +0000 Received: from localhost ([127.0.0.1]:40352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1TGH-0002h4-93 for submit@debbugs.gnu.org; Sun, 26 Dec 2021 08:08:29 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1TGE-0002gq-DF for 52774@debbugs.gnu.org; Sun, 26 Dec 2021 08:08:27 -0500 Received: by mail-wm1-f67.google.com with SMTP id p1-20020a1c7401000000b00345c2d068bdso7065235wmc.3 for <52774@debbugs.gnu.org>; Sun, 26 Dec 2021 05:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=69dGpUXDszwctAV0/wONL3qu45/i9i6TgRQ3G6QW9O8=; b=pOeDv59LHdpWIJfQoOdJNAc6NwS4TLCMtwVOTDjQCghdq/wml6Zm6ASIvx34cL3xdu es4YFpVNJK6dEfd3EwteQhGXZMapbDurRMLpUuaNIgIQpJCpK1rYD/D7oiPBlNEHzgTf nBIE1c3E0Fe4UU3AkELkOEV7QNzWl3HIpsbgZonmCV7iAD4+VDXZOsjFcWqHkzMG5wBk K1ee0k+ht5QuDNj0BqDWM6vsHBPFbPPv4JZuPXtb+F4r30bMPTAx1DAw2lfeI2wI8x86 uM9bYPxzaslP8L22IXxXjrpcblBTOyhpB98No30NgCCIhpLOJTVSLNbwKDoPM17zT+c9 rtKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=69dGpUXDszwctAV0/wONL3qu45/i9i6TgRQ3G6QW9O8=; b=zweJS5ghIrBRwOl6nE1NI6hqimhrXsPKRauGHZ4bHzcJEpMKacubiTaIm+EoHPRPgy XxCBTSIuJj3Nua2cBSUtFdzORWlcL+wDVIiOEiU186Zi2mmGCoWJVqJCgcYnoiSzRFj5 J8x227bj77PLGnXXFku3vwmJtDq2jdiXNOD1GxTqRHGHJHRHYsz2MClVhMUNo/GoVjor hMTMsiZV8pX9cmwkjDX5E4IM3Tk5CkNd9Xw39K56aNbLDiELMeKs7SgCvfr1lCWh0R5L lri+FDHOWRLX7wgBNBWLpQMo3Puh0MS6TEF72miPRYWbtVROFkdKNFz8Tck64Exy5ebY T2MA== X-Gm-Message-State: AOAM532QWA0oazoUpgvLIK3G9rrh4Cw8okqgrGVaz496fn+k4pwWLgmj bjZn9UH2ZQD6sGWU6yi85WY= X-Google-Smtp-Source: ABdhPJyv2b3bAcbZjgTemGFP+Jvtm6dv+CNpeBesEIuPqEJbKB4gmfrBcGN50bmofPrd0cY84p7o8g== X-Received: by 2002:a05:600c:204d:: with SMTP id p13mr10565161wmg.102.1640524100445; Sun, 26 Dec 2021 05:08:20 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id r1sm14905264wrz.30.2021.12.26.05.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 05:08:19 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Sun, 26 Dec 2021 14:08:18 +0100 In-Reply-To: <87ee5zbknh.fsf@yoctocell.xyz> References: <87ee5zbknh.fsf@yoctocell.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640524168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=69dGpUXDszwctAV0/wONL3qu45/i9i6TgRQ3G6QW9O8=; b=qDlbJc9NVnhDI82NFeUqtliB9JQgWKvvL6D+fX5HoGwMYvXWToT1L/nmGwyPhgZAgYlHFb eQFN6tKCYspA0rHVRZjx+KzncRGoHsUfgv/aLb1IUXj9reaM/X8ueOYHxurT0ftiVo6raq hg3oQaqWeasUZpHT5EEJfqp5JCnJHUsF0K4uJXFLxTkTq0QhuDzvvAHo/4228of671l24w kqQOjTHmrX4r0M/rEhusNt96cU0j/iJ61DZ+Hjzm6Gm+HbI4xmldZjGN+zJjt6jxlZ4XHs 4XN1qL4E77f1QY+0C4t2B/x7IzHj9DM1n497AYLAD+c4YybmZ4AE8rYQtt4zxw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640524168; a=rsa-sha256; cv=none; b=USnhqONmNvQiFyfI3Pzuzw7ySuzL+9gqE0TgLfqGr+byBSTTxEc4W81BGH7kdg3VEa7J3l H1b9/5hciKFnkHTbYwb/rS1+99rDSKBfYRsXtO8SrRQJ/bwoQbzc3R4EXqwK8uRzsXFpdR WJtrk9vo/ek/B9LW+/AgLR2qOo37az8ATRZECJ234gM/RoweQeSpvtuVkloj16M64HjrTG ZtQ+KBWxlZzTW9CD/sk9VZcocHsNgNChYEDXUrGKqIWDgiGbUYMHmqQbK3Dess7/yyaV9R OYPDbsHwWsDxg/INPrHNzVid1hEImPe+77l0kMqAIad3MpQGrkI3ycFt3EEyfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pOeDv59L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pOeDv59L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 48C911D801 X-Spam-Score: -1.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: b6Kh9s0C7luM Hi Xinglu, Am Sonntag, dem 26.12.2021 um 13:44 +0100 schrieb Xinglu Chen: > > > I am not sure I follow.  If ‘elpa-package?’ returned #f, the > > > following would return #f. > > > > > >   (member (elpa-package? pkg) '(gnu nongnu)) > > > > > > Meaning that PKG is not hosted on GNU or NonGNU ELPA, and thus, > > > should not be checked for updates. > > > > > > When including #f in the list, the value returned by the ‘member’ > > > expression would be '(#f), which means that PKG would be checked > > > for updates, even though it shouldn’t. > > I think you're misunderstanding what I'm saying, but that might be > > because I worded it badly.  My suggestion was to make elpa-package? > > a "predicate with meaning", which returns #f if PKG is not an ELPA > > package, and a truthy value otherwise, said truthy value being the > > symbol 'gnu or 'nongnu at the moment > > That was what I had in mind as well, but I don’t see why we would > need '(gnu nongnu #f) instead of just '(gnu nongnu).  If PKG is not > in ELPA, we _don’t_ want to check for updates, and therefore, #f > shouldn’t be a member of the list. Because (eq? (elpa-package? NOT_AN_ELPA_PACKAGE) #f) needs to be defined behaviour. > I took a stab at the problem (patch attached below), and the result > seems to be what would be expected. > > --8<---------------cut here---------------start------------->8--- > $ ./pre-inst-env guix refresh -t elpa emacs-caml emacs-project emacs- > helm > gnu/packages/emacs-xyz.scm:10870:2: warning: no updater for emacs- > helm                   ;github > gnu/packages/emacs-xyz.scm:636:13: 0.8.1 is already the latest > version of emacs-project  ;gnu > gnu/packages/emacs-xyz.scm:2751:13: 4.9 is already the latest version > of emacs-caml      ;nongnu > --8<---------------cut here---------------end--------------->8--- In my personal opinion, elpa-repository as you defined it in that patch would already be a valid value for the pred field of %elpa-updater. There is no need to define a procedure that does the member call and in fact it makes it harder to update the updater, as now two locations have to be updated. If there is a requirement to only return #t or #f we could make it (compose ->bool elpa-repository) Cheers