From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6G0SAQg8y2apIwAAe85BDQ:P1 (envelope-from ) for ; Sun, 25 Aug 2024 14:13:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6G0SAQg8y2apIwAAe85BDQ (envelope-from ) for ; Sun, 25 Aug 2024 16:13:28 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=rQbKPeBc; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=n0WHF9uV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1724595207; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mod8hG5f6stJ0OFNE53tZvbzHOd5wi3/2Tdce24Z9dA=; b=PwAvy35x0dt/Zmk9QCY22HgbG35F3jpojVXFv4/0UT0IAQnC5F2FJEPiSAIKeLQD9PkArb T4PUxOpXJi+sauJquQ36poowb+F6h8AzMwoUjW4PQJgychosdlftfXX7r4BUTgV/gRZwaA B+rbH1UD+48lNhGHoKBfEDVpMRK24YRe4eFEI4ANwCpw3RMGCnRbUrmBY/AzGQ/r+E6VN7 USsRBamRao3Dy+fshsbdTLednB5HBLRy90ZUQ/8Fc5a/xhup8Xf2LSyAWdkKfgCrnV+/HS KUzAHCDz4Om4C7paSTvZf10mThKw1vwNcHrt98u7Gos/dHIxv8YVAc1Tfd0a5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1724595207; a=rsa-sha256; cv=none; b=VtSSiEykCepw0PFpT4BG+zaqhUh5jJJtmC2UJidWvlLTt14F6BMMKoW2VorVG5mRAO/Ivr sQHVHuk5QGtGnPYtuFpp8wP2TXxIPDmKL8yVuK7+lXYLZvPO3iIAkRZvNfX438Eiv3XuT5 WiA6bZsIwewA/EXEuyRnXYLGH9p7OCqNLuY9k0vjd64x7EggmsjVlTdOFWjJTXxWqlXpgs QnPrjbK1IVE/ssMmI+Ifgow9UtyGf0rn1Goevuva+gaDTXxMgt/HeBIBKp6BWueNOgyIvG Ke8PJ92jUUQW0GkjPF9tgbOqbNGfv5IdnOx4OwSYC432baFUeN6p81cUFwBgkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=rQbKPeBc; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=n0WHF9uV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A444C77395 for ; Sun, 25 Aug 2024 16:13:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1siDzW-0005pQ-U3; Sun, 25 Aug 2024 10:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1siDzU-0005pA-4f for guix-patches@gnu.org; Sun, 25 Aug 2024 10:13:12 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1siDzT-00086A-SP for guix-patches@gnu.org; Sun, 25 Aug 2024 10:13:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:MIME-Version:Date:To:In-Reply-To:References:Subject; bh=mod8hG5f6stJ0OFNE53tZvbzHOd5wi3/2Tdce24Z9dA=; b=rQbKPeBcmjKye+7h6/R9HBe7kfnK/bPvKuwmQOxb3EC6rds8hIPvP9OFz0TN2+RoE3GPqqKD4g5Lm3UKRmV6aefT2mCIhwMDP+FEwooS3mzSPKGIPVyM1KQvdGnNyUwiZAz3JQc9oka80xWM0FL0G+fFWVbNADNvYTs7/JAL+aP5g+04Ujvluj7o38qOFQYxBrWJt9FQU7s9ipON94Frx5NczBL+jRT2eZU7TzN2WP9Zb9CmniP6whzxAWnU6BvgJ8snL1hYiGl4ORZmlrnOM5+mbRSYvDBf8vQHtSBiNNCG+fr+ReM+XBR5E7BfQmFtyoRL3Ir3bdsuLAhrQoHOuQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1siE0H-0007c0-PV for guix-patches@gnu.org; Sun, 25 Aug 2024 10:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71639] [PATCHv2 0/5] Improve on restic-backup-service References: In-Reply-To: Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 25 Aug 2024 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71639 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71639@debbugs.gnu.org Received: via spool by 71639-submit@debbugs.gnu.org id=B71639.172459523329237 (code B ref 71639); Sun, 25 Aug 2024 14:14:01 +0000 Received: (at 71639) by debbugs.gnu.org; 25 Aug 2024 14:13:53 +0000 Received: from localhost ([127.0.0.1]:43108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siE08-0007bU-Nz for submit@debbugs.gnu.org; Sun, 25 Aug 2024 10:13:53 -0400 Received: from confino.investici.org ([93.190.126.19]:45929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siE06-0007bJ-A2 for 71639@debbugs.gnu.org; Sun, 25 Aug 2024 10:13:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1724595171; bh=mod8hG5f6stJ0OFNE53tZvbzHOd5wi3/2Tdce24Z9dA=; h=Date:To:From:Subject:From; b=n0WHF9uVLn7j6Dz5OOLHdxpFh4shK8iptIwbgBxOpj9Iwcjea6fLBgIASO+i9iEFW OjQTL8L+X3/DoEqD8cUK6l2KAEjEKlMLK9bCbhT8jAbp4o7QzalZ408ARWW2TTCgqH z8nQYCJSoHw2y17RrBSb3QuttEjrGHibloPiHOlA= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4WsG3l6MRwz112c for <71639@debbugs.gnu.org>; Sun, 25 Aug 2024 14:12:51 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4WsG3l5xxzz1106 for <71639@debbugs.gnu.org>; Sun, 25 Aug 2024 14:12:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------PsW6uP1wOjXuKKz6zavJfoni" Message-ID: Date: Sun, 25 Aug 2024 16:12:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: paul X-ACL-Warn: , paul via Guix-patches From: paul via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.08 X-Spam-Score: -4.08 X-Migadu-Queue-Id: A444C77395 X-Migadu-Scanner: mx11.migadu.com X-TUID: Ro+rBSNclik3 This is a multi-part message in MIME format. --------------PsW6uP1wOjXuKKz6zavJfoni Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Dear Fabio and Richard, I apologize for blocking this issue with my proposal. I think Fabio's proposal of splitting the changes in this patch is the best way forward, if you agree as well Richard. I submitted [0] to refactor the restic-guix procedure in a way that it can support many different commands. After it gets in it should be sufficient to add "init" to %restic-guix-supported-actions to have a working restic-guix init invokation. it should be then matter of understanding where it is better to put it. Lately I was thinking that may be best to have initialization as a one shot Shepherd service that check whether a given job is supposed to have its repository initialized and if that's the case it could run restic-guix init name-of the job. Please Richard let me know what you think of this approach and whether you would still be interested in implementing it, thank you very much! I think the following subdivision should match all requirements we stated until now: 1. Improve the restic backup system service . This can be done in the current issue #71639: services: backup: Add password-command support to restic-service services: backup: Add extra-packages field to restic-backup-job services: backup: Move restic package to restic-configuration 2. Refactor the restic-guix function to allow for more restic commands to be wrapped. This can be done in issue #72803: services: restic-backup: Add more restic commands to the restic-guix package. 3. Allow for repositories to be initialized with a restic-guix init command. This commit could be adapted and moved to a new branch based on #72803: services: backup: Support bootstrapping an initial restic backup What do you think? Could this be a suitable action plan? Thank you very much for your work, giacomo [0]: https://issues.guix.gnu.org/72803 --------------PsW6uP1wOjXuKKz6zavJfoni Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Dear Fabio and Richard,

I apologize for blocking this issue with my proposal. I think Fabio's proposal of splitting the changes in this patch is the best way forward, if you agree as well Richard. I submitted [0] to refactor the restic-guix procedure in a way that it can support many different commands.

After it gets in it should be sufficient to add "init" to %restic-guix-supported-actions to have a working restic-guix init invokation. it should be then matter of understanding where it is better to put it. Lately I was thinking that may be best to have initialization as a one shot Shepherd service that check whether a given job is supposed to have its repository initialized and if that's the case it could run restic-guix init name-of the job. Please Richard let me know what you think of this approach and whether you would still be interested in implementing it, thank you very much!

I think the following subdivision should match all requirements we stated until now:

1. Improve the restic backup system service . This can be done in the current issue #71639:

services: backup: Add password-command support to restic-service
services: backup: Add extra-packages field to restic-backup-job
services: backup: Move restic package to restic-configuration

2. Refactor the restic-guix function to allow for more restic commands to be wrapped. This can be done in issue #72803:

services: restic-backup: Add more restic commands to the restic-guix package.

3. Allow for repositories to be initialized with a restic-guix init command. This commit could be adapted and moved to a new branch based on #72803:

services: backup: Support bootstrapping an initial restic backup

What do you think? Could this be a suitable action plan?

Thank you very much for your work,

giacomo


[0]: https://issues.guix.gnu.org/72803
--------------PsW6uP1wOjXuKKz6zavJfoni--