all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Timo Eisenmann <eisenmann@fn.de>
To: ludo@gnu.org
Cc: 32811@debbugs.gnu.org
Subject: [bug#32811] [PATCH] enlightenment.scm: Fix initial locale and keyboard selection
Date: Wed, 26 Sep 2018 17:37:50 +0200	[thread overview]
Message-ID: <a3d9048a-157b-26d6-85d1-d1e857e5ea53@fn.de> (raw)
In-Reply-To: <87a7o44smg.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hi Ludo,

>>> Do you happen to know what part of the Enlightenment code refers to 
>>> the ‘locale’ command? 
>> Enlightenment uses output = popen("locale -a", "r"); in these three 
>> files: src/bin/e_intl.c (_e_intl_locale_system_locales_get) 
>> src/modules/conf_intl/e_int_config_intl.c (_fill_data) 
>> src/modules/wizard/page_010.c (wizard_page_init) 'page_010' is the 
>> language selection screen during first time config. 
> In that case a proper solution would be to replace ‘locale’ with 
> ‘/gnu/store/…/bin/locale’ in the files above, using the ‘substitute*’ 
> macro. Would you like to give it a try? There are many examples of 
> similar uses of ‘substitute*’ in the package definitions.

I attached a patch that uses 'substitute*'.

Thanks for your help,
Timo Eisenmann


[-- Attachment #2: 0001-enlightenment.scm-Fix-initial-locale-and-keyboard-se.patch --]
[-- Type: text/plain, Size: 1976 bytes --]

From 28035fa1ff242d1e4d45fccf0dfe58742702d6aa Mon Sep 17 00:00:00 2001
From: Timo Eisenmann <eisenmann@fn.de>
Date: Wed, 26 Sep 2018 17:01:33 +0200
Subject: [PATCH] enlightenment.scm: Fix initial locale and keyboard selection

* gnu/packages/enlightenment.scm (enlightenment): Fix paths to 'locale' and 'xorg.lst'
---
 gnu/packages/enlightenment.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 45dc1dbbe..0ced70288 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -268,13 +268,19 @@ Libraries with some extra bells and whistles.")
          (add-before 'configure 'set-system-actions
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((xkeyboard (assoc-ref inputs "xkeyboard-config"))
-                   (utils     (assoc-ref inputs "util-linux")))
+                   (utils     (assoc-ref inputs "util-linux"))
+                   (libc      (assoc-ref inputs "libc")))
                ;; We need to patch the path to 'base.lst' to be able
                ;; to switch the keyboard layout in E.
-               (substitute* "src/modules/xkbswitch/e_mod_parse.c"
+               (substitute* (list "src/modules/xkbswitch/e_mod_parse.c"
+                                  "src/modules/wizard/page_011.c")
                  (("/usr/share/X11/xkb/rules/xorg.lst")
                   (string-append xkeyboard
                                  "/share/X11/xkb/rules/base.lst")))
+               (substitute* (list "src/bin/e_intl.c"
+                                  "src/modules/conf_intl/e_int_config_intl.c"
+                                  "src/modules/wizard/page_010.c")
+                 (("locale -a") (string-append libc "/bin/locale -a")))
                (substitute* "src/modules/everything/evry_plug_apps.c"
                  (("/usr/bin/") ""))
                (substitute* "configure"
-- 
2.18.0


  reply	other threads:[~2018-09-26 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23 13:22 [bug#32811] [PATCH] enlightenment.scm: Fix initial locale and keyboard selection Timo Eisenmann
2018-09-24 12:28 ` Ludovic Courtès
2018-09-24 15:39 ` eisenmann
2018-09-24 19:31   ` Ludovic Courtès
2018-09-25 10:51     ` Timo Eisenmann
2018-09-26  7:36       ` Ludovic Courtès
2018-09-26 15:37         ` Timo Eisenmann [this message]
2018-09-26 21:41           ` bug#32811: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3d9048a-157b-26d6-85d1-d1e857e5ea53@fn.de \
    --to=eisenmann@fn.de \
    --cc=32811@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.