From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kEZ4Gqp2LGJ33AAAgWs5BA (envelope-from ) for ; Sat, 12 Mar 2022 11:32:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sEYaF6p2LGKFIwAAauVa8A (envelope-from ) for ; Sat, 12 Mar 2022 11:32:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 997F835A16 for ; Sat, 12 Mar 2022 11:32:09 +0100 (CET) Received: from localhost ([::1]:52358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSz2e-0004lp-3D for larch@yhetil.org; Sat, 12 Mar 2022 05:32:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSz2Y-0004le-87 for guix-patches@gnu.org; Sat, 12 Mar 2022 05:32:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSz2X-0005kB-Uk for guix-patches@gnu.org; Sat, 12 Mar 2022 05:32:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSz2X-00030W-Os for guix-patches@gnu.org; Sat, 12 Mar 2022 05:32:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Mar 2022 10:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54293 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: iyzsong@outlook.com, 54293@debbugs.gnu.org Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 54293-submit@debbugs.gnu.org id=B54293.164708110711538 (code B ref 54293); Sat, 12 Mar 2022 10:32:01 +0000 Received: (at 54293) by debbugs.gnu.org; 12 Mar 2022 10:31:47 +0000 Received: from localhost ([127.0.0.1]:39163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSz2J-000302-Fo for submit@debbugs.gnu.org; Sat, 12 Mar 2022 05:31:47 -0500 Received: from andre.telenet-ops.be ([195.130.132.53]:35302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSz2I-0002zt-9Z for 54293@debbugs.gnu.org; Sat, 12 Mar 2022 05:31:46 -0500 Received: from [172.20.10.9] ([188.189.165.207]) by andre.telenet-ops.be with bizsmtp id 5NXj2700E4UoT8k01NXjtJ; Sat, 12 Mar 2022 11:31:44 +0100 Message-ID: From: Maxime Devos Date: Sat, 12 Mar 2022 11:31:43 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wJxq593M1l8S+fGVsHKG" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647081104; bh=tPpVGuznsh3tZGA9E0w8M6TFxJRPUzkpS4I0oHHznhU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=NRV+5/VLBpaADP2Kxg7oHDBg3GYa25vnAVab413Kc4GHMogRJ9rOElNvbkjRY5qqK Xkh1hFp3qFznoznJYnqdpYJwbzmRvCcBgxDNnvXqRA1uZ2psibfPEh11XyP8iA4cLg ozJJ0Ujsw71s3qPP6KkKND67iEp4WbkHfJxYkOYZuXf34wIyAgXsAkVSreANETJsD2 kKc4f061yQtVF9Xbwl0zlAJZNjo0CepK4qfcr4nq5oADOPBh9f8lgNaFaugcY2in63 MwxqDqj4REEqJ5hMCECqjeqSguV0dpuEgZ3WQXZhYHRDUjWnnPn+1lCBul3T1cR/Fo fGpgbpT38hqLA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647081129; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=tPpVGuznsh3tZGA9E0w8M6TFxJRPUzkpS4I0oHHznhU=; b=lTq7mHjRCmnmq1AT8Q6fWKsJTL/e7k4ZzT+FDsPFLsMBZC9QSy+1v5HdluBhigx9wEeBt8 n90jHT+T544q/BQgdAiZk6T8xdpNLSmGqfAxKujq8TjDrF46+c7Nen8XZmTxZ0hbhjqkdC +xF8Ttt4YQShzQmeCoV0ADr63G2fjYwWS+ZpmQ1LJgjvpePHKZZe8vQlkSFSVsCnyW/Ov/ 9m9gg0jYSnH+fsIYGtNJGVmsE7bXTfkLiabLq+7ap03ndkm5Mie39EhLDEwu5f/7nN2/k/ hIeZl7AMiHkwaDcHOLUkrWOPyovWMFUCXwOHKbWHLukRwUOXbTDINdw0whf39Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647081129; a=rsa-sha256; cv=none; b=OemOJGHwc0IiLAgFOyuMeMYBJy+4pJNQJBdg/CCXoa2SfpC9CgLkzAGWd/+X3huMg+rf1T oDW4zYl20Cwpl3sTIYRdUlCEwDr5ojY9RbDgT45X8Y3SfRg58g5pR5jVLr93tc45uiLiHC r+ij2JMcztHhhkLEfhmpTlVP9RFUb3lHUBfTx7cSc9dOSuAnLdPwugqZnMXq9koYWBlTn5 x5hFaHZ5XTjtwY0G4LmLDDUqjv8LqX36XmlR9JMopqTBtalaYTo4r+BKcg+LUNoISTqFUE Hn6hxgdGotupvBJITcRYR9MEpGOcgDEQhtjxDnEOOjLAuSWjflpiO3Kz2n7I3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="NRV+5/VL"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="NRV+5/VL"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 997F835A16 X-Spam-Score: 3.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0XR/GsKQ4IF+ --=-wJxq593M1l8S+fGVsHKG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable iyzsong@outlook.com schreef op za 12-03-2022 om 10:22 [+0800]: > +=C2=A0 (commit.gpgSign > +=C2=A0=C2=A0 (git-option-value *unspecified*) Would be nice to validate it's a boolean, and not, say, a string or number. > +=C2=A0=C2=A0 "A boolean to specify whether all commits should be GPG sig= ned.") I'm wondering, should 'gpg.program' be set instead of relying on $PATH? Also, this can be overriden with "-S", so perhaps "A boolean specifying whether to sign commits by default, with OpenPGP." Also, the exact implementation (GPG) of OpenPGP used seems an implementation detail, hence my suggestion GPG->OpenPGP. Greetings, Maxime. --=-wJxq593M1l8S+fGVsHKG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYix2jxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qk6AQCiQ/5aVa6P/wzuGjmmcyHwex0o HTOMX7o+vNhu2qJE9AEAs1C/Hyv/8qbvy74ehZ7XDv0ab6zquPdCiGoPrIEfPgo= =Ypip -----END PGP SIGNATURE----- --=-wJxq593M1l8S+fGVsHKG--