From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hellseher Subject: Re: Guix - installation script Date: Thu, 7 Sep 2017 19:11:58 +0100 Message-ID: References: <20170825193351.110a5221@cbaines.net> <878ti6a3lf.fsf@gnu.org> <20170827233617.50a21464@cbaines.net> <20170902170422.080d3e95@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq1Hc-0000R4-Ly for guix-devel@gnu.org; Thu, 07 Sep 2017 14:12:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dq1HX-0003NG-Gh for guix-devel@gnu.org; Thu, 07 Sep 2017 14:12:08 -0400 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:44257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dq1HX-0003Lv-9u for guix-devel@gnu.org; Thu, 07 Sep 2017 14:12:03 -0400 Received: by mail-wm0-x22d.google.com with SMTP id 137so790602wmj.1 for ; Thu, 07 Sep 2017 11:12:02 -0700 (PDT) In-Reply-To: <20170902170422.080d3e95@cbaines.net> Content-Language: en-US List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org Hi, Sorry for delayed replay, it's busy time at work/home. I'll check and fix it as soon as possibly, but you always can pull request it on a GitHub. You also mentioned to send it to guix-devel@gnu.org, which format do you prefer? Regards, HS On 02/09/17 17:04, Christopher Baines wrote: > On Sun, 27 Aug 2017 23:36:17 +0100 > Christopher Baines wrote: > >> On Sat, 26 Aug 2017 21:51:12 +0100 >> Hellseher wrote: >> >>> Hi, >>> >>> That's great, thank you! >>> >>> I'll go through all suggestions and make required changes as soon >>> as possible. >>> >>> Do you want to move that script to separate stand along repository >>> to make it easy for other to review it? >> What might work well is for you to send the whole script to guix-devel >> in an email. Then people can read through and review it. >> >> I'll try to make some time to review and test this in the coming week. > I've tried running this in a Debian VM, and I've nearly managed to get > Guix installed. > > From my experience, I've got some suggestions for the script. > > Firstly, I see this as installing GNU Guix, not GuixSD, as I understand > GuixSD to be an operating system, and this script won't install an OS, > just Guix within your existing operating system. > > For the ascii art, I tweaked it by removing the SD, and adding some > separation between the i and x to make it more readable. > _____ _ _ _ _ _____ _ > / ____| \ | | | | | / ____| (_) > | | __| \| | | | | | | __ _ _ _ __ __ > | | |_ | . ` | | | | | | |_ | | | | |\ \/ / > | |__| | |\ | |__| | | |__| | |_| | | > < > \_____|_| \_|\____/ \_____|\__,_|_|/_/\_\ > > > Just requiring one of curl and wget would be good, either by removing > the need to use curl (it wasn't on the Debian system I was testing > with), or making it possible to use either would work. > > I think the requirement on which could be removed by using the bash > builtin type. > > Also, for checking dependencies, currently when it fails, the entire > script stops as command exits with a status of 1. Something like this > would work though: > > if ! command -v "$c" &>/dev/null; then > warn+=("$c") > fi > > I think running guix package -i at the end might be a bit too much. > Maybe it would be better to suggest running a less permanent command, > e.g. guix environment --ad-hoc hello -- hello, and directing them to > IRC or the mailing list if they have problems? > > Thanks again for writing this :)