all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#71793] [PATCH] ui: Write down the unwritten rule.
@ 2024-06-27 11:44 Tomas Volf
  2024-06-29  6:47 ` jgart via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Tomas Volf @ 2024-06-27 11:44 UTC (permalink / raw)
  To: 71793
  Cc: Tomas Volf, Christopher Baines, Josselin Poiret,
	Ludovic Courtès, Mathieu Othacehe, Simon Tournier,
	Tobias Geerinckx-Rice

Quote from Ludovic:

> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]

This commit turns it into a written rule.

* guix/ui.scm: Document the import policy.

Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
 guix/ui.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
 (define-module (guix ui)
   #:use-module (guix i18n)
   #:use-module (guix colors)
-- 
2.45.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#71793] [PATCH] ui: Write down the unwritten rule.
  2024-06-27 11:44 [bug#71793] [PATCH] ui: Write down the unwritten rule Tomas Volf
@ 2024-06-29  6:47 ` jgart via Guix-patches via
  2024-06-29 18:43   ` Tomas Volf
  0 siblings, 1 reply; 3+ messages in thread
From: jgart via Guix-patches via @ 2024-06-29  6:47 UTC (permalink / raw)
  To: 71793; +Cc: Tomas Volf


> Quote from Ludovic:
> 

Hi Tomas,

Can you link me to the places where you are quoting that from? Thanks!

all best,

jgart




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#71793] [PATCH] ui: Write down the unwritten rule.
  2024-06-29  6:47 ` jgart via Guix-patches via
@ 2024-06-29 18:43   ` Tomas Volf
  0 siblings, 0 replies; 3+ messages in thread
From: Tomas Volf @ 2024-06-29 18:43 UTC (permalink / raw)
  To: jgart; +Cc: 71793

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On 2024-06-29 01:47:52 -0500, jgart wrote:
>
> > Quote from Ludovic:
> >
>
> Hi Tomas,
>
> Can you link me to the places where you are quoting that from? Thanks!

Yes sure, it was given as a reason to not merge patch #2 in 70839:
  https://issues.guix.gnu.org/70839#4-lineno17

It is always possible I just misunderstood.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-29 21:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-27 11:44 [bug#71793] [PATCH] ui: Write down the unwritten rule Tomas Volf
2024-06-29  6:47 ` jgart via Guix-patches via
2024-06-29 18:43   ` Tomas Volf

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.