From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46001)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ecRkT-0006fa-HN
	for guix-patches@gnu.org; Fri, 19 Jan 2018 03:10:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ecRkQ-0005ss-Qd
	for guix-patches@gnu.org; Fri, 19 Jan 2018 03:10:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54345)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ecRkQ-0005sj-NL
	for guix-patches@gnu.org; Fri, 19 Jan 2018 03:10:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ecRkQ-0005MX-F9
	for guix-patches@gnu.org; Fri, 19 Jan 2018 03:10:02 -0500
Subject: [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers.
Resent-Message-ID: <handler.30096.B30096.151634937420578@debbugs.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Fri, 19 Jan 2018 09:09:29 +0100
From: julien lepiller <julien@lepiller.eu>
In-Reply-To: <87a7xaifb3.fsf@gmail.com>
References: <87lgh2uigo.fsf@gmail.com> <87inc6ui1c.fsf@gmail.com>
	<20180113140845.12d7b50e@lepiller.eu> <87a7xaifb3.fsf@gmail.com>
Message-ID: <a18ec3ca004bce953ecab88ebdb5d57a@lepiller.eu>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 30096@debbugs.gnu.org

Le 2018-01-19 06:32, Peter Kreye a écrit :
> Julien,
> 
> Thank you for all of the feedback, it is much appreciated.
> 
> Julien Lepiller writes:
> 
>> Actually, I forgot to ask, why disable tests?
>> 
>> That's the same question for the rest of your patches too.
> 
> This package doesn't have any tests, which seems to be causing the 
> 'check
> phase to fail. Would it be better to use "#:tests? #f" or to delete the
> 'check phase?

I think it's better to use #:tests? #f and leave a comment to explain 
the reason, so:

#:tests? #f; no test suite

Since you disable tests in all your patches, could you leave a comment 
in each of them
to explain why it is disabled?

> 
>> You don't need to replace the 'build phase. ocaml-build-system can 
>> find
>> pkg/pkg.ml. You just need to use #:build-flags (list "build") to add
>> arguments.
>> 
>> That applies also to the rest of your patches.
> 
> Thank you for this info. I'll make sure to do this from now on.
> 
>> It's probably better to use "#:findlib ,ocaml-findlib-1.7.3" in the
>> arguments list.
> 
> Same.
> 
> --

Thank you, I'll push your patches as soon as you send a new version.