From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brett Gilio <brettg@posteo.net>
Subject: Re: Remarks about commit 2c82d4ad10de8
Date: Mon, 16 Dec 2019 17:44:57 +0000 (UTC)
Message-ID: <a10b6425-e456-4408-9e52-736269ab9980@localhost>
References: <87woawgv6w.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34188)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <brettg@posteo.net>) id 1iguQb-0002eQ-Pt
 for guix-devel@gnu.org; Mon, 16 Dec 2019 12:45:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <brettg@posteo.net>) id 1iguQa-0007nw-Ha
 for guix-devel@gnu.org; Mon, 16 Dec 2019 12:45:05 -0500
Received: from mout01.posteo.de ([185.67.36.65]:39540)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <brettg@posteo.net>) id 1iguQa-0007fK-0d
 for guix-devel@gnu.org; Mon, 16 Dec 2019 12:45:04 -0500
Received: from submission (posteo.de [89.146.220.130])
 by mout01.posteo.de (Postfix) with ESMTPS id 08223160060
 for <guix-devel@gnu.org>; Mon, 16 Dec 2019 18:45:01 +0100 (CET)
In-Reply-To: <87woawgv6w.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>


I think you are correct. I likely made a mistake. We should revert the change.

Thanks!

Dec 16, 2019 9:13:31 AM Mathieu Othacehe <m.othacehe@gmail.com>:

> 
> Hello Brett,
> 
> I have a few remarks on the aforementioned commit.
> 
> 
> > + (list (string-append "-DCMAKE_CXX_FLAGS='-isystem "
> > + (assoc-ref %build-inputs "gcc")
> > + "/include/c++'"))))
> > 
> 
> Why is this needed? The following snippet in clang-from-llvm isn't enough?
> 
> --8<---------------cut here---------------start------------->8---
> ;; Make clang look for libstdc++ in the right
> ;; location.
> (("LibStdCXXIncludePathCandidates\\[\\] = \\{")
> (string-append
> "LibStdCXXIncludePathCandidates[] = { \"" gcc "/include/c++\","))
> --8<---------------cut here---------------end--------------->8---
> 
> 
> > + (inputs
> > `(("clang" ,clang)
> > - ("llvm" ,llvm)))
> > + ("ncurses" ,ncurses)))
> > + (native-inputs
> > + `(("rapidjson" ,rapidjson)
> > 
> 
> Rapidjson is an input (even if ccls is not linked against because its a
> header-only library).
> 
> 
> > + ("gcc" ,gcc)))
> > 
> 
> This shouldn't be needed as it is an implicit input.
> 
> Thanks,
> 
> Mathieu
>