From: Tobias Geerinckx-Rice <me@tobias.gr>
To: leo@famulari.name
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.
Date: Mon, 28 Nov 2016 00:15:01 +0100 [thread overview]
Message-ID: <a0fffe2b-a2cd-1633-1a40-f41a90f37e0d@tobias.gr> (raw)
In-Reply-To: <20161127214119.GB30774@jasmine>
[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]
Andreas, Leo,
Thanks for the feedback!
On 27/11/16 22:41, Leo Famulari wrote:
> I'm not sure, but the comment seems to indicate that we don't want to
> use it:
>
> ;; According to
> ;; http://sourceforge.net/projects/libjpeg-turbo/ ,
> ;; "libjpeg-turbo is a derivative of libjpeg that
> ;; uses MMX, SSE, SSE2, and NEON SIMD instructions
> ;; to accelerate baseline JPEG compression/
> ;; decompression", so we had better not use it
There seems to be some misunderstanding here. Sorry if it wasn't clear:
this (libjpeg-turbo) was *already* bundled and used by icecat, as the
‘media/libjpeg’ (sic) that this patch removes. You'll find the same SIMD
code there. For the quote above is missing:
> ;; Fails with "libjpeg-turbo JCS_EXTENSIONS required".
Translation: icecat wouldn't build with Guix's ‘libjpeg’ even if we'd
want that.
And we don't. This isn't some dodgy go-faster fork of IJG's ‘real’
libjpeg. It's intended as a sane alternative to the IJG library, albeit
one that doesn't implement every recent extension. It detects CPU
features at runtime — although they're the status quo now, as Andreas
notes — and falls back to other algorithms that might still be faster.
Dang it. I thought I wrote good (description)s. :-(
Kind regards,
T G-R-turbo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 476 bytes --]
next prev parent reply other threads:[~2016-11-27 23:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 20:17 [PATCH 1/2] gnu: Add libjpeg-turbo Tobias Geerinckx-Rice
2016-11-27 20:17 ` [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg Tobias Geerinckx-Rice
2016-11-27 20:56 ` Leo Famulari
2016-11-27 21:02 ` Tobias Geerinckx-Rice
2016-11-27 21:41 ` Leo Famulari
2016-11-27 21:50 ` Marius Bakke
2016-11-27 22:28 ` Marius Bakke
2016-11-27 22:44 ` Leo Famulari
2016-11-27 22:43 ` Leo Famulari
2016-11-27 23:15 ` Tobias Geerinckx-Rice [this message]
2016-11-27 23:20 ` Tobias Geerinckx-Rice
2016-11-27 23:42 ` Leo Famulari
2016-11-27 23:27 ` Leo Famulari
2016-11-27 20:55 ` [PATCH 1/2] gnu: Add libjpeg-turbo Leo Famulari
2016-11-27 21:12 ` Tobias Geerinckx-Rice
2016-11-27 21:36 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0fffe2b-a2cd-1633-1a40-f41a90f37e0d@tobias.gr \
--to=me@tobias.gr \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.